From: Stephen Boyd <sboyd@codeaurora.org>
To: Erin Lo <erin.lo@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Mike Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Sascha Hauer <kernel@pengutronix.de>,
Daniel Kurtz <djkurtz@chromium.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-clk@vger.kernel.org, srv_heupstream@mediatek.com,
Shunli Wang <shunli.wang@mediatek.com>,
James Liao <jamesjj.liao@mediatek.com>
Subject: Re: [PATCH v12 2/4] reset: mediatek: Add MT2701 reset driver
Date: Wed, 24 Aug 2016 10:50:49 -0700 [thread overview]
Message-ID: <20160824175049.GC19826@codeaurora.org> (raw)
In-Reply-To: <1471854565-19810-3-git-send-email-erin.lo@mediatek.com>
On 08/22, Erin Lo wrote:
> diff --git a/drivers/clk/mediatek/clk-mt2701-hif.c b/drivers/clk/mediatek/clk-mt2701-hif.c
> index 18b4ab5..702fd74 100644
> --- a/drivers/clk/mediatek/clk-mt2701-hif.c
> +++ b/drivers/clk/mediatek/clk-mt2701-hif.c
> @@ -52,11 +52,15 @@ static int mtk_hifsys_init(struct device_node *node)
> clk_data);
>
> r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
> - if (r)
> + if (r) {
> pr_err("%s(): could not register clock provider: %d\n",
> __func__, r);
> + return r;
> + }
> +
> + mtk_register_reset_controller(node, 1, 0x34);
The cleanup here isn't great. mtk_register_reset_controller()
should really return an error so that we can properly cleanup if
needed. Fixing that in a later patch would be a good idea.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 2/4] reset: mediatek: Add MT2701 reset driver
Date: Wed, 24 Aug 2016 10:50:49 -0700 [thread overview]
Message-ID: <20160824175049.GC19826@codeaurora.org> (raw)
In-Reply-To: <1471854565-19810-3-git-send-email-erin.lo@mediatek.com>
On 08/22, Erin Lo wrote:
> diff --git a/drivers/clk/mediatek/clk-mt2701-hif.c b/drivers/clk/mediatek/clk-mt2701-hif.c
> index 18b4ab5..702fd74 100644
> --- a/drivers/clk/mediatek/clk-mt2701-hif.c
> +++ b/drivers/clk/mediatek/clk-mt2701-hif.c
> @@ -52,11 +52,15 @@ static int mtk_hifsys_init(struct device_node *node)
> clk_data);
>
> r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
> - if (r)
> + if (r) {
> pr_err("%s(): could not register clock provider: %d\n",
> __func__, r);
> + return r;
> + }
> +
> + mtk_register_reset_controller(node, 1, 0x34);
The cleanup here isn't great. mtk_register_reset_controller()
should really return an error so that we can properly cleanup if
needed. Fixing that in a later patch would be a good idea.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-24 17:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 8:29 [PATCH v12 0/4] Add clock support for Mediatek MT2701 Erin Lo
2016-08-22 8:29 ` Erin Lo
2016-08-22 8:29 ` Erin Lo
2016-08-22 8:29 ` [PATCH v12 1/4] clk: mediatek: Add MT2701 clock support Erin Lo
2016-08-22 8:29 ` Erin Lo
2016-08-22 8:29 ` Erin Lo
2016-08-24 17:49 ` Stephen Boyd
2016-08-24 17:49 ` Stephen Boyd
2016-08-24 17:49 ` Stephen Boyd
2016-08-27 4:16 ` James Liao
2016-08-27 4:16 ` James Liao
2016-08-27 4:16 ` James Liao
2016-08-29 17:46 ` Stephen Boyd
2016-08-29 17:46 ` Stephen Boyd
2016-08-22 8:29 ` [PATCH v12 2/4] reset: mediatek: Add MT2701 reset driver Erin Lo
2016-08-22 8:29 ` Erin Lo
2016-08-22 8:29 ` Erin Lo
2016-08-24 17:50 ` Stephen Boyd [this message]
2016-08-24 17:50 ` Stephen Boyd
2016-08-27 4:21 ` James Liao
2016-08-27 4:21 ` James Liao
2016-08-27 4:21 ` James Liao
2016-08-22 8:29 ` [PATCH v12 3/4] arm: dts: mt2701: Add clock controller device nodes Erin Lo
2016-08-22 8:29 ` Erin Lo
2016-08-22 8:29 ` Erin Lo
2016-08-22 8:29 ` [PATCH v12 4/4] arm: dts: mt2701: Use real clock for UARTs Erin Lo
2016-08-22 8:29 ` Erin Lo
2016-08-22 8:29 ` Erin Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824175049.GC19826@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=erin.lo@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=shunli.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.