From: "Bill O'Donnell" <billodo@redhat.com>
To: Zorro Lang <zlang@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_quota: fix missing break after foreign_allowed option
Date: Fri, 26 Aug 2016 08:36:26 -0500 [thread overview]
Message-ID: <20160826133626.GA1865@redhat.com> (raw)
In-Reply-To: <1472200206-15728-1-git-send-email-zlang@redhat.com>
On Fri, Aug 26, 2016 at 04:30:06PM +0800, Zorro Lang wrote:
> New quota "-f" has been brought in by:
>
> 29647c8 xfs_quota: add capabilities for use on non-XFS filesystems
>
> But Coverity Scan find a missing break in quota/init.c: init()
> function.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
Sorry about that.
Thanks for the patch, Zorro.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
> quota/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/quota/init.c b/quota/init.c
> index 44be322..2c18c8b 100644
> --- a/quota/init.c
> +++ b/quota/init.c
> @@ -153,6 +153,7 @@ init(
> break;
> case 'f':
> foreign_allowed = true;
> + break;
> case 't':
> mtab_file = optarg;
> break;
> --
> 2.7.4
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-08-26 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 8:30 [PATCH] xfs_quota: fix missing break after foreign_allowed option Zorro Lang
2016-08-26 12:31 ` Eric Sandeen
2016-08-26 13:36 ` Bill O'Donnell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826133626.GA1865@redhat.com \
--to=billodo@redhat.com \
--cc=xfs@oss.sgi.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.