[PATCH] xfs_quota: fix missing break after foreign_allowed option

[PATCH] xfs_quota: fix missing break after foreign_allowed option

[Zorro Lang]

New quota "-f" has been brought in by:

  29647c8 xfs_quota: add capabilities for use on non-XFS filesystems

But Coverity Scan find a missing break in quota/init.c: init()
function.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---
 quota/init.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/quota/init.c b/quota/init.c
index 44be322..2c18c8b 100644
--- a/quota/init.c
+++ b/quota/init.c
@@ -153,6 +153,7 @@ init(
 			break;
 		case 'f':
 			foreign_allowed = true;
+			break;
 		case 't':
 			mtab_file = optarg;
 			break;
-- 
2.7.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_quota: fix missing break after foreign_allowed option

[Eric Sandeen]

On 8/26/16 3:30 AM, Zorro Lang wrote:
> New quota "-f" has been brought in by:
> 
>   29647c8 xfs_quota: add capabilities for use on non-XFS filesystems
> 
> But Coverity Scan find a missing break in quota/init.c: init()
> function.
> 
> Signed-off-by: Zorro Lang <zlang@redhat.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  quota/init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/quota/init.c b/quota/init.c
> index 44be322..2c18c8b 100644
> --- a/quota/init.c
> +++ b/quota/init.c
> @@ -153,6 +153,7 @@ init(
>  			break;
>  		case 'f':
>  			foreign_allowed = true;
> +			break;
>  		case 't':
>  			mtab_file = optarg;
>  			break;
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_quota: fix missing break after foreign_allowed option

[Bill O'Donnell]

On Fri, Aug 26, 2016 at 04:30:06PM +0800, Zorro Lang wrote:
> New quota "-f" has been brought in by:
> 
>   29647c8 xfs_quota: add capabilities for use on non-XFS filesystems
> 
> But Coverity Scan find a missing break in quota/init.c: init()
> function.
> 
> Signed-off-by: Zorro Lang <zlang@redhat.com>

Sorry about that.
Thanks for the patch, Zorro.

Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> ---
>  quota/init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/quota/init.c b/quota/init.c
> index 44be322..2c18c8b 100644
> --- a/quota/init.c
> +++ b/quota/init.c
> @@ -153,6 +153,7 @@ init(
>  			break;
>  		case 'f':
>  			foreign_allowed = true;
> +			break;
>  		case 't':
>  			mtab_file = optarg;
>  			break;
> -- 
> 2.7.4
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs