From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D
Date: Fri, 26 Aug 2016 15:48:08 +0200 [thread overview]
Message-ID: <201608261548.08227.arnd@arndb.de> (raw)
In-Reply-To: <AM3PR04MB13154FA0116D397AABD75E10F5EC0@AM3PR04MB1315.eurprd04.prod.outlook.com>
On Friday 26 August 2016, Yongcai Huang wrote:
> >
> > It's about time iMX folk learned that "imx*" is a SoC and not a CPU.
> > It should be "soc_is_imx7d()" because we're wanting to know whether the
> > SoC is an iMX7D. The CPU is a _Cortex-A7_.
>
> Agree, I will add a new patch in this patch set to replace all the cpu_is_xxx with
> Soc_is_xxx.
I recently did a patch to remove all the cpu_is_mx{1,2,3,5}* macros, which ended up
making the code simpler and more readable in most places. I think we can
do the same for the cpu_is_imx{6,7}* macros.
In this instance, the easy alternative is to have a separate smp_operation
structure for imx7d rather than using the same as imx6 and then figuring
out at runtime which one you have.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Yongcai Huang <anson.huang@nxp.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: Re: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D
Date: Fri, 26 Aug 2016 15:48:08 +0200 [thread overview]
Message-ID: <201608261548.08227.arnd@arndb.de> (raw)
In-Reply-To: <AM3PR04MB13154FA0116D397AABD75E10F5EC0@AM3PR04MB1315.eurprd04.prod.outlook.com>
On Friday 26 August 2016, Yongcai Huang wrote:
> >
> > It's about time iMX folk learned that "imx*" is a SoC and not a CPU.
> > It should be "soc_is_imx7d()" because we're wanting to know whether the
> > SoC is an iMX7D. The CPU is a _Cortex-A7_.
>
> Agree, I will add a new patch in this patch set to replace all the cpu_is_xxx with
> Soc_is_xxx.
I recently did a patch to remove all the cpu_is_mx{1,2,3,5}* macros, which ended up
making the code simpler and more readable in most places. I think we can
do the same for the cpu_is_imx{6,7}* macros.
In this instance, the easy alternative is to have a separate smp_operation
structure for imx7d rather than using the same as imx6 and then figuring
out at runtime which one you have.
Arnd
next prev parent reply other threads:[~2016-08-26 13:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 11:12 [PATCH 0/3] Add SMP support for i.MX7D Anson Huang
2016-08-26 11:12 ` Anson Huang
2016-08-26 11:12 ` Anson Huang
2016-08-26 11:12 ` [PATCH 1/3] ARM: dts: imx7: support SMP boot up Anson Huang
2016-08-26 11:12 ` Anson Huang
2016-08-26 11:12 ` Anson Huang
2016-08-26 11:12 ` [PATCH 2/3] ARM: imx: add gpcv2 support Anson Huang
2016-08-26 11:12 ` Anson Huang
2016-08-26 11:12 ` Anson Huang
2016-08-26 11:17 ` Russell King - ARM Linux
2016-08-26 11:17 ` Russell King - ARM Linux
2016-08-26 11:17 ` Russell King - ARM Linux
2016-08-26 12:25 ` Yongcai Huang
2016-08-26 12:25 ` Yongcai Huang
2016-08-26 12:25 ` Yongcai Huang
2016-08-26 11:12 ` [PATCH 3/3] ARM: imx: add SMP support for i.MX7D Anson Huang
2016-08-26 11:12 ` Anson Huang
2016-08-26 11:12 ` Anson Huang
2016-08-26 8:59 ` Arnd Bergmann
2016-08-26 8:59 ` Arnd Bergmann
2016-08-26 8:59 ` Arnd Bergmann
2016-08-26 10:28 ` Yongcai Huang
2016-08-26 10:28 ` Yongcai Huang
2016-08-26 10:28 ` Yongcai Huang
2016-08-26 11:13 ` Russell King - ARM Linux
2016-08-26 11:13 ` Russell King - ARM Linux
2016-08-26 11:13 ` Russell King - ARM Linux
2016-08-26 12:20 ` Yongcai Huang
2016-08-26 12:20 ` Yongcai Huang
2016-08-26 12:20 ` Yongcai Huang
2016-08-26 12:35 ` Russell King - ARM Linux
2016-08-26 12:35 ` Russell King - ARM Linux
2016-08-26 12:35 ` Russell King - ARM Linux
2016-08-26 13:48 ` Arnd Bergmann [this message]
2016-08-26 13:48 ` Arnd Bergmann
2016-08-26 13:00 ` kbuild test robot
2016-08-26 13:00 ` kbuild test robot
2016-08-26 13:00 ` kbuild test robot
2016-08-26 12:43 ` [PATCH 0/3] Add " Fabio Estevam
2016-08-26 12:43 ` Fabio Estevam
2016-08-26 12:43 ` Fabio Estevam
2016-08-26 13:02 ` Yongcai Huang
2016-08-26 13:02 ` Yongcai Huang
2016-08-26 13:02 ` Yongcai Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201608261548.08227.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.