From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Milo Kim <woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl
Date: Sat, 27 Aug 2016 00:29:32 +0200 [thread overview]
Message-ID: <20160826222932.GI3165@lukather> (raw)
In-Reply-To: <89195613-d5b6-bfc6-1c8c-0d74d9d02a99-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
Hi Milo,
On Fri, Aug 26, 2016 at 05:00:37PM +0900, Milo Kim wrote:
> On 08/26/2016 04:10 PM, Maxime Ripard wrote:
> >>+ uart1_pins_a: uart1@0 {
> >>> + allwinner,pins = "PG6", "PG7";
> >>> + allwinner,function = "uart1";
> >>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> >>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >>> + };
> >>> +
> >Our policy is that we don't introduce new pinctrl nodes that are not
> >used by any board to avoid bloating the DT too much with unused nodes.
> >
> >If you have a board using it, please submit that change as well.
>
> OK, I agree.
>
> However, this pinmux is only useful in case PA5 is assigned for PWM.
> PA5 is commonly used for UART0_RX, so I'd like to add UART1 node into *.dts
> and disable it (status = "disabled"). Does it make sense?
I guess UART1 is either used or not used on that board. In the former
case, it should be enabled, in the latter, left out of the DTS
entirely.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Milo Kim <woogyom.kim@gmail.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl
Date: Sat, 27 Aug 2016 00:29:32 +0200 [thread overview]
Message-ID: <20160826222932.GI3165@lukather> (raw)
In-Reply-To: <89195613-d5b6-bfc6-1c8c-0d74d9d02a99@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
Hi Milo,
On Fri, Aug 26, 2016 at 05:00:37PM +0900, Milo Kim wrote:
> On 08/26/2016 04:10 PM, Maxime Ripard wrote:
> >>+ uart1_pins_a: uart1@0 {
> >>> + allwinner,pins = "PG6", "PG7";
> >>> + allwinner,function = "uart1";
> >>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> >>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >>> + };
> >>> +
> >Our policy is that we don't introduce new pinctrl nodes that are not
> >used by any board to avoid bloating the DT too much with unused nodes.
> >
> >If you have a board using it, please submit that change as well.
>
> OK, I agree.
>
> However, this pinmux is only useful in case PA5 is assigned for PWM.
> PA5 is commonly used for UART0_RX, so I'd like to add UART1 node into *.dts
> and disable it (status = "disabled"). Does it make sense?
I guess UART1 is either used or not used on that board. In the former
case, it should be enabled, in the latter, left out of the DTS
entirely.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-26 22:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 6:44 [PATCH 1/2] pwm: sun4i: Add Allwinner H3 support Milo Kim
2016-08-25 6:44 ` [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Milo Kim
2016-08-26 7:10 ` Maxime Ripard
2016-08-26 8:00 ` Milo Kim
[not found] ` <89195613-d5b6-bfc6-1c8c-0d74d9d02a99-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-26 22:29 ` Maxime Ripard [this message]
2016-08-26 22:29 ` Maxime Ripard
2016-08-31 8:36 ` Milo Kim
2016-08-25 20:51 ` [PATCH 1/2] pwm: sun4i: Add Allwinner H3 support Maxime Ripard
2016-08-26 7:44 ` Milo Kim
2016-08-26 7:44 ` Milo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826222932.GI3165@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
--cc=woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.