All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
	kvm-ppc@vger.kernel.org, lvivier@redhat.com, thuth@redhat.com,
	drjones@redhat.com
Subject: Re: [kvm-unit-tests PATCH V5 5/5] powerpc/tm: Add a test for H_CEDE while tm suspended
Date: Sat, 27 Aug 2016 14:51:38 +0000	[thread overview]
Message-ID: <20160827145137.GC13812@potion> (raw)
In-Reply-To: <1471569014-11063-5-git-send-email-sjitindarsingh@gmail.com>

2016-08-19 11:10+1000, Suraj Jitindar Singh:
> diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg
> @@ -53,3 +53,9 @@ groups = rtas
> +[h_cede_tm]
> +file = tm.elf
> +smp = 2,threads=2
> +extra_params = -append "h_cede_tm"
> +groups = nodefault,h_cede_tm

We have a bug in scripts/mkstandalone.sh that doesn't allow a space as a
separator for groups:  we overwrite args[3], but a space in groups
shifts the position of the args[] we want to overwrite.

It causes no problems now, so I've added it to my after-vacation queue.

WARNING: multiple messages have this Message-ID (diff)
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
	kvm-ppc@vger.kernel.org, lvivier@redhat.com, thuth@redhat.com,
	drjones@redhat.com
Subject: Re: [kvm-unit-tests PATCH V5 5/5] powerpc/tm: Add a test for H_CEDE while tm suspended
Date: Sat, 27 Aug 2016 16:51:38 +0200	[thread overview]
Message-ID: <20160827145137.GC13812@potion> (raw)
In-Reply-To: <1471569014-11063-5-git-send-email-sjitindarsingh@gmail.com>

2016-08-19 11:10+1000, Suraj Jitindar Singh:
> diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg
> @@ -53,3 +53,9 @@ groups = rtas
> +[h_cede_tm]
> +file = tm.elf
> +smp = 2,threads=2
> +extra_params = -append "h_cede_tm"
> +groups = nodefault,h_cede_tm

We have a bug in scripts/mkstandalone.sh that doesn't allow a space as a
separator for groups:  we overwrite args[3], but a space in groups
shifts the position of the args[] we want to overwrite.

It causes no problems now, so I've added it to my after-vacation queue.

  reply	other threads:[~2016-08-27 14:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19  1:10 [kvm-unit-tests PATCH V5 1/5] scripts/runtime: Add ability to mark test as don't run by default Suraj Jitindar Singh
2016-08-19  1:10 ` Suraj Jitindar Singh
2016-08-19  1:10 ` [kvm-unit-tests PATCH V5 2/5] lib/powerpc: Add generic decrementer exception handler Suraj Jitindar Singh
2016-08-19  1:10   ` Suraj Jitindar Singh
2016-08-19  1:10 ` [kvm-unit-tests PATCH V5 3/5] lib/powerpc: Add function to start secondary threads Suraj Jitindar Singh
2016-08-19  1:10   ` Suraj Jitindar Singh
2016-08-19  1:10 ` [kvm-unit-tests PATCH V5 4/5] lib/powerpc: Implement generic delay function for use in unit tests Suraj Jitindar Singh
2016-08-19  1:10   ` Suraj Jitindar Singh
2016-08-19  1:10 ` [kvm-unit-tests PATCH V5 5/5] powerpc/tm: Add a test for H_CEDE while tm suspended Suraj Jitindar Singh
2016-08-19  1:10   ` Suraj Jitindar Singh
2016-08-27 14:51   ` Radim Krčmář [this message]
2016-08-27 14:51     ` Radim Krčmář
2016-08-19  6:40 ` [kvm-unit-tests PATCH V5 1/5] scripts/runtime: Add ability to mark test as don't run by default Andrew Jones
2016-08-19  6:40   ` Andrew Jones
2016-08-22 22:23   ` Thomas Huth
2016-08-22 22:23     ` Thomas Huth
2016-08-27 14:41     ` Radim Krčmář
2016-08-27 14:41       ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160827145137.GC13812@potion \
    --to=rkrcmar@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=sjitindarsingh@gmail.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.