All of lore.kernel.org
 help / color / mirror / Atom feed
From: jolsa@redhat.com (Jiri Olsa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6 1/5] perf tools: making coresight PMU listable
Date: Sun, 28 Aug 2016 16:16:11 +0200	[thread overview]
Message-ID: <20160828141611.GA32293@krava> (raw)
In-Reply-To: <1472156445-24283-2-git-send-email-mathieu.poirier@linaro.org>

On Thu, Aug 25, 2016 at 02:20:41PM -0600, Mathieu Poirier wrote:

SNIP

>  ARM/CORGI MACHINE SUPPORT
>  M:	Richard Purdie <rpurdie@rpsys.net>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 24803c58049a..72edf83d76b7 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -746,10 +746,13 @@ ifdef LIBBABELTRACE
>  endif
>  
>  ifndef NO_AUXTRACE
> -  ifeq ($(feature-get_cpuid), 0)
> -    msg := $(warning Your gcc lacks the __get_cpuid() builtin, disables support for auxtrace/Intel PT, please install a newer gcc);
> -    NO_AUXTRACE := 1
> -  else
> +  ifeq ($(ARCH),x86)
> +    ifeq ($(feature-get_cpuid), 0)
> +      msg := $(warning Your gcc lacks the __get_cpuid() builtin, disables support for auxtrace/Intel PT, please install a newer gcc);
> +      NO_AUXTRACE := 1
> +    endif
> +  endif
> +  ifndef NO_AUXTRACE

hum, how's this hunk connected to the issue described in changelog?

thanks,
jirka

>      $(call detected,CONFIG_AUXTRACE)
>      CFLAGS += -DHAVE_AUXTRACE_SUPPORT
>    endif

SNIP

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V6 1/5] perf tools: making coresight PMU listable
Date: Sun, 28 Aug 2016 16:16:11 +0200	[thread overview]
Message-ID: <20160828141611.GA32293@krava> (raw)
In-Reply-To: <1472156445-24283-2-git-send-email-mathieu.poirier@linaro.org>

On Thu, Aug 25, 2016 at 02:20:41PM -0600, Mathieu Poirier wrote:

SNIP

>  ARM/CORGI MACHINE SUPPORT
>  M:	Richard Purdie <rpurdie@rpsys.net>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 24803c58049a..72edf83d76b7 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -746,10 +746,13 @@ ifdef LIBBABELTRACE
>  endif
>  
>  ifndef NO_AUXTRACE
> -  ifeq ($(feature-get_cpuid), 0)
> -    msg := $(warning Your gcc lacks the __get_cpuid() builtin, disables support for auxtrace/Intel PT, please install a newer gcc);
> -    NO_AUXTRACE := 1
> -  else
> +  ifeq ($(ARCH),x86)
> +    ifeq ($(feature-get_cpuid), 0)
> +      msg := $(warning Your gcc lacks the __get_cpuid() builtin, disables support for auxtrace/Intel PT, please install a newer gcc);
> +      NO_AUXTRACE := 1
> +    endif
> +  endif
> +  ifndef NO_AUXTRACE

hum, how's this hunk connected to the issue described in changelog?

thanks,
jirka

>      $(call detected,CONFIG_AUXTRACE)
>      CFLAGS += -DHAVE_AUXTRACE_SUPPORT
>    endif

SNIP

  reply	other threads:[~2016-08-28 14:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25 20:20 [PATCH V6 0/5] perf: Driver specific configuration for PMU Mathieu Poirier
2016-08-25 20:20 ` Mathieu Poirier
2016-08-25 20:20 ` [PATCH V6 1/5] perf tools: making coresight PMU listable Mathieu Poirier
2016-08-25 20:20   ` Mathieu Poirier
2016-08-28 14:16   ` Jiri Olsa [this message]
2016-08-28 14:16     ` Jiri Olsa
2016-08-29 15:56     ` Mathieu Poirier
2016-08-29 15:56       ` Mathieu Poirier
2016-08-31  6:58       ` Jiri Olsa
2016-08-31  6:58         ` Jiri Olsa
2016-08-25 20:20 ` [PATCH V6 2/5] perf tools: adding coresight etm PMU record capabilities Mathieu Poirier
2016-08-25 20:20   ` Mathieu Poirier
2016-08-25 20:20 ` [PATCH V6 3/5] perf tools: add infrastructure for PMU specific configuration Mathieu Poirier
2016-08-25 20:20   ` Mathieu Poirier
2016-08-25 20:20 ` [PATCH V6 4/5] perf tools: Pushing configuration down to PMU driver Mathieu Poirier
2016-08-25 20:20   ` Mathieu Poirier
2016-08-25 20:20 ` [PATCH V6 5/5] perf tools: adding sink configuration for cs_etm PMU Mathieu Poirier
2016-08-25 20:20   ` Mathieu Poirier
2016-08-28 14:16   ` Jiri Olsa
2016-08-28 14:16     ` Jiri Olsa
2016-08-29 15:57     ` Mathieu Poirier
2016-08-29 15:57       ` Mathieu Poirier
2016-08-28 14:18 ` [PATCH V6 0/5] perf: Driver specific configuration for PMU Jiri Olsa
2016-08-28 14:18   ` Jiri Olsa
2016-08-29 15:58   ` Mathieu Poirier
2016-08-29 15:58     ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160828141611.GA32293@krava \
    --to=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.