From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 3/3] nvme: Enable autonomous power state transitions
Date: Mon, 29 Aug 2016 12:45:40 -0400 [thread overview]
Message-ID: <20160829164540.GE19986@localhost.localdomain> (raw)
In-Reply-To: <88cc7972617eec58a81877d933604e0f0e342e43.1472462539.git.luto@kernel.org>
On Mon, Aug 29, 2016@02:25:46AM -0700, Andy Lutomirski wrote:
> + /*
> + * By default, allow up to 25ms of APST-induced latency. This will
> + * have no effect on non-APST supporting controllers (i.e. any
> + * controller with APSTA == 0).
> + */
> + ctrl->apst_max_latency_ns = 25000000;
Any objection to making this a module parameter? 25ms default sounds
reasonable, but I would still like the option to not ever initialize
APST on a capable device.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] nvme: Enable autonomous power state transitions
Date: Mon, 29 Aug 2016 12:45:40 -0400 [thread overview]
Message-ID: <20160829164540.GE19986@localhost.localdomain> (raw)
In-Reply-To: <88cc7972617eec58a81877d933604e0f0e342e43.1472462539.git.luto@kernel.org>
On Mon, Aug 29, 2016 at 02:25:46AM -0700, Andy Lutomirski wrote:
> + /*
> + * By default, allow up to 25ms of APST-induced latency. This will
> + * have no effect on non-APST supporting controllers (i.e. any
> + * controller with APSTA == 0).
> + */
> + ctrl->apst_max_latency_ns = 25000000;
Any objection to making this a module parameter? 25ms default sounds
reasonable, but I would still like the option to not ever initialize
APST on a capable device.
next prev parent reply other threads:[~2016-08-29 16:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 9:25 [PATCH 0/3] nvme power saving Andy Lutomirski
2016-08-29 9:25 ` Andy Lutomirski
2016-08-29 9:25 ` [PATCH 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-08-29 9:25 ` Andy Lutomirski
2016-08-29 9:25 ` [PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-08-29 9:25 ` Andy Lutomirski
2016-08-29 16:27 ` Keith Busch
2016-08-29 16:27 ` Keith Busch
2016-08-29 23:20 ` Andy Lutomirski
2016-08-29 23:20 ` Andy Lutomirski
2016-08-30 6:36 ` Christoph Hellwig
2016-08-30 6:36 ` Christoph Hellwig
2016-08-30 16:00 ` Andy Lutomirski
2016-08-30 16:00 ` Andy Lutomirski
2016-08-29 9:25 ` [PATCH 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-08-29 9:25 ` Andy Lutomirski
2016-08-29 15:07 ` J Freyensee
2016-08-29 15:07 ` J Freyensee
2016-08-29 23:16 ` Andy Lutomirski
2016-08-29 23:16 ` Andy Lutomirski
2016-08-30 20:21 ` Andy Lutomirski
2016-08-30 20:21 ` Andy Lutomirski
2016-09-02 18:11 ` J Freyensee
2016-09-02 18:11 ` J Freyensee
2016-09-02 18:50 ` Andy Lutomirski
2016-09-02 18:50 ` Andy Lutomirski
2016-08-29 16:45 ` Keith Busch [this message]
2016-08-29 16:45 ` Keith Busch
2016-08-29 23:16 ` Andy Lutomirski
2016-08-29 23:16 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829164540.GE19986@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.