From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Wang, Wei W" <wei.w.wang@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [virtio-comment] [PATCH] *** Vhost-pci RFC v2 ***
Date: Mon, 29 Aug 2016 18:41:59 +0300 [thread overview]
Message-ID: <20160829183717-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <286AC319A985734F985F78AFA26841F7CB5968@shsmsx102.ccr.corp.intel.com>
On Mon, Jun 27, 2016 at 02:01:24AM +0000, Wang, Wei W wrote:
> On Sun 6/19/2016 10:14 PM, Wei Wang wrote:
> > This RFC proposes a design of vhost-pci, which is a new virtio device type.
> > The vhost-pci device is used for inter-VM communication.
> >
> > Changes in v2:
> > 1. changed the vhost-pci driver to use a controlq to send acknowledgement
> > messages to the vhost-pci server rather than writing to the device
> > configuration space;
> >
> > 2. re-organized all the data structures and the description layout;
> >
> > 3. removed the VHOST_PCI_CONTROLQ_UPDATE_DONE socket message, which
> > is redundant;
> >
> > 4. added a message sequence number to the msg info structure to identify
> > socket
> > messages, and the socket message exchange does not need to be blocking;
> >
> > 5. changed to used uuid to identify each VM rather than using the QEMU process
> > id
> >
>
> One more point should be added is that the server needs to send periodic socket messages to check if the driver VM is still alive. I will add this message support in next version. (*v2-AR1*)
Question would be, does it mean guest is alive or QEMU/vhost
thread running is alive? And how do you distinguish a guest that
crashed from guest that is scheduled out?
Hypervisors generally have ways to detect and handle crashed
and stuck guests. It is likely a better idea to have a single
device to detect this than have each device send keep-alive
interrupts, interfering with the guest.
Given this is not a networking
transport, isn't it enough to handle this simply as a guest reset?
you have to handle it anyway.
> > Wei Wang (1):
> > Vhost-pci RFC v2: a new virtio device for inter-VM communication
> >
> > vhost-pci.patch | 341
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 341 insertions(+)
> > create mode 100755 vhost-pci.patch
> >
>
> Hi Michael,
>
> Would you be able to look into the design? Thanks.
>
> Best,
> Wei
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Wang, Wei W" <wei.w.wang@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [virtio-comment] [PATCH] *** Vhost-pci RFC v2 ***
Date: Mon, 29 Aug 2016 18:41:59 +0300 [thread overview]
Message-ID: <20160829183717-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <286AC319A985734F985F78AFA26841F7CB5968@shsmsx102.ccr.corp.intel.com>
On Mon, Jun 27, 2016 at 02:01:24AM +0000, Wang, Wei W wrote:
> On Sun 6/19/2016 10:14 PM, Wei Wang wrote:
> > This RFC proposes a design of vhost-pci, which is a new virtio device type.
> > The vhost-pci device is used for inter-VM communication.
> >
> > Changes in v2:
> > 1. changed the vhost-pci driver to use a controlq to send acknowledgement
> > messages to the vhost-pci server rather than writing to the device
> > configuration space;
> >
> > 2. re-organized all the data structures and the description layout;
> >
> > 3. removed the VHOST_PCI_CONTROLQ_UPDATE_DONE socket message, which
> > is redundant;
> >
> > 4. added a message sequence number to the msg info structure to identify
> > socket
> > messages, and the socket message exchange does not need to be blocking;
> >
> > 5. changed to used uuid to identify each VM rather than using the QEMU process
> > id
> >
>
> One more point should be added is that the server needs to send periodic socket messages to check if the driver VM is still alive. I will add this message support in next version. (*v2-AR1*)
Question would be, does it mean guest is alive or QEMU/vhost
thread running is alive? And how do you distinguish a guest that
crashed from guest that is scheduled out?
Hypervisors generally have ways to detect and handle crashed
and stuck guests. It is likely a better idea to have a single
device to detect this than have each device send keep-alive
interrupts, interfering with the guest.
Given this is not a networking
transport, isn't it enough to handle this simply as a guest reset?
you have to handle it anyway.
> > Wei Wang (1):
> > Vhost-pci RFC v2: a new virtio device for inter-VM communication
> >
> > vhost-pci.patch | 341
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 341 insertions(+)
> > create mode 100755 vhost-pci.patch
> >
>
> Hi Michael,
>
> Would you be able to look into the design? Thanks.
>
> Best,
> Wei
next prev parent reply other threads:[~2016-08-29 15:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 14:14 [PATCH] *** Vhost-pci RFC v2 *** Wei Wang
2016-06-19 14:14 ` [Qemu-devel] " Wei Wang
2016-06-19 14:14 ` [PATCH] Vhost-pci RFC v2: a new virtio device for inter-VM communication Wei Wang
2016-06-19 14:14 ` [Qemu-devel] " Wei Wang
2016-08-29 15:27 ` [virtio-comment] " Stefan Hajnoczi
2016-08-29 15:27 ` [Qemu-devel] " Stefan Hajnoczi
2016-06-27 2:01 ` [virtio-comment] [PATCH] *** Vhost-pci RFC v2 *** Wang, Wei W
2016-06-27 2:01 ` [Qemu-devel] " Wang, Wei W
2016-08-29 15:24 ` Stefan Hajnoczi
2016-08-29 15:24 ` [Qemu-devel] " Stefan Hajnoczi
2016-08-29 15:42 ` Michael S. Tsirkin
2016-08-29 15:42 ` [Qemu-devel] " Michael S. Tsirkin
2016-08-30 10:08 ` Wang, Wei W
2016-08-30 10:08 ` [Qemu-devel] " Wang, Wei W
2016-08-30 11:10 ` Michael S. Tsirkin
2016-08-30 11:10 ` [Qemu-devel] " Michael S. Tsirkin
2016-08-30 12:59 ` Wang, Wei W
2016-08-30 12:59 ` [Qemu-devel] " Wang, Wei W
2016-08-31 16:07 ` Stefan Hajnoczi
2016-09-01 16:27 ` [virtio-comment] " Wei Wang
2016-09-01 16:27 ` Wei Wang
2016-09-02 13:26 ` Stefan Hajnoczi
2016-09-03 13:36 ` Wang, Wei W
2016-09-03 13:36 ` Wang, Wei W
2016-09-05 8:56 ` [virtio-comment] " Marc-André Lureau
2016-09-05 8:56 ` Marc-André Lureau
2016-09-06 17:16 ` Stefan Hajnoczi
2016-09-07 12:27 ` Wang, Wei W
2016-09-07 12:27 ` Wang, Wei W
2016-08-29 15:41 ` Michael S. Tsirkin [this message]
2016-08-29 15:41 ` Michael S. Tsirkin
2016-08-30 10:07 ` Wang, Wei W
2016-08-30 10:07 ` [Qemu-devel] " Wang, Wei W
2016-08-31 12:30 ` [virtio-comment] Re: [Qemu-devel] " Marc-André Lureau
2016-08-31 12:30 ` Marc-André Lureau
2016-09-01 16:26 ` Wei Wang
2016-09-01 8:49 ` Marc-André Lureau
2016-09-01 12:13 ` [Qemu-devel] [virtio-comment] " Wei Wang
2016-09-01 13:05 ` Marc-André Lureau
2016-09-02 1:29 ` Wei Wang
2016-09-02 8:15 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829183717-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.