All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
Date: Mon, 29 Aug 2016 22:38:17 +0200	[thread overview]
Message-ID: <201608292238.17985.arnd@arndb.de> (raw)
In-Reply-To: <VI1PR0401MB2638BCBA99A6305262FD3EE78DE10@VI1PR0401MB2638.eurprd04.prod.outlook.com>

On Monday 29 August 2016, Stuart Yoder wrote:
> > -----Original Message-----
> > From: Arnd Bergmann [mailto:arnd at arndb.de]
> > Sent: Monday, August 29, 2016 6:01 AM
> > To: Stuart Yoder <stuart.yoder@nxp.com>
> > Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; shawnguo at kernel.org
> > Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
> > 
> > On Friday, August 26, 2016 3:46:20 PM CEST Stuart Yoder wrote:
> > > -               serial0 = &lpuart0;
> > > -               serial1 = &lpuart1;
> > > -               serial2 = &lpuart2;
> > > -               serial3 = &lpuart3;
> > > -               serial4 = &lpuart4;
> > > -               serial5 = &lpuart5;
> > > +               serial0 = &duart0;
> > > +               serial1 = &duart1;
> > > +               serial2 = &duart2;
> > > +               serial3 = &duart3;
> > 
> > It looks like your board has six uarts that are all driven with the
> > lpuart driver, but after the change, you only list four. Should
> > the serial4 and serial5 aliases keep pointing at lpuart devices
> > so you can still drive all physical connectors?
> 
> The only existing reference I can find to the serial aliases is if the
> OF_STDOUT_VIA_ALIAS is enabled in u-boot to specify the console.  The
> standard ls1043aqds_defconfig in u-boot specifies DUARTs for the console,
> which is why I'm proposing making the 4 DUARTs the default serial aliases
> in the device tree.

Ok, so they are mutually exclusive, and the last two ports are
unavailable in the default configuration?
 
> There is a separate defconfig in u-boot to enable/use LPUARTs instead
> of the normal DUARTs.  For that scenario, my take is that firmware should
> update the DT aliases to reflect the actual use of the serial ports.

Yes, makes sense.

> But, the default should be the DUARTs which is the normal case for this
> board, which is why this patch is changing them.

Ok

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	Stuart Yoder <stuart.yoder@nxp.com>
Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
Date: Mon, 29 Aug 2016 22:38:17 +0200	[thread overview]
Message-ID: <201608292238.17985.arnd@arndb.de> (raw)
In-Reply-To: <VI1PR0401MB2638BCBA99A6305262FD3EE78DE10@VI1PR0401MB2638.eurprd04.prod.outlook.com>

On Monday 29 August 2016, Stuart Yoder wrote:
> > -----Original Message-----
> > From: Arnd Bergmann [mailto:arnd@arndb.de]
> > Sent: Monday, August 29, 2016 6:01 AM
> > To: Stuart Yoder <stuart.yoder@nxp.com>
> > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; shawnguo@kernel.org
> > Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
> > 
> > On Friday, August 26, 2016 3:46:20 PM CEST Stuart Yoder wrote:
> > > -               serial0 = &lpuart0;
> > > -               serial1 = &lpuart1;
> > > -               serial2 = &lpuart2;
> > > -               serial3 = &lpuart3;
> > > -               serial4 = &lpuart4;
> > > -               serial5 = &lpuart5;
> > > +               serial0 = &duart0;
> > > +               serial1 = &duart1;
> > > +               serial2 = &duart2;
> > > +               serial3 = &duart3;
> > 
> > It looks like your board has six uarts that are all driven with the
> > lpuart driver, but after the change, you only list four. Should
> > the serial4 and serial5 aliases keep pointing at lpuart devices
> > so you can still drive all physical connectors?
> 
> The only existing reference I can find to the serial aliases is if the
> OF_STDOUT_VIA_ALIAS is enabled in u-boot to specify the console.  The
> standard ls1043aqds_defconfig in u-boot specifies DUARTs for the console,
> which is why I'm proposing making the 4 DUARTs the default serial aliases
> in the device tree.

Ok, so they are mutually exclusive, and the last two ports are
unavailable in the default configuration?
 
> There is a separate defconfig in u-boot to enable/use LPUARTs instead
> of the normal DUARTs.  For that scenario, my take is that firmware should
> update the DT aliases to reflect the actual use of the serial ports.

Yes, makes sense.

> But, the default should be the DUARTs which is the normal case for this
> board, which is why this patch is changing them.

Ok

	Arnd

  reply	other threads:[~2016-08-29 20:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 20:46 [PATCH 0/2] arm64: dts: ls1043a/ls2080a serial updates Stuart Yoder
2016-08-26 20:46 ` Stuart Yoder
2016-08-26 20:46 ` [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards Stuart Yoder
2016-08-26 20:46   ` Stuart Yoder
2016-08-29 11:01   ` Arnd Bergmann
2016-08-29 11:01     ` Arnd Bergmann
2016-08-29 18:30     ` Stuart Yoder
2016-08-29 18:30       ` Stuart Yoder
2016-08-29 20:38       ` Arnd Bergmann [this message]
2016-08-29 20:38         ` Arnd Bergmann
2016-08-29 21:10         ` Stuart Yoder
2016-08-29 21:10           ` Stuart Yoder
2016-08-29 14:01   ` Shawn Guo
2016-08-29 14:01     ` Shawn Guo
2016-08-26 20:46 ` [PATCH 2/2] arm64: dts: add stdout-path to chosen node for ls2080a/ls1043a boards Stuart Yoder
2016-08-26 20:46   ` Stuart Yoder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201608292238.17985.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.