From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] drivers/perf: arm_pmu: Fix NULL pointer dereference during probe
Date: Tue, 30 Aug 2016 12:27:19 +0100 [thread overview]
Message-ID: <20160830112718.GC24906@arm.com> (raw)
In-Reply-To: <1472314790-4268-2-git-send-email-stefan.wahren@i2se.com>
On Sat, Aug 27, 2016 at 04:19:50PM +0000, Stefan Wahren wrote:
> Patch 7f1d642fbb5c ("drivers/perf: arm-pmu: Fix handling of SPI lacking
> interrupt-affinity property") unintended also fixes perf_event support
> for bcm2835 which doesn't have PMU interrupts. Unfortunately this change
> introduce a NULL pointer dereference on bcm2835, because irq_is_percpu
> always expected to be called with a valid IRQ. So fix this regression
> by validating the IRQ before.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 7f1d642fbb5c ("drivers/perf: arm-pmu: Fix handling of SPI lacking \"interrupt-affinity\" property")
> ---
> drivers/perf/arm_pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, these two look good to me. I'll queue them up as fixes and hopefully
they'll land in -rc5.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Eric Anholt <eric@anholt.net>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, marc.zyngier@arm.com
Subject: Re: [PATCH 2/2] drivers/perf: arm_pmu: Fix NULL pointer dereference during probe
Date: Tue, 30 Aug 2016 12:27:19 +0100 [thread overview]
Message-ID: <20160830112718.GC24906@arm.com> (raw)
In-Reply-To: <1472314790-4268-2-git-send-email-stefan.wahren@i2se.com>
On Sat, Aug 27, 2016 at 04:19:50PM +0000, Stefan Wahren wrote:
> Patch 7f1d642fbb5c ("drivers/perf: arm-pmu: Fix handling of SPI lacking
> interrupt-affinity property") unintended also fixes perf_event support
> for bcm2835 which doesn't have PMU interrupts. Unfortunately this change
> introduce a NULL pointer dereference on bcm2835, because irq_is_percpu
> always expected to be called with a valid IRQ. So fix this regression
> by validating the IRQ before.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 7f1d642fbb5c ("drivers/perf: arm-pmu: Fix handling of SPI lacking \"interrupt-affinity\" property")
> ---
> drivers/perf/arm_pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, these two look good to me. I'll queue them up as fixes and hopefully
they'll land in -rc5.
Will
next prev parent reply other threads:[~2016-08-30 11:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 16:19 [PATCH 1/2] drivers/perf: arm_pmu: Fix leak in error path Stefan Wahren
2016-08-27 16:19 ` Stefan Wahren
2016-08-27 16:19 ` [PATCH 2/2] drivers/perf: arm_pmu: Fix NULL pointer dereference during probe Stefan Wahren
2016-08-27 16:19 ` Stefan Wahren
2016-08-30 11:27 ` Will Deacon [this message]
2016-08-30 11:27 ` Will Deacon
2016-09-01 2:17 ` Kevin Hilman
2016-09-01 2:17 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830112718.GC24906@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.