From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@poochiereds.net>
Cc: Tejun Heo <tj@kernel.org>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue
Date: Wed, 31 Aug 2016 02:23:48 +0530 [thread overview]
Message-ID: <20160830205348.GA31915@Karyakshetra> (raw)
The workqueue "callback_wq" queues a single work item &cb->cb_work per
nfsd4_callback instance and thus, it doesn't require execution ordering.
Hence, alloc_workqueue has been used to replace the
deprecated create_singlethread_workqueue instance.
The WQ_MEM_RECLAIM flag has not been set since this is an in-kernel nfs
server and isn't involved in memory reclaim operations on the local
host.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
Changes in v2:
- No change. Made this a separate patch (categorised based on
directories).
fs/nfsd/nfs4callback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 7389cb1..a6611c6 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1021,7 +1021,7 @@ static const struct rpc_call_ops nfsd4_cb_ops = {
int nfsd4_create_callback_queue(void)
{
- callback_wq = create_singlethread_workqueue("nfsd4_callbacks");
+ callback_wq = alloc_workqueue("nfsd4_callbacks", 0, 0);
if (!callback_wq)
return -ENOMEM;
return 0;
--
2.1.4
next reply other threads:[~2016-08-30 20:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 20:53 Bhaktipriya Shridhar [this message]
2016-08-30 21:07 ` [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue Jeff Layton
2016-08-31 14:39 ` Tejun Heo
2016-08-31 15:01 ` Jeff Layton
2016-11-08 21:39 ` J. Bruce Fields
2016-11-08 22:52 ` Tejun Heo
2016-11-09 1:27 ` J. Bruce Fields
2016-11-09 13:18 ` Jeff Layton
2016-11-09 15:08 ` Trond Myklebust
2016-11-09 15:08 ` Trond Myklebust
2016-11-09 15:17 ` Jeff Layton
2016-11-09 16:27 ` J. Bruce Fields
2016-11-09 17:33 ` Jeff Layton
2016-11-09 19:47 ` J. Bruce Fields
2016-11-09 20:23 ` J. Bruce Fields
2016-11-09 22:35 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830205348.GA31915@Karyakshetra \
--to=bhaktipriya96@gmail.com \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.