From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tejun Heo <tj@kernel.org>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
Jeff Layton <jlayton@poochiereds.net>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue
Date: Tue, 8 Nov 2016 20:27:25 -0500 [thread overview]
Message-ID: <20161109012725.GA29930@fieldses.org> (raw)
In-Reply-To: <20161108225221.GB6460@htj.duckdns.org>
On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote:
> Hello, Bruce.
>
> On Tue, Nov 08, 2016 at 04:39:11PM -0500, J. Bruce Fields wrote:
> > Apologies, just cleaning out old mail and finding some I should have
> > responded to long ago:
> >
> > On Wed, Aug 31, 2016 at 02:23:48AM +0530, Bhaktipriya Shridhar wrote:
> > > The workqueue "callback_wq" queues a single work item &cb->cb_work per
> > > nfsd4_callback instance and thus, it doesn't require execution ordering.
> >
> > What's "execution ordering"?
> >
> > We definitely do depend on the fact that at most one of these is running
> > at a time.
>
> If there can be multiple cb's and thus cb->cb_work's per callback_wq,
> it'd need explicit ordering. Is that the case?
Yes, there can be multiple cb_work's.
--b.
next prev parent reply other threads:[~2016-11-09 1:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 20:53 [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-08-30 21:07 ` Jeff Layton
2016-08-31 14:39 ` Tejun Heo
2016-08-31 15:01 ` Jeff Layton
2016-11-08 21:39 ` J. Bruce Fields
2016-11-08 22:52 ` Tejun Heo
2016-11-09 1:27 ` J. Bruce Fields [this message]
2016-11-09 13:18 ` Jeff Layton
2016-11-09 15:08 ` Trond Myklebust
2016-11-09 15:08 ` Trond Myklebust
2016-11-09 15:17 ` Jeff Layton
2016-11-09 16:27 ` J. Bruce Fields
2016-11-09 17:33 ` Jeff Layton
2016-11-09 19:47 ` J. Bruce Fields
2016-11-09 20:23 ` J. Bruce Fields
2016-11-09 22:35 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109012725.GA29930@fieldses.org \
--to=bfields@fieldses.org \
--cc=bhaktipriya96@gmail.com \
--cc=jlayton@poochiereds.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.