From: Stephen Boyd <sboyd@codeaurora.org>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>
Subject: Re: [PATCH RESEND] clk: core: Force setting the phase delay when no change
Date: Tue, 30 Aug 2016 14:51:53 -0700 [thread overview]
Message-ID: <20160830215153.GE12510@codeaurora.org> (raw)
In-Reply-To: <20160824092212.D088561C49@smtp.codeaurora.org>
On 08/24, Jean-Francois Moine wrote:
> This patch reverts the commit 023bd7166be0595d18220dfd5c9765b3970f6ef3
> (clk: skip unnecessary set_phase if nothing to do), fixing two
> problems:
> - in some SoCs, the hardware phase delay depends on the rate ratio of
> the clock and its parent. So, changing this ratio may imply to set
> new hardware values, even if the logical delay is the same.
> - when the delay was the same as previously, an error was returned.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
Applied to clk-next. We can revisit optimizing things later like
the original patch attempted, but fixing the second problem is
enough to warrant a revert for now.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] clk: core: Force setting the phase delay when no change
Date: Tue, 30 Aug 2016 14:51:53 -0700 [thread overview]
Message-ID: <20160830215153.GE12510@codeaurora.org> (raw)
In-Reply-To: <20160824092212.D088561C49@smtp.codeaurora.org>
On 08/24, Jean-Francois Moine wrote:
> This patch reverts the commit 023bd7166be0595d18220dfd5c9765b3970f6ef3
> (clk: skip unnecessary set_phase if nothing to do), fixing two
> problems:
> - in some SoCs, the hardware phase delay depends on the rate ratio of
> the clock and its parent. So, changing this ratio may imply to set
> new hardware values, even if the logical delay is the same.
> - when the delay was the same as previously, an error was returned.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
Applied to clk-next. We can revisit optimizing things later like
the original patch attempted, but fixing the second problem is
enough to warrant a revert for now.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next parent reply other threads:[~2016-08-30 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160824092212.D088561C49@smtp.codeaurora.org>
2016-08-30 21:51 ` Stephen Boyd [this message]
2016-08-30 21:51 ` [PATCH RESEND] clk: core: Force setting the phase delay when no change Stephen Boyd
2016-08-24 6:32 Jean-Francois Moine
-- strict thread matches above, loose matches on Subject: below --
2016-08-24 6:32 Jean-Francois Moine
2016-08-24 6:32 Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830215153.GE12510@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=mturquette@baylibre.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.