From: jolsa@redhat.com (Jiri Olsa)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] perf tools: Fix static building
Date: Wed, 31 Aug 2016 09:24:09 +0200 [thread overview]
Message-ID: <20160831072409.GC4740@krava> (raw)
In-Reply-To: <1471887222-26270-1-git-send-email-abrodkin@synopsys.com>
On Mon, Aug 22, 2016@08:33:42PM +0300, Alexey Brodkin wrote:
> With commit e3d09ec8126f ("tools lib traceevent: Export dynamic symbols
> used by traceevent plugins") we started to add "--dynamic-list" in
> LDFLAGS. One side-effect of that was inability to build really
> statically-linked perf.
>
> I.e. even if "LDFLAGS=-static" were passed on perf building command-line
> it had no effect and perf was built dynamically.
>
> This change disables setup of "--dynamic-list" if LDFLAGS contains
> "-static" option.
>
> Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Arnaldo Carvalho de Melo <acme at redhat.com>
> Cc: Vineet Gupta <vgupta at synopsys.com>
> Cc: Wang Nan <wangnan0 at huawei.com>
> Cc: Jiri Olsa <jolsa at kernel.org>
> Cc: He Kuang <hekuang at huawei.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt at hitachi.com>
> Cc: Namhyung Kim <namhyung at kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra at chello.nl>
> Cc: Zefan Li <lizefan at huawei.com>
> Cc: pi3orama at 163.com
> ---
> tools/perf/Makefile.perf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 2d908750..e9acc7c 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -236,7 +236,9 @@ LIBTRACEEVENT = $(TE_PATH)libtraceevent.a
> export LIBTRACEEVENT
>
> LIBTRACEEVENT_DYNAMIC_LIST = $(TE_PATH)libtraceevent-dynamic-list
> +ifeq ($(filter -static,$(LDFLAGS)),)
> LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS = -Xlinker --dynamic-list=$(LIBTRACEEVENT_DYNAMIC_LIST)
> +endif
hum, e3d09ec8126f changelog mentioned python feature adding this by default
but not sure python could be added within static build
jirka
>
> LIBAPI = $(API_PATH)libapi.a
> export LIBAPI
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
He Kuang <hekuang@huawei.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Zefan Li <lizefan@huawei.com>,
pi3orama@163.com
Subject: Re: [PATCH] perf tools: Fix static building
Date: Wed, 31 Aug 2016 09:24:09 +0200 [thread overview]
Message-ID: <20160831072409.GC4740@krava> (raw)
In-Reply-To: <1471887222-26270-1-git-send-email-abrodkin@synopsys.com>
On Mon, Aug 22, 2016 at 08:33:42PM +0300, Alexey Brodkin wrote:
> With commit e3d09ec8126f ("tools lib traceevent: Export dynamic symbols
> used by traceevent plugins") we started to add "--dynamic-list" in
> LDFLAGS. One side-effect of that was inability to build really
> statically-linked perf.
>
> I.e. even if "LDFLAGS=-static" were passed on perf building command-line
> it had no effect and perf was built dynamically.
>
> This change disables setup of "--dynamic-list" if LDFLAGS contains
> "-static" option.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> Cc: Wang Nan <wangnan0@huawei.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: He Kuang <hekuang@huawei.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Zefan Li <lizefan@huawei.com>
> Cc: pi3orama@163.com
> ---
> tools/perf/Makefile.perf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 2d908750..e9acc7c 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -236,7 +236,9 @@ LIBTRACEEVENT = $(TE_PATH)libtraceevent.a
> export LIBTRACEEVENT
>
> LIBTRACEEVENT_DYNAMIC_LIST = $(TE_PATH)libtraceevent-dynamic-list
> +ifeq ($(filter -static,$(LDFLAGS)),)
> LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS = -Xlinker --dynamic-list=$(LIBTRACEEVENT_DYNAMIC_LIST)
> +endif
hum, e3d09ec8126f changelog mentioned python feature adding this by default
but not sure python could be added within static build
jirka
>
> LIBAPI = $(API_PATH)libapi.a
> export LIBAPI
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-08-31 7:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 17:33 [PATCH] perf tools: Fix static building Alexey Brodkin
2016-08-22 17:33 ` Alexey Brodkin
2016-08-30 16:21 ` Vineet Gupta
2016-08-30 16:21 ` Vineet Gupta
2016-08-31 7:21 ` Jiri Olsa
2016-08-31 7:21 ` Jiri Olsa
2016-09-01 18:28 ` Vineet Gupta
2016-09-01 18:28 ` Vineet Gupta
2016-09-14 16:21 ` Alexey Brodkin
2016-09-14 16:21 ` Alexey Brodkin
2016-08-31 7:24 ` Jiri Olsa [this message]
2016-08-31 7:24 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831072409.GC4740@krava \
--to=jolsa@redhat.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.