From: xdrudis@tinet.cat (Xavi Drudis Ferran)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6qdl: Fix SPDIF regression
Date: Wed, 31 Aug 2016 16:10:44 +0200 [thread overview]
Message-ID: <20160831141044.GC1967@begut> (raw)
In-Reply-To: <1472651808-28034-1-git-send-email-fabio.estevam@nxp.com>
El Wed, Aug 31, 2016 at 10:56:48AM -0300, Fabio Estevam deia:
> Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> changed many more clocks than only the SPDIF core clock as stated in
> the commit message.
>
> The MLB clock has been added and this causes SPDIF regression as
> reported by Xavi Drudis Ferran and also in this forum post:
> https://forum.digikey.com/thread/34240
>
> The MX6Q Reference Manual does not mention that MLB is a clock related
> to SPDIF, so change it back to a dummy clock to restore SPDIF
> functionality.
>
> Thanks to Ambika for providing the fix at:
> https://community.nxp.com/thread/387131
>
> Fixes: 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> Cc: <stable@vger.kernel.org> # 4.4.x
> Reported-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index b620ac8..b13b0b2 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -243,7 +243,7 @@
> clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>,
> <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>,
> <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>,
> - <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>,
> + <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_DUMMY>,
> <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>;
> clock-names = "core", "rxtx0",
> "rxtx1", "rxtx2",
> --
> 1.9.1
>
Tested-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
(on linux-libre-4.7, wandboard-quad-rev-b1, imx6q MCIMX6Q5EYM10AC ,according to wandboard manual BOM)
Before the change I didn't hear output on spdif, after the change output sounds ok.
WARNING: multiple messages have this Message-ID (diff)
From: Xavi Drudis Ferran <xdrudis@tinet.cat>
To: Fabio Estevam <fabio.estevam@nxp.com>
Cc: shawnguo@kernel.org, xdrudis@tinet.cat, nicoleotsuka@gmail.com,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6qdl: Fix SPDIF regression
Date: Wed, 31 Aug 2016 16:10:44 +0200 [thread overview]
Message-ID: <20160831141044.GC1967@begut> (raw)
In-Reply-To: <1472651808-28034-1-git-send-email-fabio.estevam@nxp.com>
El Wed, Aug 31, 2016 at 10:56:48AM -0300, Fabio Estevam deia:
> Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> changed many more clocks than only the SPDIF core clock as stated in
> the commit message.
>
> The MLB clock has been added and this causes SPDIF regression as
> reported by Xavi Drudis Ferran and also in this forum post:
> https://forum.digikey.com/thread/34240
>
> The MX6Q Reference Manual does not mention that MLB is a clock related
> to SPDIF, so change it back to a dummy clock to restore SPDIF
> functionality.
>
> Thanks to Ambika for providing the fix at:
> https://community.nxp.com/thread/387131
>
> Fixes: 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> Cc: <stable@vger.kernel.org> # 4.4.x
> Reported-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index b620ac8..b13b0b2 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -243,7 +243,7 @@
> clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>,
> <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>,
> <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>,
> - <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>,
> + <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_DUMMY>,
> <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>;
> clock-names = "core", "rxtx0",
> "rxtx1", "rxtx2",
> --
> 1.9.1
>
Tested-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
(on linux-libre-4.7, wandboard-quad-rev-b1, imx6q MCIMX6Q5EYM10AC ,according to wandboard manual BOM)
Before the change I didn't hear output on spdif, after the change output sounds ok.
next prev parent reply other threads:[~2016-08-31 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 13:56 [PATCH] ARM: dts: imx6qdl: Fix SPDIF regression Fabio Estevam
2016-08-31 13:56 ` Fabio Estevam
2016-08-31 14:10 ` Xavi Drudis Ferran [this message]
2016-08-31 14:10 ` Xavi Drudis Ferran
2016-09-05 2:31 ` Shawn Guo
2016-09-05 2:31 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831141044.GC1967@begut \
--to=xdrudis@tinet.cat \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.