From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
cov@codeaurora.org, jcm@redhat.com, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4 0/3] dmaengine: qcom_hidma: add error reporting
Date: Wed, 31 Aug 2016 21:28:07 +0530 [thread overview]
Message-ID: <20160831155807.GZ9355@localhost> (raw)
In-Reply-To: <1472656229-12955-1-git-send-email-okaya@codeaurora.org>
On Wed, Aug 31, 2016 at 11:10:26AM -0400, Sinan Kaya wrote:
> Three changes in the error handling area:
>
> 1. There is a race condition between data transfer callback and descriptor
> free code. The callback routine may decide to clear the resources even
> though the descriptor has not yet been freed.
>
> 2. DMA Engine framework now supports direct error reporting to the client
> via the callback.
>
> Pass the DMA errors to the client by passing a result argument. The HW
> only supports a generic error when something goes wrong. That's why,
> using DMA_TRANS_ABORTED all the time.
>
> 3. The HIDMA driver is capable of error detection. However, the error was
> not being passed back to the client when tx_status API is called.
Applied all, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 0/3] dmaengine: qcom_hidma: add error reporting
Date: Wed, 31 Aug 2016 21:28:07 +0530 [thread overview]
Message-ID: <20160831155807.GZ9355@localhost> (raw)
In-Reply-To: <1472656229-12955-1-git-send-email-okaya@codeaurora.org>
On Wed, Aug 31, 2016 at 11:10:26AM -0400, Sinan Kaya wrote:
> Three changes in the error handling area:
>
> 1. There is a race condition between data transfer callback and descriptor
> free code. The callback routine may decide to clear the resources even
> though the descriptor has not yet been freed.
>
> 2. DMA Engine framework now supports direct error reporting to the client
> via the callback.
>
> Pass the DMA errors to the client by passing a result argument. The HW
> only supports a generic error when something goes wrong. That's why,
> using DMA_TRANS_ABORTED all the time.
>
> 3. The HIDMA driver is capable of error detection. However, the error was
> not being passed back to the client when tx_status API is called.
Applied all, thanks
--
~Vinod
next prev parent reply other threads:[~2016-08-31 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 15:10 [PATCH V4 0/3] dmaengine: qcom_hidma: add error reporting Sinan Kaya
2016-08-31 15:10 ` Sinan Kaya
2016-08-31 15:10 ` [PATCH V4 1/3] dmaengine: qcom_hidma: release the descriptor before the callback Sinan Kaya
2016-08-31 15:10 ` Sinan Kaya
2016-08-31 15:10 ` [PATCH V4 2/3] dmaengine: qcom_hidma: report transfer errors with new interface Sinan Kaya
2016-08-31 15:10 ` Sinan Kaya
2016-08-31 15:10 ` [PATCH V4 3/3] dmaengine: qcom_hidma: add error reporting for tx_status Sinan Kaya
2016-08-31 15:10 ` Sinan Kaya
2016-08-31 15:58 ` Vinod Koul [this message]
2016-08-31 15:58 ` [PATCH V4 0/3] dmaengine: qcom_hidma: add error reporting Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831155807.GZ9355@localhost \
--to=vinod.koul@intel.com \
--cc=agross@codeaurora.org \
--cc=cov@codeaurora.org \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.