From: Mark Brown <broonie@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: alsa-devel@alsa-project.org, Heiko Stuebner <heiko@sntech.de>,
Xing Zheng <zhengxing@rock-chips.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: rockchip: use SPI dependency for rt5514
Date: Thu, 1 Sep 2016 21:00:57 +0100 [thread overview]
Message-ID: <20160901200057.GO5967@sirena.org.uk> (raw)
In-Reply-To: <20160826155120.1162512-1-arnd@arndb.de>
[-- Attachment #1.1: Type: text/plain, Size: 398 bytes --]
On Fri, Aug 26, 2016 at 05:50:55PM +0200, Arnd Bergmann wrote:
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c6eac8a36a84 ("ASoC: rockchip: Add machine driver for RK3399 GRU Boards")
The Fixes is usually sorted before everything else, looks a bit odd like
that especially as more signoffs get added. It's also a bit redundant
to use both () and "" not that it makes a huge difference.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: rockchip: use SPI dependency for rt5514
Date: Thu, 1 Sep 2016 21:00:57 +0100 [thread overview]
Message-ID: <20160901200057.GO5967@sirena.org.uk> (raw)
In-Reply-To: <20160826155120.1162512-1-arnd@arndb.de>
On Fri, Aug 26, 2016 at 05:50:55PM +0200, Arnd Bergmann wrote:
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c6eac8a36a84 ("ASoC: rockchip: Add machine driver for RK3399 GRU Boards")
The Fixes is usually sorted before everything else, looks a bit odd like
that especially as more signoffs get added. It's also a bit redundant
to use both () and "" not that it makes a huge difference.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160901/5571be04/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Xing Zheng <zhengxing@rock-chips.com>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: rockchip: use SPI dependency for rt5514
Date: Thu, 1 Sep 2016 21:00:57 +0100 [thread overview]
Message-ID: <20160901200057.GO5967@sirena.org.uk> (raw)
In-Reply-To: <20160826155120.1162512-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
On Fri, Aug 26, 2016 at 05:50:55PM +0200, Arnd Bergmann wrote:
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c6eac8a36a84 ("ASoC: rockchip: Add machine driver for RK3399 GRU Boards")
The Fixes is usually sorted before everything else, looks a bit odd like
that especially as more signoffs get added. It's also a bit redundant
to use both () and "" not that it makes a huge difference.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-09-01 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 15:50 [PATCH] ASoC: rockchip: use SPI dependency for rt5514 Arnd Bergmann
2016-08-26 15:50 ` Arnd Bergmann
2016-08-26 15:50 ` Arnd Bergmann
2016-08-27 13:45 ` Xing Zheng
2016-08-27 13:45 ` Xing Zheng
2016-09-01 20:00 ` Mark Brown [this message]
2016-09-01 20:00 ` Mark Brown
2016-09-01 20:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901200057.GO5967@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sjoerd.simons@collabora.co.uk \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.