* [PATCH] libxl: fix libxl_device_usbdev_list()
@ 2016-09-02 8:16 Juergen Gross
2016-09-02 8:32 ` Wei Liu
2016-09-02 10:53 ` Ian Jackson
0 siblings, 2 replies; 5+ messages in thread
From: Juergen Gross @ 2016-09-02 8:16 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, wei.liu2, ian.jackson
Commit 03814de1d2ecdabedabceb8e728d934a632a43b9 ("libxl: Do not trust
frontend for vusb") introduced an error in libxl_device_usbdev_list().
Fix it.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
Backport candidate for 4.7
---
tools/libxl/libxl_pvusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c
index 88e9ed4..75f7b8b 100644
--- a/tools/libxl/libxl_pvusb.c
+++ b/tools/libxl/libxl_pvusb.c
@@ -736,7 +736,7 @@ libxl_device_usbdev_list(libxl_ctx *ctx, uint32_t domid, int *num)
*num = 0;
libxl_vusbs_path = GCSPRINTF("%s/device/vusb",
- libxl__xs_libxl_path(gc, !domid));
+ libxl__xs_libxl_path(gc, domid));
usbctrls = libxl__xs_directory(gc, XBT_NULL, libxl_vusbs_path, &nc);
for (i = 0; i < nc; i++) {
--
2.6.6
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: fix libxl_device_usbdev_list()
2016-09-02 8:16 [PATCH] libxl: fix libxl_device_usbdev_list() Juergen Gross
@ 2016-09-02 8:32 ` Wei Liu
2016-09-02 8:57 ` Wei Liu
2016-09-02 10:53 ` Ian Jackson
1 sibling, 1 reply; 5+ messages in thread
From: Wei Liu @ 2016-09-02 8:32 UTC (permalink / raw)
To: Juergen Gross; +Cc: wei.liu2, ian.jackson, xen-devel
On Fri, Sep 02, 2016 at 10:16:14AM +0200, Juergen Gross wrote:
> Commit 03814de1d2ecdabedabceb8e728d934a632a43b9 ("libxl: Do not trust
> frontend for vusb") introduced an error in libxl_device_usbdev_list().
> Fix it.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Backport candidate for 4.7
> ---
> tools/libxl/libxl_pvusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c
> index 88e9ed4..75f7b8b 100644
> --- a/tools/libxl/libxl_pvusb.c
> +++ b/tools/libxl/libxl_pvusb.c
> @@ -736,7 +736,7 @@ libxl_device_usbdev_list(libxl_ctx *ctx, uint32_t domid, int *num)
> *num = 0;
>
> libxl_vusbs_path = GCSPRINTF("%s/device/vusb",
> - libxl__xs_libxl_path(gc, !domid));
> + libxl__xs_libxl_path(gc, domid));
> usbctrls = libxl__xs_directory(gc, XBT_NULL, libxl_vusbs_path, &nc);
>
> for (i = 0; i < nc; i++) {
> --
> 2.6.6
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: fix libxl_device_usbdev_list()
2016-09-02 8:32 ` Wei Liu
@ 2016-09-02 8:57 ` Wei Liu
2016-09-02 10:54 ` Ian Jackson
0 siblings, 1 reply; 5+ messages in thread
From: Wei Liu @ 2016-09-02 8:57 UTC (permalink / raw)
To: Juergen Gross; +Cc: wei.liu2, ian.jackson, xen-devel
On Fri, Sep 02, 2016 at 09:32:03AM +0100, Wei Liu wrote:
> On Fri, Sep 02, 2016 at 10:16:14AM +0200, Juergen Gross wrote:
> > Commit 03814de1d2ecdabedabceb8e728d934a632a43b9 ("libxl: Do not trust
> > frontend for vusb") introduced an error in libxl_device_usbdev_list().
> > Fix it.
> >
> > Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> > ---
> > Backport candidate for 4.7
Pushed. Backport to 4.7 is required.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: fix libxl_device_usbdev_list()
2016-09-02 8:16 [PATCH] libxl: fix libxl_device_usbdev_list() Juergen Gross
2016-09-02 8:32 ` Wei Liu
@ 2016-09-02 10:53 ` Ian Jackson
1 sibling, 0 replies; 5+ messages in thread
From: Ian Jackson @ 2016-09-02 10:53 UTC (permalink / raw)
To: Juergen Gross; +Cc: wei.liu2, xen-devel
Juergen Gross writes ("[PATCH] libxl: fix libxl_device_usbdev_list()"):
> Commit 03814de1d2ecdabedabceb8e728d934a632a43b9 ("libxl: Do not trust
> frontend for vusb") introduced an error in libxl_device_usbdev_list().
> Fix it.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Oops, sorry!
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Backport candidate for 4.7
Agreed.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: fix libxl_device_usbdev_list()
2016-09-02 8:57 ` Wei Liu
@ 2016-09-02 10:54 ` Ian Jackson
0 siblings, 0 replies; 5+ messages in thread
From: Ian Jackson @ 2016-09-02 10:54 UTC (permalink / raw)
To: Wei Liu; +Cc: Juergen Gross, xen-devel
Wei Liu writes ("Re: [PATCH] libxl: fix libxl_device_usbdev_list()"):
> Pushed. Backport to 4.7 is required.
Queued, thanks.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-02 10:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-02 8:16 [PATCH] libxl: fix libxl_device_usbdev_list() Juergen Gross
2016-09-02 8:32 ` Wei Liu
2016-09-02 8:57 ` Wei Liu
2016-09-02 10:54 ` Ian Jackson
2016-09-02 10:53 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.