From: Quentin Lambert <lambert.quentin@gmail.com>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Salvatore Benedetto <salvatore.benedetto@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
qat-linux@intel.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org,
Quentin Lambert <lambert.quentin@gmail.com>
Subject: [PATCH 2/2] crypto: qat - fix resource release omissions
Date: Fri, 02 Sep 2016 14:37:59 +0000 [thread overview]
Message-ID: <20160902143759.31125-3-lambert.quentin@gmail.com> (raw)
In-Reply-To: <20160902143759.31125-1-lambert.quentin@gmail.com>
This issue was found with Hector.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/crypto/qat/qat_common/qat_uclo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/crypto/qat/qat_common/qat_uclo.c
+++ b/drivers/crypto/qat/qat_common/qat_uclo.c
@@ -981,7 +981,8 @@ static int qat_uclo_parse_uof_obj(struct
(PID_MINOR_REV & handle->hal_handle->revision_id);
if (qat_uclo_check_uof_compat(obj_handle)) {
pr_err("QAT: UOF incompatible\n");
- return -EINVAL;
+ ret = -EINVAL;
+ goto out_err;
}
obj_handle->ustore_phy_size = ICP_QAT_UCLO_MAX_USTORE;
if (!obj_handle->obj_hdr->file_buff ||
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Lambert <lambert.quentin@gmail.com>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Salvatore Benedetto <salvatore.benedetto@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
qat-linux@intel.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org,
Quentin Lambert <lambert.quentin@gmail.com>
Subject: [PATCH 2/2] crypto: qat - fix resource release omissions
Date: Fri, 2 Sep 2016 16:37:59 +0200 [thread overview]
Message-ID: <20160902143759.31125-3-lambert.quentin@gmail.com> (raw)
In-Reply-To: <20160902143759.31125-1-lambert.quentin@gmail.com>
This issue was found with Hector.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/crypto/qat/qat_common/qat_uclo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/crypto/qat/qat_common/qat_uclo.c
+++ b/drivers/crypto/qat/qat_common/qat_uclo.c
@@ -981,7 +981,8 @@ static int qat_uclo_parse_uof_obj(struct
(PID_MINOR_REV & handle->hal_handle->revision_id);
if (qat_uclo_check_uof_compat(obj_handle)) {
pr_err("QAT: UOF incompatible\n");
- return -EINVAL;
+ ret = -EINVAL;
+ goto out_err;
}
obj_handle->ustore_phy_size = ICP_QAT_UCLO_MAX_USTORE;
if (!obj_handle->obj_hdr->file_buff ||
next prev parent reply other threads:[~2016-09-02 14:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 14:37 [PATCH 0/2] add omitted release in qat_common Quentin Lambert
2016-09-02 14:37 ` Quentin Lambert
2016-09-02 14:37 ` [PATCH 1/2] crypto: qat - introduces a variable to handle error codes Quentin Lambert
2016-09-02 14:37 ` Quentin Lambert
2016-09-02 14:37 ` Quentin Lambert [this message]
2016-09-02 14:37 ` [PATCH 2/2] crypto: qat - fix resource release omissions Quentin Lambert
2016-09-02 14:43 ` [PATCH 0/2][RESEND] add omitted release in qat_common Quentin Lambert
2016-09-02 14:43 ` Quentin Lambert
2016-09-02 14:43 ` [PATCH 1/2][RESEND] crypto: qat - introduces a variable to handle error codes Quentin Lambert
2016-09-02 14:43 ` Quentin Lambert
2016-09-02 14:43 ` [PATCH 2/2] crypto: qat - fix resource release omissions Quentin Lambert
2016-09-02 14:43 ` Quentin Lambert
2016-09-02 14:47 ` [PATCH v2 0/2] add omitted release in qat_common Quentin Lambert
2016-09-02 14:47 ` Quentin Lambert
2016-09-02 14:47 ` [PATCH v2 1/2] crypto: qat - introduces a variable to handle error codes Quentin Lambert
2016-09-02 14:47 ` Quentin Lambert
2016-09-02 14:47 ` [PATCH v2 2/2] crypto: qat - fix resource release omissions Quentin Lambert
2016-09-02 14:47 ` Quentin Lambert
2016-09-06 10:18 ` Giovanni Cabiddu
2016-09-06 10:18 ` Giovanni Cabiddu
2016-09-13 12:40 ` Herbert Xu
2016-09-13 12:40 ` Herbert Xu
2016-09-13 12:56 ` Quentin Lambert
2016-09-13 12:56 ` Quentin Lambert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902143759.31125-3-lambert.quentin@gmail.com \
--to=lambert.quentin@gmail.com \
--cc=davem@davemloft.net \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=salvatore.benedetto@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.