From: Kalle Valo <kvalo@codeaurora.org>
To: Pavel Andrianov <andrianov@ispras.ru>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Pavel Andrianov <andrianov@ispras.ru>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org,
vaishali.thakkar@oracle.com
Subject: Re: wl3501_cs: Add spinlock to wl3501_reset
Date: Sat, 3 Sep 2016 10:01:36 +0000 (UTC) [thread overview]
Message-ID: <20160903100136.BB94A6201C@smtp.codeaurora.org> (raw)
In-Reply-To: <1470130913-5218-1-git-send-email-andrianov@ispras.ru>
Pavel Andrianov <andrianov@ispras.ru> wrote:
> Likely wl3501_reset should acquire spinlock as wl3501_{open, close}.
> One of calls of wl3501_reset has been already protected.
> The others were unprotected and might lead to a race condition.
> The patch adds spinlock into the wl3501_reset and removes it from
> wl3501_tx_timeout.
>
> Found by Linux Driver Verification project (linuxtesting.org)
>
> Signed-off-by: Pavel Andrianov <andrianov@ispras.ru>
> Acked-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Thanks, 1 patch applied to wireless-drivers-next.git:
bd6b0242652a wl3501_cs: Add spinlock to wl3501_reset
--
Sent by pwcli
https://patchwork.kernel.org/patch/9255415/
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Pavel Andrianov <andrianov-ufN2psIa012HXe+LvDLADg@public.gmane.org>
Cc: Arnaldo Carvalho de Melo
<acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Pavel Andrianov
<andrianov-ufN2psIa012HXe+LvDLADg@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ldv-project-tpLiQldItUH5n4uC9ZG1Ww@public.gmane.org,
vaishali.thakkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Subject: Re: wl3501_cs: Add spinlock to wl3501_reset
Date: Sat, 3 Sep 2016 10:01:36 +0000 (UTC) [thread overview]
Message-ID: <20160903100136.BB94A6201C@smtp.codeaurora.org> (raw)
In-Reply-To: <1470130913-5218-1-git-send-email-andrianov-ufN2psIa012HXe+LvDLADg@public.gmane.org>
Pavel Andrianov <andrianov-ufN2psIa012HXe+LvDLADg@public.gmane.org> wrote:
> Likely wl3501_reset should acquire spinlock as wl3501_{open, close}.
> One of calls of wl3501_reset has been already protected.
> The others were unprotected and might lead to a race condition.
> The patch adds spinlock into the wl3501_reset and removes it from
> wl3501_tx_timeout.
>
> Found by Linux Driver Verification project (linuxtesting.org)
>
> Signed-off-by: Pavel Andrianov <andrianov-ufN2psIa012HXe+LvDLADg@public.gmane.org>
> Acked-by: Vaishali Thakkar <vaishali.thakkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Thanks, 1 patch applied to wireless-drivers-next.git:
bd6b0242652a wl3501_cs: Add spinlock to wl3501_reset
--
Sent by pwcli
https://patchwork.kernel.org/patch/9255415/
next prev parent reply other threads:[~2016-09-03 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 9:41 [PATCH] wl3501_cs: Add spinlock to wl3501_reset Pavel Andrianov
2016-08-04 5:01 ` Vaishali Thakkar
2016-08-04 5:01 ` Vaishali Thakkar
2016-09-03 10:01 ` Kalle Valo [this message]
2016-09-03 10:01 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160903100136.BB94A6201C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=acme@redhat.com \
--cc=andrianov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vaishali.thakkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.