From: Kalle Valo <kvalo@codeaurora.org>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Cc: akarwar@marvell.com, nishants@marvell.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [1/2] mwifiex: fix the length parameter of a memset
Date: Sat, 03 Sep 2016 10:04:41 +0000 [thread overview]
Message-ID: <20160903100441.E591B6201F@smtp.codeaurora.org> (raw)
In-Reply-To: <1470641928-26616-1-git-send-email-christophe.jaillet@wanadoo.fr>
Christophe Jaillet <christophe.jaillet@wanadoo.fr> wrote:
> In 'mwifiex_get_ver_ext', we have:
> struct mwifiex_ver_ext ver_ext;
>
> memset(&ver_ext, 0, sizeof(struct host_cmd_ds_version_ext));
>
> This is likely that memset'ing sizeof(struct mwifiex_ver_ext) was expected.
> Remove the ambiguity by using the variable name directly instead of its
> type.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks, 2 patches applied to wireless-drivers-next.git:
ba852018d493 mwifiex: fix the length parameter of a memset
6a1622000ac9 mwifiex: simplify length computation for some memset
--
Sent by pwcli
https://patchwork.kernel.org/patch/9266889/
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Cc: akarwar@marvell.com, nishants@marvell.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [1/2] mwifiex: fix the length parameter of a memset
Date: Sat, 3 Sep 2016 10:04:41 +0000 (UTC) [thread overview]
Message-ID: <20160903100441.E591B6201F@smtp.codeaurora.org> (raw)
In-Reply-To: <1470641928-26616-1-git-send-email-christophe.jaillet@wanadoo.fr>
Christophe Jaillet <christophe.jaillet@wanadoo.fr> wrote:
> In 'mwifiex_get_ver_ext', we have:
> struct mwifiex_ver_ext ver_ext;
>
> memset(&ver_ext, 0, sizeof(struct host_cmd_ds_version_ext));
>
> This is likely that memset'ing sizeof(struct mwifiex_ver_ext) was expected.
> Remove the ambiguity by using the variable name directly instead of its
> type.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks, 2 patches applied to wireless-drivers-next.git:
ba852018d493 mwifiex: fix the length parameter of a memset
6a1622000ac9 mwifiex: simplify length computation for some memset
--
Sent by pwcli
https://patchwork.kernel.org/patch/9266889/
next prev parent reply other threads:[~2016-09-03 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 7:38 [PATCH 1/2] mwifiex: fix the length parameter of a memset Christophe JAILLET
2016-08-08 7:38 ` Christophe JAILLET
2016-09-03 10:04 ` Kalle Valo [this message]
2016-09-03 10:04 ` [1/2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160903100441.E591B6201F@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.