From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: Xie Yisheng <xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] arm64/efi: efi_init error handling fix
Date: Mon, 5 Sep 2016 14:57:23 +0100 [thread overview]
Message-ID: <20160905135723.GK32579@codeblueprint.co.uk> (raw)
In-Reply-To: <20160902102618.GC17482-5wv7dgnIgG8@public.gmane.org>
On Fri, 02 Sep, at 11:26:18AM, Will Deacon wrote:
> On Fri, Sep 02, 2016 at 06:18:39PM +0800, Xie Yisheng wrote:
> > From: Yisheng Xie <xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> >
> > There's an early memmap leak in efi_init error path, fix it.
> >
> > Signed-off-by: Yisheng Xie <xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> > ---
> > drivers/firmware/efi/arm-init.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Adding linux-efi, Ard and Matt. Please try to CC the relevant people in
> future.
>
> Will
>
> > diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
> > index c49d50e..5080e40 100644
> > --- a/drivers/firmware/efi/arm-init.c
> > +++ b/drivers/firmware/efi/arm-init.c
> > @@ -243,8 +243,10 @@ void __init efi_init(void)
> > "Unexpected EFI_MEMORY_DESCRIPTOR version %ld",
> > efi.memmap.desc_version);
> >
> > - if (uefi_init() < 0)
> > + if (uefi_init() < 0) {
> > + early_memunmap(efi.memmap.map, params.mmap_size);
> > return;
> > + }
This should be a call to efi_memmap_unmap() because the EFI_MEMMAP
flag also needs clearing.
WARNING: multiple messages have this Message-ID (diff)
From: matt@codeblueprint.co.uk (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/efi: efi_init error handling fix
Date: Mon, 5 Sep 2016 14:57:23 +0100 [thread overview]
Message-ID: <20160905135723.GK32579@codeblueprint.co.uk> (raw)
In-Reply-To: <20160902102618.GC17482@arm.com>
On Fri, 02 Sep, at 11:26:18AM, Will Deacon wrote:
> On Fri, Sep 02, 2016 at 06:18:39PM +0800, Xie Yisheng wrote:
> > From: Yisheng Xie <xieyisheng1@huawei.com>
> >
> > There's an early memmap leak in efi_init error path, fix it.
> >
> > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> > ---
> > drivers/firmware/efi/arm-init.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Adding linux-efi, Ard and Matt. Please try to CC the relevant people in
> future.
>
> Will
>
> > diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
> > index c49d50e..5080e40 100644
> > --- a/drivers/firmware/efi/arm-init.c
> > +++ b/drivers/firmware/efi/arm-init.c
> > @@ -243,8 +243,10 @@ void __init efi_init(void)
> > "Unexpected EFI_MEMORY_DESCRIPTOR version %ld",
> > efi.memmap.desc_version);
> >
> > - if (uefi_init() < 0)
> > + if (uefi_init() < 0) {
> > + early_memunmap(efi.memmap.map, params.mmap_size);
> > return;
> > + }
This should be a call to efi_memmap_unmap() because the EFI_MEMMAP
flag also needs clearing.
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Will Deacon <will.deacon@arm.com>
Cc: Xie Yisheng <xieyisheng1@huawei.com>,
mingo@kernel.org, guohanjun@huawei.com, mark.rutland@arm.com,
catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org,
ard.biesheuvel@linaro.org
Subject: Re: [PATCH] arm64/efi: efi_init error handling fix
Date: Mon, 5 Sep 2016 14:57:23 +0100 [thread overview]
Message-ID: <20160905135723.GK32579@codeblueprint.co.uk> (raw)
In-Reply-To: <20160902102618.GC17482@arm.com>
On Fri, 02 Sep, at 11:26:18AM, Will Deacon wrote:
> On Fri, Sep 02, 2016 at 06:18:39PM +0800, Xie Yisheng wrote:
> > From: Yisheng Xie <xieyisheng1@huawei.com>
> >
> > There's an early memmap leak in efi_init error path, fix it.
> >
> > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> > ---
> > drivers/firmware/efi/arm-init.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Adding linux-efi, Ard and Matt. Please try to CC the relevant people in
> future.
>
> Will
>
> > diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
> > index c49d50e..5080e40 100644
> > --- a/drivers/firmware/efi/arm-init.c
> > +++ b/drivers/firmware/efi/arm-init.c
> > @@ -243,8 +243,10 @@ void __init efi_init(void)
> > "Unexpected EFI_MEMORY_DESCRIPTOR version %ld",
> > efi.memmap.desc_version);
> >
> > - if (uefi_init() < 0)
> > + if (uefi_init() < 0) {
> > + early_memunmap(efi.memmap.map, params.mmap_size);
> > return;
> > + }
This should be a call to efi_memmap_unmap() because the EFI_MEMMAP
flag also needs clearing.
next prev parent reply other threads:[~2016-09-05 13:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 10:18 [PATCH] arm64/efi: efi_init error handling fix Xie Yisheng
2016-09-02 10:18 ` Xie Yisheng
[not found] ` <1472811519-4897-1-git-send-email-xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-09-02 10:26 ` Will Deacon
2016-09-02 10:26 ` Will Deacon
2016-09-02 10:26 ` Will Deacon
[not found] ` <20160902102618.GC17482-5wv7dgnIgG8@public.gmane.org>
2016-09-05 11:11 ` Yisheng Xie
2016-09-05 11:11 ` Yisheng Xie
2016-09-05 11:11 ` Yisheng Xie
2016-09-05 13:57 ` Matt Fleming [this message]
2016-09-05 13:57 ` Matt Fleming
2016-09-05 13:57 ` Matt Fleming
[not found] ` <20160905135723.GK32579-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-09-07 11:15 ` Yisheng Xie
2016-09-07 11:15 ` Yisheng Xie
2016-09-07 11:15 ` Yisheng Xie
[not found] ` <c57dfbbe-a2a7-e8af-7d94-20f86126053c-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-09-13 11:18 ` Matt Fleming
2016-09-13 11:18 ` Matt Fleming
2016-09-13 11:18 ` Matt Fleming
[not found] ` <20160913111804.GG3872-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-09-19 12:29 ` Yisheng Xie
2016-09-19 12:29 ` Yisheng Xie
2016-09-19 12:29 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905135723.GK32579@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
--cc=xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.