From: Baruch Siach <baruch@tkos.co.il>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
sboyd@codeaurora.org, mturquette@baylibre.com,
thomas.petazzoni@free-electrons.com, andrew@lunn.ch,
jason@lakedaemon.net, tn@semihalf.com, stable@vger.kernel.org,
nadavh@marvell.com, alior@marvell.com, jaz@semihalf.com,
gregory.clement@free-electrons.com,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH v2 2/3] clk: mvebu: dynamically allocate resources in Armada CP110 system controller
Date: Tue, 6 Sep 2016 20:59:51 +0300 [thread overview]
Message-ID: <20160906175951.etybwtilfvyclrdb@tarshish> (raw)
In-Reply-To: <1473183117-11889-3-git-send-email-mw@semihalf.com>
Hi Marcin,
On Tue, Sep 06, 2016 at 07:31:56PM +0200, Marcin Wojtas wrote:
> + cp110_clks = devm_kcalloc(&pdev->dev, sizeof(struct clk *),
> + CP110_CLK_NUM, GFP_KERNEL);
> + if (!cp110_clks)
> + return PTR_ERR(cp110_clks);
PTR_ERR(NULL) translates to 0. Should probably just return -ENOMEM.
> + cp110_clk_data = devm_kzalloc(&pdev->dev,
> + sizeof(*cp110_clk_data),
> + GFP_KERNEL);
> + if (!cp110_clk_data)
> + return PTR_ERR(cp110_clk_data);
Ditto.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] clk: mvebu: dynamically allocate resources in Armada CP110 system controller
Date: Tue, 6 Sep 2016 20:59:51 +0300 [thread overview]
Message-ID: <20160906175951.etybwtilfvyclrdb@tarshish> (raw)
In-Reply-To: <1473183117-11889-3-git-send-email-mw@semihalf.com>
Hi Marcin,
On Tue, Sep 06, 2016 at 07:31:56PM +0200, Marcin Wojtas wrote:
> + cp110_clks = devm_kcalloc(&pdev->dev, sizeof(struct clk *),
> + CP110_CLK_NUM, GFP_KERNEL);
> + if (!cp110_clks)
> + return PTR_ERR(cp110_clks);
PTR_ERR(NULL) translates to 0. Should probably just return -ENOMEM.
> + cp110_clk_data = devm_kzalloc(&pdev->dev,
> + sizeof(*cp110_clk_data),
> + GFP_KERNEL);
> + if (!cp110_clk_data)
> + return PTR_ERR(cp110_clk_data);
Ditto.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2016-09-06 17:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 17:31 [PATCH v2 0/3] Armada 7k/8k CP110 system controller fixes Marcin Wojtas
2016-09-06 17:31 ` Marcin Wojtas
2016-09-06 17:31 ` [PATCH v2 1/3] clk: mvebu: fix setting unwanted flags in CP110 gate clock Marcin Wojtas
2016-09-06 17:31 ` Marcin Wojtas
2016-09-06 17:31 ` [PATCH v2 2/3] clk: mvebu: dynamically allocate resources in Armada CP110 system controller Marcin Wojtas
2016-09-06 17:31 ` Marcin Wojtas
2016-09-06 17:59 ` Baruch Siach [this message]
2016-09-06 17:59 ` Baruch Siach
2016-09-06 17:31 ` [PATCH v2 3/3] clk: mvebu: migrate CP110 system controller to clk_hw API and registration Marcin Wojtas
2016-09-06 17:31 ` Marcin Wojtas
2016-09-19 13:17 ` [PATCH v2 0/3] Armada 7k/8k CP110 system controller fixes Marcin Wojtas
2016-09-19 13:17 ` Marcin Wojtas
2016-09-19 18:15 ` Stephen Boyd
2016-09-19 18:15 ` Stephen Boyd
2016-09-19 18:18 ` Marcin Wojtas
2016-09-19 18:18 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906175951.etybwtilfvyclrdb@tarshish \
--to=baruch@tkos.co.il \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.