From: Mark Brown <broonie@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
plagnioj@jcrosoft.com, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: mxsfb: get supply regulator optionally
Date: Tue, 06 Sep 2016 22:22:36 +0000 [thread overview]
Message-ID: <20160906222236.GU3950@sirena.org.uk> (raw)
In-Reply-To: <4b3a7bda2202a536efaf4a693234c273@agner.ch>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On Tue, Sep 06, 2016 at 11:23:31AM -0700, Stefan Agner wrote:
> On 2016-09-06 01:21, Tomi Valkeinen wrote:
> > In order to ease transitions with drivers are boards start using regulators
> > provide an option to cause all regulator_get() calls to succeed, with a
> > dummy always on regulator being supplied where one has not been configured.
> > A warning is printed whenever the dummy regulator is used to aid system
> > development.
> I think we should either make the property mandatory and fix the device
> trees or we should fix the driver to support an optional regulator. The
> code already supports the reg_lcd being NULL, which is probably mostly
> pointless right now as devm_regulator_get always returns a dummy
> regulator.
I think you're agreeing with each other here (and me).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
plagnioj@jcrosoft.com, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: mxsfb: get supply regulator optionally
Date: Tue, 6 Sep 2016 23:22:36 +0100 [thread overview]
Message-ID: <20160906222236.GU3950@sirena.org.uk> (raw)
In-Reply-To: <4b3a7bda2202a536efaf4a693234c273@agner.ch>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On Tue, Sep 06, 2016 at 11:23:31AM -0700, Stefan Agner wrote:
> On 2016-09-06 01:21, Tomi Valkeinen wrote:
> > In order to ease transitions with drivers are boards start using regulators
> > provide an option to cause all regulator_get() calls to succeed, with a
> > dummy always on regulator being supplied where one has not been configured.
> > A warning is printed whenever the dummy regulator is used to aid system
> > development.
> I think we should either make the property mandatory and fix the device
> trees or we should fix the driver to support an optional regulator. The
> code already supports the reg_lcd being NULL, which is probably mostly
> pointless right now as devm_regulator_get always returns a dummy
> regulator.
I think you're agreeing with each other here (and me).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2016-09-06 22:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 4:26 [PATCH] video: mxsfb: get supply regulator optionally Stefan Agner
2016-09-04 4:26 ` Stefan Agner
2016-09-04 4:26 ` Stefan Agner
2016-09-06 8:21 ` Tomi Valkeinen
2016-09-06 8:21 ` Tomi Valkeinen
2016-09-06 8:21 ` Tomi Valkeinen
[not found] ` <f8368040-bb5a-91e0-7511-df462719b949-l0cyMroinI0@public.gmane.org>
2016-09-06 18:23 ` Stefan Agner
2016-09-06 18:23 ` Stefan Agner
2016-09-06 18:23 ` Stefan Agner
2016-09-06 22:22 ` Mark Brown [this message]
2016-09-06 22:22 ` Mark Brown
[not found] ` <4b3a7bda2202a536efaf4a693234c273-XLVq0VzYD2Y@public.gmane.org>
2016-09-07 7:20 ` Tomi Valkeinen
2016-09-07 7:20 ` Tomi Valkeinen
2016-09-07 7:20 ` Tomi Valkeinen
[not found] ` <1812b2bf-bd66-3553-4c2d-3d2b08603ca0-l0cyMroinI0@public.gmane.org>
2016-09-12 23:47 ` Mark Brown
2016-09-12 23:47 ` Mark Brown
2016-09-12 23:47 ` Mark Brown
2016-11-09 0:16 ` Stefan Agner
2016-11-09 0:16 ` Stefan Agner
2016-11-09 0:16 ` Stefan Agner
[not found] ` <20160904042627.30182-1-stefan-XLVq0VzYD2Y@public.gmane.org>
2016-09-12 15:47 ` Rob Herring
2016-09-12 15:47 ` Rob Herring
2016-09-12 15:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906222236.GU3950@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.