From: Stephen Boyd <sboyd@codeaurora.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Michael Turquette <mturquette@baylibre.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Inki Dae <inki.dae@samsung.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 4/5] ARM: dts: exynos: add support for ISP power domain to exynos4x12 clocks device
Date: Wed, 7 Sep 2016 17:22:54 -0700 [thread overview]
Message-ID: <20160908002254.GD13062@codeaurora.org> (raw)
In-Reply-To: <1472737551-15272-5-git-send-email-m.szyprowski@samsung.com>
On 09/01, Marek Szyprowski wrote:
> Exynos4412 clock controller contains some additional clocks for FIMC-ISP
> (Camera ISP) subsystem. Registers for those clocks are partially located
> in the SOC area, which belongs to ISP power domain.
>
> This patch extends clock controller node with ISP clock sub-node and link
> (phandle) to ISP power domain.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index 3394bdcf10ae..4daea67546b9 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -74,6 +74,11 @@
> compatible = "samsung,exynos4412-clock";
> reg = <0x10030000 0x20000>;
> #clock-cells = <1>;
> +
> + isp-clock-controller {
> + compatible = "samsung,exynos4412-isp-clock";
> + power-domains = <&pd_isp>;
> + };
Why can't we extend support in power domains code to have
multiple domains for a single device node? i.e. power-domains =
<&pd_isp>, <&pd_foo>, <&pd_bar>, and then pick the right one with
power-domain-names or something like that? Making a subnode
(which seems to turn into a child platform device?) seems like a
quick solution for larger problems.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: dts: exynos: add support for ISP power domain to exynos4x12 clocks device
Date: Wed, 7 Sep 2016 17:22:54 -0700 [thread overview]
Message-ID: <20160908002254.GD13062@codeaurora.org> (raw)
In-Reply-To: <1472737551-15272-5-git-send-email-m.szyprowski@samsung.com>
On 09/01, Marek Szyprowski wrote:
> Exynos4412 clock controller contains some additional clocks for FIMC-ISP
> (Camera ISP) subsystem. Registers for those clocks are partially located
> in the SOC area, which belongs to ISP power domain.
>
> This patch extends clock controller node with ISP clock sub-node and link
> (phandle) to ISP power domain.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index 3394bdcf10ae..4daea67546b9 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -74,6 +74,11 @@
> compatible = "samsung,exynos4412-clock";
> reg = <0x10030000 0x20000>;
> #clock-cells = <1>;
> +
> + isp-clock-controller {
> + compatible = "samsung,exynos4412-isp-clock";
> + power-domains = <&pd_isp>;
> + };
Why can't we extend support in power domains code to have
multiple domains for a single device node? i.e. power-domains =
<&pd_isp>, <&pd_foo>, <&pd_bar>, and then pick the right one with
power-domain-names or something like that? Making a subnode
(which seems to turn into a child platform device?) seems like a
quick solution for larger problems.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-09-08 0:22 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 13:45 [PATCH 0/5] Add runtime PM support for clocks (on Exynos SoC example) Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-01 13:45 ` [PATCH 1/5] clk: add support for runtime pm Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-01 15:10 ` [PATCH] clk: fix boolreturn.cocci warnings kbuild test robot
2016-09-01 15:10 ` kbuild test robot
2016-09-01 15:10 ` kbuild test robot
2016-09-01 15:10 ` [PATCH 1/5] clk: add support for runtime pm kbuild test robot
2016-09-01 15:10 ` kbuild test robot
2016-09-01 15:10 ` kbuild test robot
2016-09-08 0:19 ` Stephen Boyd
2016-09-08 0:19 ` Stephen Boyd
2016-09-12 10:18 ` Marek Szyprowski
2016-09-12 10:18 ` Marek Szyprowski
2016-09-12 22:31 ` Stephen Boyd
2016-09-12 22:31 ` Stephen Boyd
2016-09-13 9:07 ` Marek Szyprowski
2016-09-13 9:07 ` Marek Szyprowski
2016-09-14 21:39 ` Stephen Boyd
2016-09-14 21:39 ` Stephen Boyd
2016-09-15 8:32 ` Marek Szyprowski
2016-09-15 8:32 ` Marek Szyprowski
2016-09-13 7:24 ` Ulf Hansson
2016-09-13 7:24 ` Ulf Hansson
2016-09-13 8:49 ` Ulf Hansson
2016-09-13 8:49 ` Ulf Hansson
2016-09-13 13:13 ` Marek Szyprowski
2016-09-13 13:13 ` Marek Szyprowski
2016-09-13 15:03 ` Ulf Hansson
2016-09-13 15:03 ` Ulf Hansson
2016-09-14 10:11 ` Marek Szyprowski
2016-09-14 10:11 ` Marek Szyprowski
2016-09-01 13:45 ` [PATCH 2/5] clock: samsung: " Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-01 13:45 ` [PATCH 3/5] clocks: exynos4x12: add runtime pm support for ISP clocks Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-01 21:49 ` kbuild test robot
2016-09-01 21:49 ` kbuild test robot
2016-09-01 21:49 ` kbuild test robot
2016-09-01 13:45 ` [PATCH 4/5] ARM: dts: exynos: add support for ISP power domain to exynos4x12 clocks device Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-08 0:22 ` Stephen Boyd [this message]
2016-09-08 0:22 ` Stephen Boyd
2016-09-12 10:23 ` Marek Szyprowski
2016-09-12 10:23 ` Marek Szyprowski
2016-09-12 22:28 ` Stephen Boyd
2016-09-12 22:28 ` Stephen Boyd
2016-09-15 12:06 ` Marek Szyprowski
2016-09-15 12:06 ` Marek Szyprowski
2016-09-15 12:06 ` Marek Szyprowski
2016-09-15 14:13 ` Ulf Hansson
2016-09-15 14:13 ` Ulf Hansson
2016-09-01 13:45 ` [PATCH 5/5] clocks: exynos5433: add runtime pm support Marek Szyprowski
2016-09-01 13:45 ` Marek Szyprowski
2016-09-01 16:55 ` Bartlomiej Zolnierkiewicz
2016-09-01 16:55 ` Bartlomiej Zolnierkiewicz
2016-09-01 16:55 ` Bartlomiej Zolnierkiewicz
2016-09-01 23:00 ` kbuild test robot
2016-09-01 23:00 ` kbuild test robot
2016-09-01 23:00 ` kbuild test robot
2016-09-02 19:05 ` kbuild test robot
2016-09-02 19:05 ` kbuild test robot
2016-09-02 19:05 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908002254.GD13062@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=inki.dae@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.