From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Mylene Josserand <mylene.josserand@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Alexander Kaplan <alex@nextthing.co>
Subject: Re: [PATCH v2 4/4] ARM: dts: gr8: Add support for the GR8 evaluation board
Date: Thu, 8 Sep 2016 09:40:17 +0200 [thread overview]
Message-ID: <20160908074017.GG8913@lukather> (raw)
In-Reply-To: <CAGb2v66Ed1u5NaC9ev=ohywCbssy6BnkPcThY2D9O=_eNK1pdA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2622 bytes --]
On Wed, Sep 07, 2016 at 11:23:56PM +0800, Chen-Yu Tsai wrote:
> > +&i2c1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c1_pins_a>;
> > + status = "okay";
> > +
> > + pcf8563: rtc@51 {
> > + compatible = "phg,pcf8563";
> > + reg = <0x51>;
> > + };
> > +
> > + wm8978: codec@1a {
> > + #sound-dai-cells = <0>;
> > + compatible = "wlf,wm8978";
> > + reg = <0x1a>;
> > + };
>
> Seems like I2S support will happen soon? :)
Indeed :)
It's not working for the moment, which is why it's not enabled through
a simple-card, but I'll work on it ASAP.
(same thing with SPDIF).
>
> > +};
>
> [...]
>
> > diff --git a/arch/arm/boot/dts/ntc-gr8.dtsi b/arch/arm/boot/dts/ntc-gr8.dtsi
> > index d21cfa3f3c14..cdb7a12946c4 100644
> > --- a/arch/arm/boot/dts/ntc-gr8.dtsi
> > +++ b/arch/arm/boot/dts/ntc-gr8.dtsi
>
> This looks like the wrong patch. Nevertheless...
Hmmm, indeed.
>
> > @@ -228,7 +228,7 @@
> >
> > axi_gates: clk@01c2005c {
> > #clock-cells = <1>;
> > - compatible = "allwinner,sun4i-a10-axi-gates-clk";
> > + compatible = "allwinner,sun4i-a10-gates-clk";
> > reg = <0x01c2005c 0x4>;
> > clocks = <&axi>;
> > clock-indices = <0>;
> > @@ -244,7 +244,7 @@
> > <2>, <5>, <6>,
> > <7>, <8>, <9>,
> > <10>, <13>,
> > - <14>, <20>,
> > + <14>, <17>, <20>,
> > <21>, <22>,
> > <28>, <32>, <34>,
> > <36>, <40>, <44>,
> > @@ -254,7 +254,7 @@
> > "ahb_ohci", "ahb_ss", "ahb_dma",
> > "ahb_bist", "ahb_mmc0", "ahb_mmc1",
> > "ahb_mmc2", "ahb_nand",
> > - "ahb_sdram", "ahb_spi0",
> > + "ahb_sdram", "ahb_sdram", "ahb_spi0",
>
> I don't think this will work. Copy/paste error?
Yes, that was supposed to be ethernet. Sorry.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] ARM: dts: gr8: Add support for the GR8 evaluation board
Date: Thu, 8 Sep 2016 09:40:17 +0200 [thread overview]
Message-ID: <20160908074017.GG8913@lukather> (raw)
In-Reply-To: <CAGb2v66Ed1u5NaC9ev=ohywCbssy6BnkPcThY2D9O=_eNK1pdA@mail.gmail.com>
On Wed, Sep 07, 2016 at 11:23:56PM +0800, Chen-Yu Tsai wrote:
> > +&i2c1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c1_pins_a>;
> > + status = "okay";
> > +
> > + pcf8563: rtc at 51 {
> > + compatible = "phg,pcf8563";
> > + reg = <0x51>;
> > + };
> > +
> > + wm8978: codec at 1a {
> > + #sound-dai-cells = <0>;
> > + compatible = "wlf,wm8978";
> > + reg = <0x1a>;
> > + };
>
> Seems like I2S support will happen soon? :)
Indeed :)
It's not working for the moment, which is why it's not enabled through
a simple-card, but I'll work on it ASAP.
(same thing with SPDIF).
>
> > +};
>
> [...]
>
> > diff --git a/arch/arm/boot/dts/ntc-gr8.dtsi b/arch/arm/boot/dts/ntc-gr8.dtsi
> > index d21cfa3f3c14..cdb7a12946c4 100644
> > --- a/arch/arm/boot/dts/ntc-gr8.dtsi
> > +++ b/arch/arm/boot/dts/ntc-gr8.dtsi
>
> This looks like the wrong patch. Nevertheless...
Hmmm, indeed.
>
> > @@ -228,7 +228,7 @@
> >
> > axi_gates: clk at 01c2005c {
> > #clock-cells = <1>;
> > - compatible = "allwinner,sun4i-a10-axi-gates-clk";
> > + compatible = "allwinner,sun4i-a10-gates-clk";
> > reg = <0x01c2005c 0x4>;
> > clocks = <&axi>;
> > clock-indices = <0>;
> > @@ -244,7 +244,7 @@
> > <2>, <5>, <6>,
> > <7>, <8>, <9>,
> > <10>, <13>,
> > - <14>, <20>,
> > + <14>, <17>, <20>,
> > <21>, <22>,
> > <28>, <32>, <34>,
> > <36>, <40>, <44>,
> > @@ -254,7 +254,7 @@
> > "ahb_ohci", "ahb_ss", "ahb_dma",
> > "ahb_bist", "ahb_mmc0", "ahb_mmc1",
> > "ahb_mmc2", "ahb_nand",
> > - "ahb_sdram", "ahb_spi0",
> > + "ahb_sdram", "ahb_sdram", "ahb_spi0",
>
> I don't think this will work. Copy/paste error?
Yes, that was supposed to be ethernet. Sorry.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160908/fb37f880/attachment-0001.sig>
next prev parent reply other threads:[~2016-09-08 7:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 14:53 [PATCH v2 0/4] Introduce NextThing GR8 support Maxime Ripard
2016-09-07 14:53 ` Maxime Ripard
2016-09-07 14:53 ` [PATCH v2 1/4] pinctrl: sunxi: Add GR8 controller support Maxime Ripard
2016-09-07 14:53 ` Maxime Ripard
2016-09-07 19:17 ` Linus Walleij
2016-09-07 19:17 ` Linus Walleij
2016-09-07 19:27 ` Maxime Ripard
2016-09-07 19:27 ` Maxime Ripard
2016-09-07 14:53 ` [PATCH v2 2/4] ARM: sunxi: Support the Nextthing GR8 Maxime Ripard
2016-09-07 14:53 ` Maxime Ripard
2016-09-07 14:53 ` [PATCH v2 3/4] ARM: dts: Add NextThing GR8 dtsi Maxime Ripard
2016-09-07 14:53 ` Maxime Ripard
2016-09-07 16:32 ` Chen-Yu Tsai
2016-09-07 16:32 ` Chen-Yu Tsai
2016-09-08 7:41 ` Maxime Ripard
2016-09-08 7:41 ` Maxime Ripard
2016-09-14 2:48 ` Chen-Yu Tsai
2016-09-14 2:48 ` Chen-Yu Tsai
2016-09-07 19:37 ` Linus Walleij
2016-09-07 19:37 ` Linus Walleij
2016-09-08 4:46 ` Chen-Yu Tsai
2016-09-08 4:46 ` Chen-Yu Tsai
2016-09-08 7:37 ` Maxime Ripard
2016-09-08 7:37 ` Maxime Ripard
2016-09-12 12:40 ` Linus Walleij
2016-09-12 12:40 ` Linus Walleij
2016-09-12 12:47 ` Laurent Pinchart
2016-09-12 12:47 ` Laurent Pinchart
2016-09-13 9:09 ` Linus Walleij
2016-09-13 9:09 ` Linus Walleij
2016-09-14 2:56 ` Chen-Yu Tsai
2016-09-14 2:56 ` Chen-Yu Tsai
2016-09-07 14:54 ` [PATCH v2 4/4] ARM: dts: gr8: Add support for the GR8 evaluation board Maxime Ripard
2016-09-07 14:54 ` Maxime Ripard
2016-09-07 14:54 ` Maxime Ripard
2016-09-07 15:23 ` Chen-Yu Tsai
2016-09-07 15:23 ` Chen-Yu Tsai
2016-09-08 7:40 ` Maxime Ripard [this message]
2016-09-08 7:40 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908074017.GG8913@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=alex@nextthing.co \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mylene.josserand@free-electrons.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.