From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF
Date: Thu, 8 Sep 2016 10:40:15 +0200 [thread overview]
Message-ID: <20160908084015.GA2636@jama> (raw)
In-Reply-To: <20160908051048.15948-1-jackie.huang@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]
On Thu, Sep 08, 2016 at 01:10:48PM +0800, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
>
> Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF for waf-samba.bbclass
> because the PACKAGECONFIG will not be handled for all recipes after
> the following commit in oe-core:
>
> commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
> Author: Martin Jansa <martin.jansa@gmail.com>
> Date: Tue Aug 30 16:19:58 2016 +0200
>
> base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in autotools.bbclass
>
> * recipes which don't inherit autotools or cmake bbclass and want to
> use the configure options from PACKAGECONFIG need to handle
> PACKAGECONFIG_CONFARGS themselves.
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
> meta-networking/classes/waf-samba.bbclass | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-samba.bbclass
> index 772bc75..a58ca2c 100644
> --- a/meta-networking/classes/waf-samba.bbclass
> +++ b/meta-networking/classes/waf-samba.bbclass
> @@ -20,6 +20,8 @@ CONFIGUREOPTS = " --prefix=${prefix} \
> --mandir=${mandir} \
> "
>
> +EXTRA_OECONF_append = " ${PACKAGECONFIG_CONFARGS}"
Cannot we append it to CONFIGUREOPTS and remove EXTRA_OECONF from this
bbclass completely?
> +
> # Three methods for waf cross compile:
> # 1. answers:
> # Only --cross-answers - try the cross-answers file, and if
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 169 bytes --]
next prev parent reply other threads:[~2016-09-08 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 5:10 [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF jackie.huang
2016-09-08 8:40 ` Martin Jansa [this message]
2016-09-09 1:18 ` Huang, Jie (Jackie)
2016-09-09 1:25 ` Khem Raj
2016-09-09 1:42 ` Huang, Jie (Jackie)
2016-09-09 1:44 ` Mark Asselstine
2016-09-09 2:52 ` Huang, Jie (Jackie)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908084015.GA2636@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.