[meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA

All of lore.kernel.org
 help / color / mirror / Atom feed

* [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF
@ 2016-09-08  5:10 jackie.huang
  2016-09-08  8:40 ` Martin Jansa
  0 siblings, 1 reply; 7+ messages in thread
From: jackie.huang @ 2016-09-08  5:10 UTC (permalink / raw)
  To: openembedded-devel

From: Jackie Huang <jackie.huang@windriver.com>

Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF for waf-samba.bbclass
because the PACKAGECONFIG will not be handled for all recipes after
the following commit in oe-core:

commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
Author: Martin Jansa <martin.jansa@gmail.com>
Date:   Tue Aug 30 16:19:58 2016 +0200

    base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in autotools.bbclass

    * recipes which don't inherit autotools or cmake bbclass and want to
      use the configure options from PACKAGECONFIG need to handle
      PACKAGECONFIG_CONFARGS themselves.

    Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta-networking/classes/waf-samba.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-samba.bbclass
index 772bc75..a58ca2c 100644
--- a/meta-networking/classes/waf-samba.bbclass
+++ b/meta-networking/classes/waf-samba.bbclass
@@ -20,6 +20,8 @@ CONFIGUREOPTS = " --prefix=${prefix} \
                   --mandir=${mandir} \
                 "
 
+EXTRA_OECONF_append = " ${PACKAGECONFIG_CONFARGS}"
+
 # Three methods for waf cross compile:
 # 1. answers:
 #    Only --cross-answers - try the cross-answers file, and if
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF
  2016-09-08  5:10 [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF jackie.huang
@ 2016-09-08  8:40 ` Martin Jansa
  2016-09-09  1:18   ` Huang, Jie (Jackie)
  0 siblings, 1 reply; 7+ messages in thread
From: Martin Jansa @ 2016-09-08  8:40 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]

On Thu, Sep 08, 2016 at 01:10:48PM +0800, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
> 
> Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF for waf-samba.bbclass
> because the PACKAGECONFIG will not be handled for all recipes after
> the following commit in oe-core:
> 
> commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
> Author: Martin Jansa <martin.jansa@gmail.com>
> Date:   Tue Aug 30 16:19:58 2016 +0200
> 
>     base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in autotools.bbclass
> 
>     * recipes which don't inherit autotools or cmake bbclass and want to
>       use the configure options from PACKAGECONFIG need to handle
>       PACKAGECONFIG_CONFARGS themselves.
> 
>     Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  meta-networking/classes/waf-samba.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-samba.bbclass
> index 772bc75..a58ca2c 100644
> --- a/meta-networking/classes/waf-samba.bbclass
> +++ b/meta-networking/classes/waf-samba.bbclass
> @@ -20,6 +20,8 @@ CONFIGUREOPTS = " --prefix=${prefix} \
>                    --mandir=${mandir} \
>                  "
>  
> +EXTRA_OECONF_append = " ${PACKAGECONFIG_CONFARGS}"

Cannot we append it to CONFIGUREOPTS and remove EXTRA_OECONF from this
bbclass completely?

> +
>  # Three methods for waf cross compile:
>  # 1. answers:
>  #    Only --cross-answers - try the cross-answers file, and if
> -- 
> 2.7.4
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 169 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF
  2016-09-08  8:40 ` Martin Jansa
@ 2016-09-09  1:18   ` Huang, Jie (Jackie)
  2016-09-09  1:25     ` Khem Raj
  0 siblings, 1 reply; 7+ messages in thread
From: Huang, Jie (Jackie) @ 2016-09-09  1:18 UTC (permalink / raw)
  To: openembedded-devel@lists.openembedded.org



> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
> bounces@lists.openembedded.org] On Behalf Of Martin Jansa
> Sent: Thursday, September 08, 2016 4:40 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-networking][PATCH] waf-samba.bbclass: Append
> PACKAGECONFIG_CONFARGS to EXTRA_OECONF
> 
> On Thu, Sep 08, 2016 at 01:10:48PM +0800, jackie.huang@windriver.com wrote:
> > From: Jackie Huang <jackie.huang@windriver.com>
> >
> > Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF for waf-samba.bbclass
> > because the PACKAGECONFIG will not be handled for all recipes after
> > the following commit in oe-core:
> >
> > commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
> > Author: Martin Jansa <martin.jansa@gmail.com>
> > Date:   Tue Aug 30 16:19:58 2016 +0200
> >
> >     base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in
> autotools.bbclass
> >
> >     * recipes which don't inherit autotools or cmake bbclass and want to
> >       use the configure options from PACKAGECONFIG need to handle
> >       PACKAGECONFIG_CONFARGS themselves.
> >
> >     Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> >
> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> > ---
> >  meta-networking/classes/waf-samba.bbclass | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-
> samba.bbclass
> > index 772bc75..a58ca2c 100644
> > --- a/meta-networking/classes/waf-samba.bbclass
> > +++ b/meta-networking/classes/waf-samba.bbclass
> > @@ -20,6 +20,8 @@ CONFIGUREOPTS = " --prefix=${prefix} \
> >                    --mandir=${mandir} \
> >                  "
> >
> > +EXTRA_OECONF_append = " ${PACKAGECONFIG_CONFARGS}"
> 
> Cannot we append it to CONFIGUREOPTS and remove EXTRA_OECONF from this
> bbclass completely?

Yes, we can, but why do we need to remove EXTRA_OECONF from this bbclass
completely? Is it going to be deprecated?

And I see that EXTRA_OECONF  is used in several recipes that inherit waf-samba,
If it's remove from the bbclass, it's should also be removed from those recipes, right?

Thanks,
Jackie

> 
> > +
> >  # Three methods for waf cross compile:
> >  # 1. answers:
> >  #    Only --cross-answers - try the cross-answers file, and if
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF
  2016-09-09  1:18   ` Huang, Jie (Jackie)
@ 2016-09-09  1:25     ` Khem Raj
  2016-09-09  1:42       ` Huang, Jie (Jackie)
  2016-09-09  1:44       ` Mark Asselstine
  0 siblings, 2 replies; 7+ messages in thread
From: Khem Raj @ 2016-09-09  1:25 UTC (permalink / raw)
  To: openembeded-devel

On Thu, Sep 8, 2016 at 6:18 PM, Huang, Jie (Jackie)
<Jackie.Huang@windriver.com> wrote:
>
>
>> -----Original Message-----
>> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
>> bounces@lists.openembedded.org] On Behalf Of Martin Jansa
>> Sent: Thursday, September 08, 2016 4:40 PM
>> To: openembedded-devel@lists.openembedded.org
>> Subject: Re: [oe] [meta-networking][PATCH] waf-samba.bbclass: Append
>> PACKAGECONFIG_CONFARGS to EXTRA_OECONF
>>
>> On Thu, Sep 08, 2016 at 01:10:48PM +0800, jackie.huang@windriver.com wrote:
>> > From: Jackie Huang <jackie.huang@windriver.com>
>> >
>> > Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF for waf-samba.bbclass
>> > because the PACKAGECONFIG will not be handled for all recipes after
>> > the following commit in oe-core:
>> >
>> > commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
>> > Author: Martin Jansa <martin.jansa@gmail.com>
>> > Date:   Tue Aug 30 16:19:58 2016 +0200
>> >
>> >     base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in
>> autotools.bbclass
>> >
>> >     * recipes which don't inherit autotools or cmake bbclass and want to
>> >       use the configure options from PACKAGECONFIG need to handle
>> >       PACKAGECONFIG_CONFARGS themselves.
>> >
>> >     Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>> >     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> >
>> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>> > ---
>> >  meta-networking/classes/waf-samba.bbclass | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-
>> samba.bbclass
>> > index 772bc75..a58ca2c 100644
>> > --- a/meta-networking/classes/waf-samba.bbclass
>> > +++ b/meta-networking/classes/waf-samba.bbclass
>> > @@ -20,6 +20,8 @@ CONFIGUREOPTS = " --prefix=${prefix} \
>> >                    --mandir=${mandir} \
>> >                  "
>> >
>> > +EXTRA_OECONF_append = " ${PACKAGECONFIG_CONFARGS}"
>>
>> Cannot we append it to CONFIGUREOPTS and remove EXTRA_OECONF from this
>> bbclass completely?
>
> Yes, we can, but why do we need to remove EXTRA_OECONF from this bbclass
> completely? Is it going to be deprecated?
>
> And I see that EXTRA_OECONF  is used in several recipes that inherit waf-samba,
> If it's remove from the bbclass, it's should also be removed from those recipes, right?
>

EXTRA_OECONF is usually kept for recipe namespace.

> Thanks,
> Jackie
>
>>
>> > +
>> >  # Three methods for waf cross compile:
>> >  # 1. answers:
>> >  #    Only --cross-answers - try the cross-answers file, and if
>> > --
>> > 2.7.4
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-devel mailing list
>> > Openembedded-devel@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>> --
>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF
  2016-09-09  1:25     ` Khem Raj
@ 2016-09-09  1:42       ` Huang, Jie (Jackie)
  2016-09-09  1:44       ` Mark Asselstine
  1 sibling, 0 replies; 7+ messages in thread
From: Huang, Jie (Jackie) @ 2016-09-09  1:42 UTC (permalink / raw)
  To: openembedded-devel@lists.openembedded.org



> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
> bounces@lists.openembedded.org] On Behalf Of Khem Raj
> Sent: Friday, September 09, 2016 9:25 AM
> To: openembeded-devel
> Subject: Re: [oe] [meta-networking][PATCH] waf-samba.bbclass: Append
> PACKAGECONFIG_CONFARGS to EXTRA_OECONF
> 
> On Thu, Sep 8, 2016 at 6:18 PM, Huang, Jie (Jackie)
> <Jackie.Huang@windriver.com> wrote:
> >
> >
> >> -----Original Message-----
> >> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
> >> bounces@lists.openembedded.org] On Behalf Of Martin Jansa
> >> Sent: Thursday, September 08, 2016 4:40 PM
> >> To: openembedded-devel@lists.openembedded.org
> >> Subject: Re: [oe] [meta-networking][PATCH] waf-samba.bbclass: Append
> >> PACKAGECONFIG_CONFARGS to EXTRA_OECONF
> >>
> >> On Thu, Sep 08, 2016 at 01:10:48PM +0800, jackie.huang@windriver.com wrote:
> >> > From: Jackie Huang <jackie.huang@windriver.com>
> >> >
> >> > Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF for waf-samba.bbclass
> >> > because the PACKAGECONFIG will not be handled for all recipes after
> >> > the following commit in oe-core:
> >> >
> >> > commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
> >> > Author: Martin Jansa <martin.jansa@gmail.com>
> >> > Date:   Tue Aug 30 16:19:58 2016 +0200
> >> >
> >> >     base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in
> >> autotools.bbclass
> >> >
> >> >     * recipes which don't inherit autotools or cmake bbclass and want to
> >> >       use the configure options from PACKAGECONFIG need to handle
> >> >       PACKAGECONFIG_CONFARGS themselves.
> >> >
> >> >     Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >> >     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> >> >
> >> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> >> > ---
> >> >  meta-networking/classes/waf-samba.bbclass | 2 ++
> >> >  1 file changed, 2 insertions(+)
> >> >
> >> > diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-
> >> samba.bbclass
> >> > index 772bc75..a58ca2c 100644
> >> > --- a/meta-networking/classes/waf-samba.bbclass
> >> > +++ b/meta-networking/classes/waf-samba.bbclass
> >> > @@ -20,6 +20,8 @@ CONFIGUREOPTS = " --prefix=${prefix} \
> >> >                    --mandir=${mandir} \
> >> >                  "
> >> >
> >> > +EXTRA_OECONF_append = " ${PACKAGECONFIG_CONFARGS}"
> >>
> >> Cannot we append it to CONFIGUREOPTS and remove EXTRA_OECONF from this
> >> bbclass completely?
> >
> > Yes, we can, but why do we need to remove EXTRA_OECONF from this bbclass
> > completely? Is it going to be deprecated?
> >
> > And I see that EXTRA_OECONF  is used in several recipes that inherit waf-samba,
> > If it's remove from the bbclass, it's should also be removed from those recipes, right?
> >
> 
> EXTRA_OECONF is usually kept for recipe namespace.

Ok, so I will change to use CONFIGUREOPTS in the bbclass.

Thanks,
Jackie

> 
> > Thanks,
> > Jackie
> >
> >>
> >> > +
> >> >  # Three methods for waf cross compile:
> >> >  # 1. answers:
> >> >  #    Only --cross-answers - try the cross-answers file, and if
> >> > --
> >> > 2.7.4
> >> >
> >> > --
> >> > _______________________________________________
> >> > Openembedded-devel mailing list
> >> > Openembedded-devel@lists.openembedded.org
> >> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>
> >> --
> >> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF
  2016-09-09  1:25     ` Khem Raj
  2016-09-09  1:42       ` Huang, Jie (Jackie)
@ 2016-09-09  1:44       ` Mark Asselstine
  2016-09-09  2:52         ` Huang, Jie (Jackie)
  1 sibling, 1 reply; 7+ messages in thread
From: Mark Asselstine @ 2016-09-09  1:44 UTC (permalink / raw)
  To: openembedded-devel, Jackie.Huang

Agreed. I was looking at this today as well and if we go the
EXTRA_OECONF route it should be done in the package recipe.
Additionally Jackie I was going to restrict the blacklist to ARM based
on the build failure report
(http://errors.yoctoproject.org/Errors/Details/81004/).

Could you include a patch for this, something like:

-PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27"
+BLACKLIST_REASON ?= ""
+BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27"
+PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"

Or if you want I will send something out in the morning.

Mark

On Thu, Sep 8, 2016 at 9:25 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Sep 8, 2016 at 6:18 PM, Huang, Jie (Jackie)
> <Jackie.Huang@windriver.com> wrote:
>>
>>
>>> -----Original Message-----
>>> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
>>> bounces@lists.openembedded.org] On Behalf Of Martin Jansa
>>> Sent: Thursday, September 08, 2016 4:40 PM
>>> To: openembedded-devel@lists.openembedded.org
>>> Subject: Re: [oe] [meta-networking][PATCH] waf-samba.bbclass: Append
>>> PACKAGECONFIG_CONFARGS to EXTRA_OECONF
>>>
>>> On Thu, Sep 08, 2016 at 01:10:48PM +0800, jackie.huang@windriver.com wrote:
>>> > From: Jackie Huang <jackie.huang@windriver.com>
>>> >
>>> > Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF for waf-samba.bbclass
>>> > because the PACKAGECONFIG will not be handled for all recipes after
>>> > the following commit in oe-core:
>>> >
>>> > commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
>>> > Author: Martin Jansa <martin.jansa@gmail.com>
>>> > Date:   Tue Aug 30 16:19:58 2016 +0200
>>> >
>>> >     base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in
>>> autotools.bbclass
>>> >
>>> >     * recipes which don't inherit autotools or cmake bbclass and want to
>>> >       use the configure options from PACKAGECONFIG need to handle
>>> >       PACKAGECONFIG_CONFARGS themselves.
>>> >
>>> >     Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>>> >     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>>> >
>>> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>>> > ---
>>> >  meta-networking/classes/waf-samba.bbclass | 2 ++
>>> >  1 file changed, 2 insertions(+)
>>> >
>>> > diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-
>>> samba.bbclass
>>> > index 772bc75..a58ca2c 100644
>>> > --- a/meta-networking/classes/waf-samba.bbclass
>>> > +++ b/meta-networking/classes/waf-samba.bbclass
>>> > @@ -20,6 +20,8 @@ CONFIGUREOPTS = " --prefix=${prefix} \
>>> >                    --mandir=${mandir} \
>>> >                  "
>>> >
>>> > +EXTRA_OECONF_append = " ${PACKAGECONFIG_CONFARGS}"
>>>
>>> Cannot we append it to CONFIGUREOPTS and remove EXTRA_OECONF from this
>>> bbclass completely?
>>
>> Yes, we can, but why do we need to remove EXTRA_OECONF from this bbclass
>> completely? Is it going to be deprecated?
>>
>> And I see that EXTRA_OECONF  is used in several recipes that inherit waf-samba,
>> If it's remove from the bbclass, it's should also be removed from those recipes, right?
>>
>
> EXTRA_OECONF is usually kept for recipe namespace.
>
>> Thanks,
>> Jackie
>>
>>>
>>> > +
>>> >  # Three methods for waf cross compile:
>>> >  # 1. answers:
>>> >  #    Only --cross-answers - try the cross-answers file, and if
>>> > --
>>> > 2.7.4
>>> >
>>> > --
>>> > _______________________________________________
>>> > Openembedded-devel mailing list
>>> > Openembedded-devel@lists.openembedded.org
>>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>> --
>>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF
  2016-09-09  1:44       ` Mark Asselstine
@ 2016-09-09  2:52         ` Huang, Jie (Jackie)
  0 siblings, 0 replies; 7+ messages in thread
From: Huang, Jie (Jackie) @ 2016-09-09  2:52 UTC (permalink / raw)
  To: Asselstine, Mark, openembedded-devel@lists.openembedded.org



> -----Original Message-----
> From: asselsm@gmail.com [mailto:asselsm@gmail.com] On Behalf Of Mark Asselstine
> Sent: Friday, September 09, 2016 9:45 AM
> To: openembedded-devel@lists.openembedded.org; Huang, Jie (Jackie)
> Subject: Re: [oe] [meta-networking][PATCH] waf-samba.bbclass: Append
> PACKAGECONFIG_CONFARGS to EXTRA_OECONF
> 
> Agreed. I was looking at this today as well and if we go the
> EXTRA_OECONF route it should be done in the package recipe.
> Additionally Jackie I was going to restrict the blacklist to ARM based
> on the build failure report
> (http://errors.yoctoproject.org/Errors/Details/81004/).
> 
> Could you include a patch for this, something like:

It's Included in v2 which is just sent.

Thanks,
Jackie

> 
> -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27"
> +BLACKLIST_REASON ?= ""
> +BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27"
> +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"
> 
> Or if you want I will send something out in the morning.
> 
> Mark
> 
> On Thu, Sep 8, 2016 at 9:25 PM, Khem Raj <raj.khem@gmail.com> wrote:
> > On Thu, Sep 8, 2016 at 6:18 PM, Huang, Jie (Jackie)
> > <Jackie.Huang@windriver.com> wrote:
> >>
> >>
> >>> -----Original Message-----
> >>> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
> >>> bounces@lists.openembedded.org] On Behalf Of Martin Jansa
> >>> Sent: Thursday, September 08, 2016 4:40 PM
> >>> To: openembedded-devel@lists.openembedded.org
> >>> Subject: Re: [oe] [meta-networking][PATCH] waf-samba.bbclass: Append
> >>> PACKAGECONFIG_CONFARGS to EXTRA_OECONF
> >>>
> >>> On Thu, Sep 08, 2016 at 01:10:48PM +0800, jackie.huang@windriver.com wrote:
> >>> > From: Jackie Huang <jackie.huang@windriver.com>
> >>> >
> >>> > Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF for waf-samba.bbclass
> >>> > because the PACKAGECONFIG will not be handled for all recipes after
> >>> > the following commit in oe-core:
> >>> >
> >>> > commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
> >>> > Author: Martin Jansa <martin.jansa@gmail.com>
> >>> > Date:   Tue Aug 30 16:19:58 2016 +0200
> >>> >
> >>> >     base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in
> >>> autotools.bbclass
> >>> >
> >>> >     * recipes which don't inherit autotools or cmake bbclass and want to
> >>> >       use the configure options from PACKAGECONFIG need to handle
> >>> >       PACKAGECONFIG_CONFARGS themselves.
> >>> >
> >>> >     Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >>> >     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> >>> >
> >>> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> >>> > ---
> >>> >  meta-networking/classes/waf-samba.bbclass | 2 ++
> >>> >  1 file changed, 2 insertions(+)
> >>> >
> >>> > diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-
> >>> samba.bbclass
> >>> > index 772bc75..a58ca2c 100644
> >>> > --- a/meta-networking/classes/waf-samba.bbclass
> >>> > +++ b/meta-networking/classes/waf-samba.bbclass
> >>> > @@ -20,6 +20,8 @@ CONFIGUREOPTS = " --prefix=${prefix} \
> >>> >                    --mandir=${mandir} \
> >>> >                  "
> >>> >
> >>> > +EXTRA_OECONF_append = " ${PACKAGECONFIG_CONFARGS}"
> >>>
> >>> Cannot we append it to CONFIGUREOPTS and remove EXTRA_OECONF from this
> >>> bbclass completely?
> >>
> >> Yes, we can, but why do we need to remove EXTRA_OECONF from this bbclass
> >> completely? Is it going to be deprecated?
> >>
> >> And I see that EXTRA_OECONF  is used in several recipes that inherit waf-samba,
> >> If it's remove from the bbclass, it's should also be removed from those recipes, right?
> >>
> >
> > EXTRA_OECONF is usually kept for recipe namespace.
> >
> >> Thanks,
> >> Jackie
> >>
> >>>
> >>> > +
> >>> >  # Three methods for waf cross compile:
> >>> >  # 1. answers:
> >>> >  #    Only --cross-answers - try the cross-answers file, and if
> >>> > --
> >>> > 2.7.4
> >>> >
> >>> > --
> >>> > _______________________________________________
> >>> > Openembedded-devel mailing list
> >>> > Openembedded-devel@lists.openembedded.org
> >>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>>
> >>> --
> >>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-09-09  2:52 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-08  5:10 [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF jackie.huang
2016-09-08  8:40 ` Martin Jansa
2016-09-09  1:18   ` Huang, Jie (Jackie)
2016-09-09  1:25     ` Khem Raj
2016-09-09  1:42       ` Huang, Jie (Jackie)
2016-09-09  1:44       ` Mark Asselstine
2016-09-09  2:52         ` Huang, Jie (Jackie)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.