From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support
Date: Thu, 8 Sep 2016 14:13:26 +0100 [thread overview]
Message-ID: <20160908131326.GE26570@leverpostej> (raw)
In-Reply-To: <1473069695-33092-4-git-send-email-shh.xie@gmail.com>
On Mon, Sep 05, 2016 at 06:01:31PM +0800, shh.xie at gmail.com wrote:
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu0: cpu at 0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a72";
> + reg = <0x0>;
> + clocks = <&clockgen 1 0>;
> + next-level-cache = <&l2>;
> + cpu-idle-states = <&CPU_PH20>;
> + };
[...]
> + };
> +
> + idle-states {
> + entry-method = "arm,psci";
> +
> + CPU_PH20: cpu-ph20 {
> + compatible = "arm,idle-state";
> + idle-state-name = "PH20";
> + arm,psci-suspend-param = <0x00010000>;
> + entry-latency-us = <1000>;
> + exit-latency-us = <1000>;
> + min-residency-us = <3000>;
> + };
> + };
There's no PSCI node in this file, and none from am included file, so
this doesn't look right.
> + pmu {
> + compatible = "arm,armv8-pmuv3";
> + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-affinity = <&cpu0>,
> + <&cpu1>,
> + <&cpu2>,
> + <&cpu3>;
> + };
The compatible string should be "arm,cortex-a72-pmu".
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: shh.xie@gmail.com
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will.deacon@arm.com, shawnguo@kernel.org,
linux-kernel@vger.kernel.org, arnd@arndb.de,
Mingkai Hu <Mingkai.Hu@nxp.com>,
Horia Geant? <horia.geanta@nxp.com>,
Mihai Bantea <mihai.bantea@nxp.com>,
Chenhui Zhao <chenhui.zhao@nxp.com>,
Gong Qianyu <Qianyu.Gong@nxp.com>,
Minghuan Lian <Minghuan.Lian@nxp.com>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Shaohui Xie <Shaohui.Xie@nxp.com>
Subject: Re: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support
Date: Thu, 8 Sep 2016 14:13:26 +0100 [thread overview]
Message-ID: <20160908131326.GE26570@leverpostej> (raw)
In-Reply-To: <1473069695-33092-4-git-send-email-shh.xie@gmail.com>
On Mon, Sep 05, 2016 at 06:01:31PM +0800, shh.xie@gmail.com wrote:
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu0: cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a72";
> + reg = <0x0>;
> + clocks = <&clockgen 1 0>;
> + next-level-cache = <&l2>;
> + cpu-idle-states = <&CPU_PH20>;
> + };
[...]
> + };
> +
> + idle-states {
> + entry-method = "arm,psci";
> +
> + CPU_PH20: cpu-ph20 {
> + compatible = "arm,idle-state";
> + idle-state-name = "PH20";
> + arm,psci-suspend-param = <0x00010000>;
> + entry-latency-us = <1000>;
> + exit-latency-us = <1000>;
> + min-residency-us = <3000>;
> + };
> + };
There's no PSCI node in this file, and none from am included file, so
this doesn't look right.
> + pmu {
> + compatible = "arm,armv8-pmuv3";
> + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-affinity = <&cpu0>,
> + <&cpu1>,
> + <&cpu2>,
> + <&cpu3>;
> + };
The compatible string should be "arm,cortex-a72-pmu".
Thanks,
Mark.
next prev parent reply other threads:[~2016-09-08 13:13 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 10:01 [PATCH 0/7] [v2] arm64: dts: add QorIQ LS1046A SoC and boards support shh.xie at gmail.com
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` [PATCH 1/7] [v2] dt-bindings: fsl: updates bindings for some SoC-specific devices shh.xie at gmail.com
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` shh.xie
2016-09-08 2:30 ` Shawn Guo
2016-09-08 2:30 ` Shawn Guo
2016-09-08 2:30 ` Shawn Guo
2016-09-08 10:57 ` S.H. Xie
2016-09-08 10:57 ` S.H. Xie
2016-09-08 10:57 ` S.H. Xie
2016-09-05 10:01 ` [PATCH 2/7] [v2] dt-bindings: i2c: adds two more nxp devices shh.xie at gmail.com
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` shh.xie
2016-09-12 16:33 ` Rob Herring
2016-09-12 16:33 ` Rob Herring
2016-09-12 16:33 ` Rob Herring
2016-09-05 10:01 ` [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support shh.xie at gmail.com
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` shh.xie
2016-09-08 13:05 ` Shawn Guo
2016-09-08 13:05 ` Shawn Guo
2016-09-09 6:46 ` S.H. Xie
2016-09-09 6:46 ` S.H. Xie
2016-09-09 6:46 ` S.H. Xie
2016-09-08 13:13 ` Mark Rutland [this message]
2016-09-08 13:13 ` Mark Rutland
2016-09-08 13:18 ` Mark Rutland
2016-09-08 13:18 ` Mark Rutland
2016-09-08 13:18 ` Mark Rutland
2016-09-09 6:55 ` S.H. Xie
2016-09-09 6:55 ` S.H. Xie
2016-09-09 6:55 ` S.H. Xie
2016-09-09 9:10 ` Mark Rutland
2016-09-09 9:10 ` Mark Rutland
2016-09-09 9:17 ` S.H. Xie
2016-09-09 9:17 ` S.H. Xie
2016-09-09 9:17 ` S.H. Xie
2016-09-09 6:48 ` S.H. Xie
2016-09-09 6:48 ` S.H. Xie
2016-09-09 6:48 ` S.H. Xie
2016-09-08 13:23 ` Marc Zyngier
2016-09-08 13:23 ` Marc Zyngier
2016-09-08 13:23 ` Marc Zyngier
2016-09-09 9:00 ` S.H. Xie
2016-09-09 9:00 ` S.H. Xie
2016-09-09 9:00 ` S.H. Xie
2016-09-05 10:01 ` [PATCH 4/7] [v2] Documentation: DT: Add entry for QorIQ LS1046A-RDB board shh.xie at gmail.com
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` [PATCH 5/7] [v2] arm64: dts: add LS1046A-RDB board support shh.xie at gmail.com
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` shh.xie
2016-09-08 13:12 ` Shawn Guo
2016-09-08 13:12 ` Shawn Guo
2016-09-09 6:44 ` S.H. Xie
2016-09-09 6:44 ` S.H. Xie
2016-09-09 6:44 ` S.H. Xie
2016-09-05 10:01 ` [PATCH 6/7] [v2] Documentation: DT: Add entry for QorIQ LS1046A-QDS board shh.xie at gmail.com
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` [PATCH 7/7] [v2] arm64: dts: add LS1046A-QDS board support shh.xie at gmail.com
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` shh.xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908131326.GE26570@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.