From: Flora Cui <flora.cui-5C7GfCeVMHo@public.gmane.org>
To: "Christian König" <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 2/2] drm/amdgpu: calc addr with domain's gpu_offset
Date: Fri, 9 Sep 2016 15:54:26 +0800 [thread overview]
Message-ID: <20160909075425.GA6834@flora> (raw)
In-Reply-To: <7b7de55b-a83c-618f-d91a-2174e850d521-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
what about commit e6eb9e1cdb740f778fbbacc5f62edd0ce97c2d52?
should the start addr get updated either?
On Fri, Sep 09, 2016 at 09:18:47AM +0200, Christian König wrote:
> NAK, that is clearly incorrect. The gpu_offset are MC addresses while the
> vram_base_offset is a bud address.
>
> Most of the time they are both zero, except for APUs which would break with
> this change.
>
> Regards,
> Christian.
>
> Am 09.09.2016 um 08:30 schrieb Flora Cui:
> >Change-Id: I8112e9d85866104559ecef7449f50fbb94167382
> >Signed-off-by: Flora Cui <Flora.Cui@amd.com>
> >---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> >index a549abd..3d7a3ab 100644
> >--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> >+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> >@@ -1151,7 +1151,7 @@ int amdgpu_vm_bo_update(struct amdgpu_device *adev,
> > break;
> > case TTM_PL_VRAM:
> >- addr += adev->vm_manager.vram_base_offset;
> >+ addr += bo_va->bo->tbo.bdev->man[mem->mem_type].gpu_offset;
> > break;
> > default:
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-09-09 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 6:30 [PATCH 1/2] drm/amdgpu: update gart_pin_size if bo is in GTT Flora Cui
[not found] ` <1473402651-2395-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>
2016-09-09 6:30 ` [PATCH 2/2] drm/amdgpu: calc addr with domain's gpu_offset Flora Cui
[not found] ` <1473402651-2395-2-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>
2016-09-09 6:40 ` 答复: " Qu, Jim
2016-09-09 7:18 ` Christian König
[not found] ` <7b7de55b-a83c-618f-d91a-2174e850d521-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-09-09 7:54 ` Flora Cui [this message]
2016-09-09 8:52 ` Christian König
2016-09-09 7:17 ` [PATCH 1/2] drm/amdgpu: update gart_pin_size if bo is in GTT Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909075425.GA6834@flora \
--to=flora.cui-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.