* [Buildroot] [PATCH] core: distclean is a noconfig target @ 2016-09-11 12:56 Yann E. MORIN 2016-09-11 13:34 ` Thomas Petazzoni 0 siblings, 1 reply; 4+ messages in thread From: Yann E. MORIN @ 2016-09-11 12:56 UTC (permalink / raw) To: buildroot When the .config contains invalid configuration *(e.g. two providers for a same virtual pacakge), it is not possible to run "make distclean" becasue the .config file is sourced and packages interpreted in this case. Add distclean to the noconfig list, so that we can run it in all cases. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index dfef021..f29f957 100644 --- a/Makefile +++ b/Makefile @@ -86,7 +86,7 @@ export BR2_VERSION_FULL := $(BR2_VERSION)$(shell $(TOPDIR)/support/scripts/setlo noconfig_targets := menuconfig nconfig gconfig xconfig config oldconfig randconfig \ defconfig %_defconfig allyesconfig allnoconfig silentoldconfig release \ randpackageconfig allyespackageconfig allnopackageconfig \ - print-version olddefconfig + print-version olddefconfig distclean # Some global targets do not trigger a build, but are used to collect # metadata, or do various checks. When such targets are triggered, -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] core: distclean is a noconfig target 2016-09-11 12:56 [Buildroot] [PATCH] core: distclean is a noconfig target Yann E. MORIN @ 2016-09-11 13:34 ` Thomas Petazzoni 2016-09-11 13:46 ` Yann E. MORIN 0 siblings, 1 reply; 4+ messages in thread From: Thomas Petazzoni @ 2016-09-11 13:34 UTC (permalink / raw) To: buildroot Hello, On Sun, 11 Sep 2016 14:56:38 +0200, Yann E. MORIN wrote: > When the .config contains invalid configuration *(e.g. two providers for > a same virtual pacakge), it is not possible to run "make distclean" pacakge -> package > @@ -86,7 +86,7 @@ export BR2_VERSION_FULL := $(BR2_VERSION)$(shell $(TOPDIR)/support/scripts/setlo > noconfig_targets := menuconfig nconfig gconfig xconfig config oldconfig randconfig \ > defconfig %_defconfig allyesconfig allnoconfig silentoldconfig release \ > randpackageconfig allyespackageconfig allnopackageconfig \ > - print-version olddefconfig > + print-version olddefconfig distclean The distclean target uses the DL_DIR variable, which is derived from BR2_DL_DIR, which can come from either the environment... or the configuration file. So, the BR2_DL_DIR from the configuration will be ignored. I'm not sure what the consequence is, but it's worth thinking about this. Also, what is the rationale for having just "distclean" and not "clean" in noconfig_targets ? The fact that "distclean" remove the configuration, and as such "helps" in solving configuration issues ? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] core: distclean is a noconfig target 2016-09-11 13:34 ` Thomas Petazzoni @ 2016-09-11 13:46 ` Yann E. MORIN 2016-09-11 20:44 ` Arnout Vandecappelle 0 siblings, 1 reply; 4+ messages in thread From: Yann E. MORIN @ 2016-09-11 13:46 UTC (permalink / raw) To: buildroot Thomas, All, On 2016-09-11 15:34 +0200, Thomas Petazzoni spake thusly: > On Sun, 11 Sep 2016 14:56:38 +0200, Yann E. MORIN wrote: > > @@ -86,7 +86,7 @@ export BR2_VERSION_FULL := $(BR2_VERSION)$(shell $(TOPDIR)/support/scripts/setlo > > noconfig_targets := menuconfig nconfig gconfig xconfig config oldconfig randconfig \ > > defconfig %_defconfig allyesconfig allnoconfig silentoldconfig release \ > > randpackageconfig allyespackageconfig allnopackageconfig \ > > - print-version olddefconfig > > + print-version olddefconfig distclean > > The distclean target uses the DL_DIR variable, which is derived from > BR2_DL_DIR, which can come from either the environment... or the > configuration file. So, the BR2_DL_DIR from the configuration will be > ignored. I'm not sure what the consequence is, but it's worth thinking > about this. Well, if either is set on not the default, then it is currently not removed. With this change, however, it is no longer removed, indeed. But, why are we even having this removal conditional? We can just unconditionally remove $(TOPDIR)/dl and be done with that, no? > Also, what is the rationale for having just "distclean" and not "clean" > in noconfig_targets ? The fact that "distclean" remove the > configuration, and as such "helps" in solving configuration issues ? Exactly. Otherwise one has to manually remove the .config file, which is not very nice... Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] core: distclean is a noconfig target 2016-09-11 13:46 ` Yann E. MORIN @ 2016-09-11 20:44 ` Arnout Vandecappelle 0 siblings, 0 replies; 4+ messages in thread From: Arnout Vandecappelle @ 2016-09-11 20:44 UTC (permalink / raw) To: buildroot On 11-09-16 15:46, Yann E. MORIN wrote: > Thomas, All, > > On 2016-09-11 15:34 +0200, Thomas Petazzoni spake thusly: >> On Sun, 11 Sep 2016 14:56:38 +0200, Yann E. MORIN wrote: >>> @@ -86,7 +86,7 @@ export BR2_VERSION_FULL := $(BR2_VERSION)$(shell $(TOPDIR)/support/scripts/setlo >>> noconfig_targets := menuconfig nconfig gconfig xconfig config oldconfig randconfig \ >>> defconfig %_defconfig allyesconfig allnoconfig silentoldconfig release \ >>> randpackageconfig allyespackageconfig allnopackageconfig \ >>> - print-version olddefconfig >>> + print-version olddefconfig distclean >> >> The distclean target uses the DL_DIR variable, which is derived from >> BR2_DL_DIR, which can come from either the environment... or the >> configuration file. So, the BR2_DL_DIR from the configuration will be >> ignored. I'm not sure what the consequence is, but it's worth thinking >> about this. With the small caveat that a BR2_DL_DIR specified in the environment *will* override the one of the .config, and that one will still be used even if .config is not read. I think, because there is still some twisted logic in pkg-download that I didn't analyze. > > Well, if either is set on not the default, then it is currently not > removed. > > With this change, however, it is no longer removed, indeed. > > But, why are we even having this removal conditional? We can just > unconditionally remove $(TOPDIR)/dl and be done with that, no? Seems OK to me. Regards, Arnout > >> Also, what is the rationale for having just "distclean" and not "clean" >> in noconfig_targets ? The fact that "distclean" remove the >> configuration, and as such "helps" in solving configuration issues ? > > Exactly. > > Otherwise one has to manually remove the .config file, which is not > very nice... > > Regards, > Yann E. MORIN. > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-11 20:44 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-11 12:56 [Buildroot] [PATCH] core: distclean is a noconfig target Yann E. MORIN 2016-09-11 13:34 ` Thomas Petazzoni 2016-09-11 13:46 ` Yann E. MORIN 2016-09-11 20:44 ` Arnout Vandecappelle
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.