From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org>
Cc: "moderated list:TPM DEVICE DRIVER"
<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] tpm: fix buffer overflow in /dev/tpm0
Date: Sun, 11 Sep 2016 21:57:37 +0300 [thread overview]
Message-ID: <20160911185737.GA13353@intel.com> (raw)
In-Reply-To: <20160911125142.GA20191-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Sun, Sep 11, 2016 at 03:51:42PM +0300, Jarkko Sakkinen wrote:
> On Sun, Sep 11, 2016 at 03:19:00PM +0300, Jarkko Sakkinen wrote:
> > tpm_write() does not check whether the buffer has at least enough space
> > for the header before passing it to tpm_transmit() so an overflow can
> > happen.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>
> This is usable neither as read nor write primitive for an exploit. Still
> it makes sense to validate the input here.
Cannot add fixes line for this one as it's from pre-GIT times...
/Jarkko
------------------------------------------------------------------------------
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: fix buffer overflow in /dev/tpm0
Date: Sun, 11 Sep 2016 21:57:37 +0300 [thread overview]
Message-ID: <20160911185737.GA13353@intel.com> (raw)
In-Reply-To: <20160911125142.GA20191@intel.com>
On Sun, Sep 11, 2016 at 03:51:42PM +0300, Jarkko Sakkinen wrote:
> On Sun, Sep 11, 2016 at 03:19:00PM +0300, Jarkko Sakkinen wrote:
> > tpm_write() does not check whether the buffer has at least enough space
> > for the header before passing it to tpm_transmit() so an overflow can
> > happen.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> This is usable neither as read nor write primitive for an exploit. Still
> it makes sense to validate the input here.
Cannot add fixes line for this one as it's from pre-GIT times...
/Jarkko
next prev parent reply other threads:[~2016-09-11 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 12:19 [PATCH] tpm: fix buffer overflow in /dev/tpm0 Jarkko Sakkinen
2016-09-11 12:19 ` Jarkko Sakkinen
2016-09-11 12:51 ` Jarkko Sakkinen
[not found] ` <20160911125142.GA20191-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-11 18:57 ` Jarkko Sakkinen [this message]
2016-09-11 18:57 ` Jarkko Sakkinen
[not found] ` <1473596340-11376-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-09-12 4:05 ` Jason Gunthorpe
2016-09-12 4:05 ` Jason Gunthorpe
[not found] ` <20160912040546.GA14625-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-12 7:50 ` Jarkko Sakkinen
2016-09-12 7:50 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160911185737.GA13353@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peterhuewe-Mmb7MZpHnFY@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.