Re: [oe-commits] [openembedded-core] 01/24: gnutls: update to 3.5.3

Re: [oe-commits] [openembedded-core] 01/24: gnutls: update to 3.5.3

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 4523 bytes --]

On Wed, Sep 07, 2016 at 11:37:44PM +0000, git@git.openembedded.org wrote:
> rpurdie pushed a commit to branch master
> in repository openembedded-core.
> 
> commit 972ab9246e4b5a0f46a4f2b5b1e54773beac11bb
> Author: Jussi Kukkonen <jussi.kukkonen@intel.com>
> AuthorDate: Wed Aug 31 11:50:03 2016 +0300
> 
>     gnutls: update to 3.5.3
>     
>     Add patch to fix compile without libtasn headers.
>     
>     (From OE-Core rev: b43e4499fb3bae4740660a729a900d951eab00e8)
>     
>     Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
>     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

This upgrade causes new QA issue:

ERROR: gnutls-3.5.3-r0 do_package_qa: QA Issue: ELF binary 'gnutls/3.5.3-r0/packages-split/gnutls/usr/lib/libgnutls.so.30.9.0' has relocations in .text [textrel]
ERROR: gnutls-3.5.3-r0 do_package_qa: QA Issue: ELF binary 'gnutls/3.5.3-r0/packages-split/gnutls/usr/lib/libgnutls.so.30.9.0' has relocations in .text [textrel]
ERROR: gnutls-3.5.3-r0 do_package_qa: QA run found fatal errors. Please consider fixing them.
ERROR: gnutls-3.5.3-r0 do_package_qa: Function failed: do_package_qa
ERROR: Logfile of failure stored in: gnutls/3.5.3-r0/temp/log.do_package_qa.33916
NOTE: recipe gnutls-3.5.3-r0: task do_package_qa: Failed
ERROR: Task (meta/recipes-support/gnutls/gnutls_3.5.3.bb:do_package_qa) failed with exit code '1'


> ---
>  ...001-Use-correct-include-dir-with-minitasn.patch | 31 ++++++++++++++++++++++
>  .../gnutls/{gnutls_3.5.1.bb => gnutls_3.5.3.bb}    |  5 ++--
>  2 files changed, 34 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-support/gnutls/gnutls/0001-Use-correct-include-dir-with-minitasn.patch b/meta/recipes-support/gnutls/gnutls/0001-Use-correct-include-dir-with-minitasn.patch
> new file mode 100644
> index 0000000..d7dd7cf
> --- /dev/null
> +++ b/meta/recipes-support/gnutls/gnutls/0001-Use-correct-include-dir-with-minitasn.patch
> @@ -0,0 +1,31 @@
> +From 2651b08477f42dd7a05ea7d6df410fb2c46de4fb Mon Sep 17 00:00:00 2001
> +From: Jussi Kukkonen <jussi.kukkonen@intel.com>
> +Date: Wed, 31 Aug 2016 11:04:06 +0300
> +Subject: [PATCH] Use correct include dir with minitasn
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +This allows compiling certtool-cfg without libtasn headers.
> +
> +Upstream-Status: Submitted [https://gitlab.com/gnutls/gnutls/merge_requests/54]
> +Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
> +---
> + src/Makefile.am | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/src/Makefile.am b/src/Makefile.am
> +index 182f3a5..cf65388 100644
> +--- a/src/Makefile.am
> ++++ b/src/Makefile.am
> +@@ -146,6 +146,7 @@ libcmd_cli_debug_la_SOURCES = cli-debug-args.def cli-debug-args.c cli-debug-args
> + COMMON_LIBS = $(LIBOPTS) $(LTLIBINTL)
> + if ENABLE_MINITASN1
> + COMMON_LIBS += ../lib/minitasn1/libminitasn1.la ../gl/libgnu.la 
> ++AM_CPPFLAGS += -I$(top_srcdir)/lib/minitasn1
> + else
> + COMMON_LIBS += $(LIBTASN1_LIBS)
> + endif
> +-- 
> +2.9.3
> +
> diff --git a/meta/recipes-support/gnutls/gnutls_3.5.1.bb b/meta/recipes-support/gnutls/gnutls_3.5.3.bb
> similarity index 50%
> rename from meta/recipes-support/gnutls/gnutls_3.5.1.bb
> rename to meta/recipes-support/gnutls/gnutls_3.5.3.bb
> index 85d9904..1bdca6a 100644
> --- a/meta/recipes-support/gnutls/gnutls_3.5.1.bb
> +++ b/meta/recipes-support/gnutls/gnutls_3.5.3.bb
> @@ -3,6 +3,7 @@ require gnutls.inc
>  SRC_URI += "file://correct_rpl_gettimeofday_signature.patch \
>              file://0001-configure.ac-fix-sed-command.patch \
>              file://use-pkg-config-to-locate-zlib.patch \
> +            file://0001-Use-correct-include-dir-with-minitasn.patch \
>             "
> -SRC_URI[md5sum] = "cb48bb0cf36d329f7321c6cdc0d7ae36"
> -SRC_URI[sha256sum] = "bc4a0f80a627c3aca6e7ea59d30e50cda118c61e0e3fab367ff1451d6ec8bdbd"
> +SRC_URI[md5sum] = "6c2c7f40ddf52933ee3ca474cb8cb63c"
> +SRC_URI[sha256sum] = "92c4bc999a10a1b95299ebefaeea8333f19d8a98d957a35b5eae74881bdb1fef"
> 
> -- 
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> -- 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 169 bytes --]

Re: [oe-commits] [openembedded-core] 01/24: gnutls: update to 3.5.3

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

On 11 September 2016 at 20:37, Martin Jansa <martin.jansa@gmail.com> wrote:

> ERROR: gnutls-3.5.3-r0 do_package_qa: QA Issue: ELF binary
> 'gnutls/3.5.3-r0/packages-split/gnutls/usr/lib/libgnutls.so.30.9.0' has
> relocations in .text [textrel]
>

None of my builds have done this, what machine/tunes/anything else relevant
is this on?

Ross

[-- Attachment #2: Type: text/html, Size: 772 bytes --]

Re: [oe-commits] [openembedded-core] 01/24: gnutls: update to 3.5.3

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Default qemux86 as shown in:
http://logs.nslu2-linux.org/buildlogs/oe/world/log.report.20160910_205641.log

On Mon, Sep 12, 2016 at 12:31 AM, Burton, Ross <ross.burton@intel.com>
wrote:

>
> On 11 September 2016 at 20:37, Martin Jansa <martin.jansa@gmail.com>
> wrote:
>
>> ERROR: gnutls-3.5.3-r0 do_package_qa: QA Issue: ELF binary
>> 'gnutls/3.5.3-r0/packages-split/gnutls/usr/lib/libgnutls.so.30.9.0' has
>> relocations in .text [textrel]
>>
>
> None of my builds have done this, what machine/tunes/anything else
> relevant is this on?
>
> Ross
>

[-- Attachment #2: Type: text/html, Size: 1395 bytes --]

Re: [oe-commits] [openembedded-core] 01/24: gnutls: update to 3.5.3

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

On 11 September 2016 at 23:37, Martin Jansa <martin.jansa@gmail.com> wrote:

> Default qemux86 as shown in:
> http://logs.nslu2-linux.org/buildlogs/oe/world/log.report.
> 20160910_205641.log
>

Yeah I can replicate this, must be a 32-bit x86 thing, or something.
Annoying.

Ross

[-- Attachment #2: Type: text/html, Size: 773 bytes --]

Re: [oe-commits] [openembedded-core] 01/24: gnutls: update to 3.5.3

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

On 12 September 2016 at 20:43, Burton, Ross <ross.burton@intel.com> wrote:

>
> On 11 September 2016 at 23:37, Martin Jansa <martin.jansa@gmail.com>
> wrote:
>
>> Default qemux86 as shown in:
>> http://logs.nslu2-linux.org/buildlogs/oe/world/log.report.20
>> 160910_205641.log
>>
>
> Yeah I can replicate this, must be a 32-bit x86 thing, or something.
> Annoying.
>


The good news: Upstream just fixed this today.
The bad news: The fix is a 7000 line asm patch.



It's a revert to some earlier code so not _quite_ that scary... but we
don't have ptests for gnutls and reviewing that patch is plain impossible.
I guess I'll do some manual tests and send the patch in any case?


- Jussi

[-- Attachment #2: Type: text/html, Size: 1613 bytes --]

Re: [oe-commits] [openembedded-core] 01/24: gnutls: update to 3.5.3

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

On 13 September 2016 at 14:04, Jussi Kukkonen <jussi.kukkonen@intel.com>
wrote:

> The good news: Upstream just fixed this today.
> The bad news: The fix is a 7000 line asm patch.
>
>
>
> It's a revert to some earlier code so not _quite_ that scary... but we
> don't have ptests for gnutls and reviewing that patch is plain impossible.
> I guess I'll do some manual tests and send the patch in any case?
>

Or just sent an INSANE_SKIP for now as the next release will incorporate
the fix?

Ross

[-- Attachment #2: Type: text/html, Size: 918 bytes --]