All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] arm64: dts: Add ZTE ZX296718 SoC dts and Makefile
Date: Mon, 12 Sep 2016 20:18:00 +0800	[thread overview]
Message-ID: <20160912121800.GB7373@tiger> (raw)
In-Reply-To: <20160909115336.GB16924@tiger>

On Fri, Sep 09, 2016 at 07:53:36PM +0800, Shawn Guo wrote:
> A bit more comments as below ...
> 
> On Tue, Sep 06, 2016 at 02:04:20PM +0800, Jun Nie wrote:
> > +	soc {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		compatible = "simple-bus";
> > +		interrupt-parent = <&gic>;
> > +		ranges;
> > +
> > +		timer {
> > +			compatible = "arm,armv8-timer";
> > +			interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
> > +				     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
> > +				     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
> > +				     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
> 
> Affinity bits are missing for PPI interrupt.  You can use a bit help
> from defines in include/dt-bindings/interrupt-controller/arm-gic.h.

Sorry, I missed the fact that affinity bits is only required for gic-v2,
while what we have here is a gic-v3.  So please ignore the comment.

Shawn

  reply	other threads:[~2016-09-12 12:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06  6:04 [PATCH v4 0/3] Add ZTE ZX296718 support Jun Nie
2016-09-06  6:04 ` [PATCH v4 1/3] arm64: add ZTE ZX SoC family Jun Nie
2016-09-06  6:04 ` [PATCH v4 2/3] arm64: dts: Add ZTE ZX296718 SoC dts and Makefile Jun Nie
2016-09-08  9:11   ` Shawn Guo
2016-09-12  7:13     ` Jun Nie
2016-09-12 12:14       ` Shawn Guo
2016-09-09 11:53   ` Shawn Guo
2016-09-12 12:18     ` Shawn Guo [this message]
2016-09-06  6:04 ` [PATCH v4 3/3] arm64: defconfig: enable ZTE ZX related config Jun Nie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160912121800.GB7373@tiger \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.