Re: [Outreachy kernel] [PATCH] staging: comedi: comedidev: Fixes CamelCase issue

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Greg KH <gregkh@linuxfoundation.org>
To: Namrata A Shettar <namrataashettar@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: comedi: comedidev: Fixes CamelCase issue
Date: Mon, 12 Sep 2016 19:06:05 +0200	[thread overview]
Message-ID: <20160912170605.GA26392@kroah.com> (raw)
In-Reply-To: <CAFrQyDEvVL_XEL3DtCn9npXa8H+Jxaixv7nVEzY2Sx8ROCD+RA@mail.gmail.com>

On Mon, Sep 12, 2016 at 09:37:38PM +0530, Namrata A Shettar wrote:
> This patch fixes the checkpatch.pl issue:
> -Avoid CamelCase
> 
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> ï¿½drivers/staging/comedi/comedidev.h | 8 ++++----
> ï¿½1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comed
> idev.h
> index dcb6376..9d941b1 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -582,7 +582,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
> 
> ï¿½#define RANGE(a, b)ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ {(a) * 1e6, (b) * 1e6, 0}
> ï¿½#define RANGE_ext(a, b)ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> -#define RANGE_mA(a, b)ï¿½ ï¿½ ï¿½ ï¿½ ï¿½{(a) * 1e6, (b) * 1e6, UNIT_mA}
> +#define RANGE_ma(a, b)ï¿½ ï¿½ ï¿½ ï¿½ ï¿½{(a) * 1e6, (b) * 1e6, UNIT_ma}

Look at what you changed, it really should stay as-is, don't you think?

Remember, checkpatch is a hint, it's not smart at all.

thanks,

greg k-h

next prev parent reply	other threads:[~2016-09-12 17:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 16:07 [PATCH] staging: comedi: comedidev: Fixes CamelCase issue Namrata A Shettar
2016-09-12 16:20 ` [Outreachy kernel] " Julia Lawall
2016-09-12 16:49 ` Namrata A Shettar
2016-09-12 16:50   ` [Outreachy kernel] " Julia Lawall
2016-09-12 17:06 ` Greg KH [this message]
2016-09-12 18:38 ` Namrata A Shettar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160912170605.GA26392@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=namrataashettar@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.