* Re: [Outreachy kernel] [PATCH] staging: comedi: comedidev: Fixes CamelCase issue
2016-09-12 16:07 [PATCH] staging: comedi: comedidev: Fixes CamelCase issue Namrata A Shettar
@ 2016-09-12 16:20 ` Julia Lawall
2016-09-12 16:49 ` Namrata A Shettar
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-09-12 16:20 UTC (permalink / raw)
To: Namrata A Shettar; +Cc: outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2699 bytes --]
On Mon, 12 Sep 2016, Namrata A Shettar wrote:
> This patch fixes the checkpatch.pl issue:
> -Avoid CamelCase
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h
> b/drivers/staging/comedi/comedidev.h
> index dcb6376..9d941b1 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -582,7 +582,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
>
> #define RANGE(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> -#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_mA}
> +#define RANGE_ma(a, b) {(a) * 1e6, (b) * 1e6, UNIT_ma}
Does this compile? The old code was referring to UNIT_mA and the new code
is referring to UNIT_ma, but there doesn't seem to be a redefinition of
UNIT_mA anywhere.
Also, I'm not sure what mA means, but it looks like it could be something
that has a technical meaning in the context of the driver. It doesn't
look like an ordinary instance of camel case, where an identifier would be
written likeThis.
julia
> #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define BIP_RANGE(a) {-(a) * 1e6, (a) * 1e6, 0}
> #define UNI_RANGE(a) {0, (a) * 1e6, 0}
> @@ -593,9 +593,9 @@ extern const struct comedi_lrange range_bipolar2_5;
> extern const struct comedi_lrange range_unipolar10;
> extern const struct comedi_lrange range_unipolar5;
> extern const struct comedi_lrange range_unipolar2_5;
> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;
> extern const struct comedi_lrange range_unknown;
>
> #define range_digital range_unipolar5
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDEvVL_XEL3DtCn9npX
> a8H%2BJxaixv7nVEzY2Sx8ROCD%2BRA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: comedi: comedidev: Fixes CamelCase issue
2016-09-12 16:07 [PATCH] staging: comedi: comedidev: Fixes CamelCase issue Namrata A Shettar
2016-09-12 16:20 ` [Outreachy kernel] " Julia Lawall
@ 2016-09-12 16:49 ` Namrata A Shettar
2016-09-12 16:50 ` [Outreachy kernel] " Julia Lawall
2016-09-12 17:06 ` [Outreachy kernel] " Greg KH
2016-09-12 18:38 ` Namrata A Shettar
3 siblings, 1 reply; 6+ messages in thread
From: Namrata A Shettar @ 2016-09-12 16:49 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1974 bytes --]
It did compile when I tried.
Thanks for pointing that out. Also, mA stands for the physical unit of
current milli-Amperes.I realize that it's not a good idea to change the
notation for a physical unit.
Sorry for that,will be more careful the next time :)
On Monday, September 12, 2016 at 9:38:14 PM UTC+5:30, Namrata A Shettar
wrote:
>
> This patch fixes the checkpatch.pl issue:
> -Avoid CamelCase
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h
> b/drivers/staging/comedi/comedidev.h
> index dcb6376..9d941b1 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -582,7 +582,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
>
> #define RANGE(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> -#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_mA}
> +#define RANGE_ma(a, b) {(a) * 1e6, (b) * 1e6, UNIT_ma}
> #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define BIP_RANGE(a) {-(a) * 1e6, (a) * 1e6, 0}
> #define UNI_RANGE(a) {0, (a) * 1e6, 0}
> @@ -593,9 +593,9 @@ extern const struct comedi_lrange range_bipolar2_5;
> extern const struct comedi_lrange range_unipolar10;
> extern const struct comedi_lrange range_unipolar5;
> extern const struct comedi_lrange range_unipolar2_5;
> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;
> extern const struct comedi_lrange range_unknown;
>
> #define range_digital range_unipolar5
> --
> 2.7.4
>
[-- Attachment #1.2: Type: text/html, Size: 2991 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Outreachy kernel] Re: [PATCH] staging: comedi: comedidev: Fixes CamelCase issue
2016-09-12 16:49 ` Namrata A Shettar
@ 2016-09-12 16:50 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-09-12 16:50 UTC (permalink / raw)
To: Namrata A Shettar; +Cc: outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2949 bytes --]
On Mon, 12 Sep 2016, Namrata A Shettar wrote:
> It did compile when I tried.
OK, it's a macro. It is possible that the macro is not used in the code
that gets compiled.
julia
> Thanks for pointing that out. Also, mA stands for the physical unit of
> current milli-Amperes.I realize that it's not a good idea to change the
> notation for a physical unit.
> Sorry for that,will be more careful the next time :)
>
> On Monday, September 12, 2016 at 9:38:14 PM UTC+5:30, Namrata A Shettar
> wrote:
> This patch fixes the checkpatch.pl issue:
> -Avoid CamelCase
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h
> b/drivers/staging/comedi/comedidev.h
> index dcb6376..9d941b1 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -582,7 +582,7 @@ int comedi_check_chanlist(struct
> comedi_subdevice *s,
>
> #define RANGE(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6,
> RF_EXTERNAL}
> -#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_mA}
> +#define RANGE_ma(a, b) {(a) * 1e6, (b) * 1e6, UNIT_ma}
> #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define BIP_RANGE(a) {-(a) * 1e6, (a) * 1e6, 0}
> #define UNI_RANGE(a) {0, (a) * 1e6, 0}
> @@ -593,9 +593,9 @@ extern const struct comedi_lrange
> range_bipolar2_5;
> extern const struct comedi_lrange range_unipolar10;
> extern const struct comedi_lrange range_unipolar5;
> extern const struct comedi_lrange range_unipolar2_5;
> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;
> extern const struct comedi_lrange range_unknown;
>
> #define range_digital range_unipolar5
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/aaed82ca-fe9f-4682-952b-
> d0d8d1c8317d%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: comedi: comedidev: Fixes CamelCase issue
2016-09-12 16:07 [PATCH] staging: comedi: comedidev: Fixes CamelCase issue Namrata A Shettar
2016-09-12 16:20 ` [Outreachy kernel] " Julia Lawall
2016-09-12 16:49 ` Namrata A Shettar
@ 2016-09-12 17:06 ` Greg KH
2016-09-12 18:38 ` Namrata A Shettar
3 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2016-09-12 17:06 UTC (permalink / raw)
To: Namrata A Shettar; +Cc: outreachy-kernel
On Mon, Sep 12, 2016 at 09:37:38PM +0530, Namrata A Shettar wrote:
> This patch fixes the checkpatch.pl issue:
> -Avoid CamelCase
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> �drivers/staging/comedi/comedidev.h | 8 ++++----
> �1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comed
> idev.h
> index dcb6376..9d941b1 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -582,7 +582,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
>
> �#define RANGE(a, b)� � � � � � {(a) * 1e6, (b) * 1e6, 0}
> �#define RANGE_ext(a, b)� � � � � � � � {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> -#define RANGE_mA(a, b)� � � � �{(a) * 1e6, (b) * 1e6, UNIT_mA}
> +#define RANGE_ma(a, b)� � � � �{(a) * 1e6, (b) * 1e6, UNIT_ma}
Look at what you changed, it really should stay as-is, don't you think?
Remember, checkpatch is a hint, it's not smart at all.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: comedi: comedidev: Fixes CamelCase issue
2016-09-12 16:07 [PATCH] staging: comedi: comedidev: Fixes CamelCase issue Namrata A Shettar
` (2 preceding siblings ...)
2016-09-12 17:06 ` [Outreachy kernel] " Greg KH
@ 2016-09-12 18:38 ` Namrata A Shettar
3 siblings, 0 replies; 6+ messages in thread
From: Namrata A Shettar @ 2016-09-12 18:38 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1799 bytes --]
Yes,will keep that in mind the next time I am making such a change.
Thanks,
Namrata
On Monday, September 12, 2016 at 9:38:14 PM UTC+5:30, Namrata A Shettar
wrote:
>
> This patch fixes the checkpatch.pl issue:
> -Avoid CamelCase
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h
> b/drivers/staging/comedi/comedidev.h
> index dcb6376..9d941b1 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -582,7 +582,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
>
> #define RANGE(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> -#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_mA}
> +#define RANGE_ma(a, b) {(a) * 1e6, (b) * 1e6, UNIT_ma}
> #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define BIP_RANGE(a) {-(a) * 1e6, (a) * 1e6, 0}
> #define UNI_RANGE(a) {0, (a) * 1e6, 0}
> @@ -593,9 +593,9 @@ extern const struct comedi_lrange range_bipolar2_5;
> extern const struct comedi_lrange range_unipolar10;
> extern const struct comedi_lrange range_unipolar5;
> extern const struct comedi_lrange range_unipolar2_5;
> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;
> extern const struct comedi_lrange range_unknown;
>
> #define range_digital range_unipolar5
> --
> 2.7.4
>
[-- Attachment #1.2: Type: text/html, Size: 2814 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread