All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Jarkko Sakkinen
	<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: "moderated list:TPM DEVICE DRIVER"
	<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] tpm: tpm_transmit() does not check for minimum buffer size.
Date: Mon, 12 Sep 2016 11:32:19 -0600	[thread overview]
Message-ID: <20160912173219.GA5843@obsidianresearch.com> (raw)
In-Reply-To: <1473677010-13737-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

On Mon, Sep 12, 2016 at 01:43:30PM +0300, Jarkko Sakkinen wrote:
> tpm_transmit() does not check that bufsiz is at least TPM_HEADER_SIZE
> before accessing data. This commit adds the check and returns -ENOMEM.

-EINVAL

> v2: Updated commit msg

After the diffstat, do not commit that to the tree

Jason

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
	Marcel Selhorst <tpmdd@selhorst.net>,
	"moderated list:TPM DEVICE DRIVER" 
	<tpmdd-devel@lists.sourceforge.net>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] tpm: tpm_transmit() does not check for minimum buffer size.
Date: Mon, 12 Sep 2016 11:32:19 -0600	[thread overview]
Message-ID: <20160912173219.GA5843@obsidianresearch.com> (raw)
In-Reply-To: <1473677010-13737-1-git-send-email-jarkko.sakkinen@linux.intel.com>

On Mon, Sep 12, 2016 at 01:43:30PM +0300, Jarkko Sakkinen wrote:
> tpm_transmit() does not check that bufsiz is at least TPM_HEADER_SIZE
> before accessing data. This commit adds the check and returns -ENOMEM.

-EINVAL

> v2: Updated commit msg

After the diffstat, do not commit that to the tree

Jason

  parent reply	other threads:[~2016-09-12 17:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 10:43 [PATCH v2] tpm: tpm_transmit() does not check for minimum buffer size Jarkko Sakkinen
2016-09-12 10:43 ` Jarkko Sakkinen
     [not found] ` <1473677010-13737-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-09-12 17:32   ` Jason Gunthorpe [this message]
2016-09-12 17:32     ` Jason Gunthorpe
     [not found]     ` <20160912173219.GA5843-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-12 20:16       ` Jarkko Sakkinen
2016-09-12 20:16         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160912173219.GA5843@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.