* [PATCH] Staging: bus: Space required before the open parenthesis '('.
@ 2016-09-12 19:56 Sandhya Bankar
2016-09-13 4:11 ` [Outreachy kernel] " Vaishali Thakkar
0 siblings, 1 reply; 2+ messages in thread
From: Sandhya Bankar @ 2016-09-12 19:56 UTC (permalink / raw)
To: outreachy-kernel
Space required before the open parenthesis '('.This patch is found by checkpatch.pl script.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/bus/arm-cci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index 9e1020f..99513f7 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -2271,7 +2271,7 @@ static int cci_probe(void)
struct resource res;
np = of_find_matching_node(NULL, arm_cci_matches);
- if(!np || !of_device_is_available(np))
+ if (!np || !of_device_is_available(np))
return -ENODEV;
ret = of_address_to_resource(np, 0, &res);
--
1.8.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: bus: Space required before the open parenthesis '('.
2016-09-12 19:56 [PATCH] Staging: bus: Space required before the open parenthesis '(' Sandhya Bankar
@ 2016-09-13 4:11 ` Vaishali Thakkar
0 siblings, 0 replies; 2+ messages in thread
From: Vaishali Thakkar @ 2016-09-13 4:11 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel
On Tue, Sep 13, 2016 at 1:26 AM, Sandhya Bankar
<bankarsandhya512@gmail.com> wrote:
> Space required before the open parenthesis '('.This patch is found by checkpatch.pl script.
Commit log contains more than 80 characters in the single line. Usually we
follow 80 characters rule for the commit log, subject as well.
Normally is useful to run checkpatch.pl on your patch. You can do that with
following command after creating patch:
scripts/checkpatch.pl <file.patch>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/bus/arm-cci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index 9e1020f..99513f7 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -2271,7 +2271,7 @@ static int cci_probe(void)
> struct resource res;
>
> np = of_find_matching_node(NULL, arm_cci_matches);
> - if(!np || !of_device_is_available(np))
> + if (!np || !of_device_is_available(np))
> return -ENODEV;
>
> ret = of_address_to_resource(np, 0, &res);
> --
> 1.8.2.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160912195642.GA2775%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
--
Vaishali
http://vaishalithakkar.in/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-13 4:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-12 19:56 [PATCH] Staging: bus: Space required before the open parenthesis '(' Sandhya Bankar
2016-09-13 4:11 ` [Outreachy kernel] " Vaishali Thakkar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.