All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: speakup: Spaces preferred around operator.
@ 2016-09-12 21:11 Sandhya Bankar
  2016-09-12 21:16 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Sandhya Bankar @ 2016-09-12 21:11 UTC (permalink / raw)
  To: outreachy-kernel

Spaces preferred around operator.This issue is found by checkpatch.pl

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/speakup/selection.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/selection.c b/drivers/staging/speakup/selection.c
index 0149edc..ce4b946 100644
--- a/drivers/staging/speakup/selection.c
+++ b/drivers/staging/speakup/selection.c
@@ -99,7 +99,7 @@ int speakup_set_selection(struct tty_struct *tty)
 	sel_start = new_sel_start;
 	sel_end = new_sel_end;
 	/* Allocate a new buffer before freeing the old one ... */
-	bp = kmalloc((sel_end-sel_start)/2+1, GFP_ATOMIC);
+	bp = kmalloc((sel_end - sel_start) / 2 + 1, GFP_ATOMIC);
 	if (!bp) {
 		speakup_clear_selection();
 		return -ENOMEM;
-- 
1.8.2.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: speakup: Spaces preferred around operator.
  2016-09-12 21:11 [PATCH] Staging: speakup: Spaces preferred around operator Sandhya Bankar
@ 2016-09-12 21:16 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-12 21:16 UTC (permalink / raw)
  To: Sandhya Bankar; +Cc: outreachy-kernel



On Tue, 13 Sep 2016, Sandhya Bankar wrote:

> Spaces preferred around operator.This issue is found by checkpatch.pl

There should be a space after the . after operator.

Is Greg the only maintainer for this?

julia

>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/speakup/selection.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/selection.c b/drivers/staging/speakup/selection.c
> index 0149edc..ce4b946 100644
> --- a/drivers/staging/speakup/selection.c
> +++ b/drivers/staging/speakup/selection.c
> @@ -99,7 +99,7 @@ int speakup_set_selection(struct tty_struct *tty)
>  	sel_start = new_sel_start;
>  	sel_end = new_sel_end;
>  	/* Allocate a new buffer before freeing the old one ... */
> -	bp = kmalloc((sel_end-sel_start)/2+1, GFP_ATOMIC);
> +	bp = kmalloc((sel_end - sel_start) / 2 + 1, GFP_ATOMIC);
>  	if (!bp) {
>  		speakup_clear_selection();
>  		return -ENOMEM;
> --
> 1.8.2.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160912211129.GA3309%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-12 21:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-12 21:11 [PATCH] Staging: speakup: Spaces preferred around operator Sandhya Bankar
2016-09-12 21:16 ` [Outreachy kernel] " Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.