All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: speackup: No space is necessary after a cast.
@ 2016-09-12 21:20 Sandhya Bankar
  2016-09-12 21:28 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Sandhya Bankar @ 2016-09-12 21:20 UTC (permalink / raw)
  To: outreachy-kernel

No space is necessary after a cast.This patch is detected by checkpatch.pl script.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/speakup/selection.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/selection.c b/drivers/staging/speakup/selection.c
index ce4b946..afd9a44 100644
--- a/drivers/staging/speakup/selection.c
+++ b/drivers/staging/speakup/selection.c
@@ -137,7 +137,7 @@ static void __speakup_paste_selection(struct work_struct *work)
 	struct speakup_paste_work *spw =
 		container_of(work, struct speakup_paste_work, work);
 	struct tty_struct *tty = xchg(&spw->tty, NULL);
-	struct vc_data *vc = (struct vc_data *) tty->driver_data;
+	struct vc_data *vc = (struct vc_data *)tty->driver_data;
 	int pasted = 0, count;
 	struct tty_ldisc *ld;
 	DECLARE_WAITQUEUE(wait, current);
-- 
1.8.2.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: speackup: No space is necessary after a cast.
  2016-09-12 21:20 [PATCH] Staging: speackup: No space is necessary after a cast Sandhya Bankar
@ 2016-09-12 21:28 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-12 21:28 UTC (permalink / raw)
  To: Sandhya Bankar; +Cc: outreachy-kernel



On Tue, 13 Sep 2016, Sandhya Bankar wrote:

> No space is necessary after a cast.This patch is detected by checkpatch.pl script.

Space needed after "cast." In the subject line, speackup -> speakup.  The
commit message should be limited to 80 characters per line.  Did you send
another patch on the same file?  If so, then they need to be in a series
(1/2, 2/2).

julia


>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/speakup/selection.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/selection.c b/drivers/staging/speakup/selection.c
> index ce4b946..afd9a44 100644
> --- a/drivers/staging/speakup/selection.c
> +++ b/drivers/staging/speakup/selection.c
> @@ -137,7 +137,7 @@ static void __speakup_paste_selection(struct work_struct *work)
>  	struct speakup_paste_work *spw =
>  		container_of(work, struct speakup_paste_work, work);
>  	struct tty_struct *tty = xchg(&spw->tty, NULL);
> -	struct vc_data *vc = (struct vc_data *) tty->driver_data;
> +	struct vc_data *vc = (struct vc_data *)tty->driver_data;
>  	int pasted = 0, count;
>  	struct tty_ldisc *ld;
>  	DECLARE_WAITQUEUE(wait, current);
> --
> 1.8.2.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160912212009.GA3355%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-12 21:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-12 21:20 [PATCH] Staging: speackup: No space is necessary after a cast Sandhya Bankar
2016-09-12 21:28 ` [Outreachy kernel] " Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.