All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Alasdair Kergon <agk@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	linux-kernel@vger.kernel.org, dm-devel@redhat.com,
	Joe Thornber <ejt@redhat.com>
Subject: Re: [RFC][PATCH] dm: Remove dm_bufio_cond_resched()
Date: Tue, 13 Sep 2016 09:39:59 -0400	[thread overview]
Message-ID: <20160913133959.GA22833@redhat.com> (raw)
In-Reply-To: <20160913084520.GA5012@twins.programming.kicks-ass.net>

On Tue, Sep 13 2016 at  4:45am -0400,
Peter Zijlstra <peterz@infradead.org> wrote:

> Hi all,
> 
> While grepping for PREEMPT_VOLUNTARY I ran into dm_bufio_cond_resched()
> and wondered WTH it was about.
> 
> Is there anything wrong with the below patch?

No, I'll pick it up for 4.9 merge.  Mikulas added it for sparc or
something.  I cannot recall _the_ reason (I wasn't maintaining DM back
then) but at the time both Alasdair and Joe Thornber reasoned that it
needed to go -- and that if it was really needed that it should be done
in terms of a proper patch to sched.h, etc.

So I'm not sure how this dm-bufio local cond_resched() wrapper still got
in... happy to take your patch.

Please respond with whatever SOB you'd like applied to the patch header.

Thanks,
Mike

  parent reply	other threads:[~2016-09-13 13:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13  8:45 [RFC][PATCH] dm: Remove dm_bufio_cond_resched() Peter Zijlstra
2016-09-13 12:49 ` Thomas Gleixner
2016-09-13 13:39 ` Mike Snitzer [this message]
2016-09-19 10:53   ` Peter Zijlstra
2016-09-22 20:53     ` Mikulas Patocka
2016-09-22 20:59       ` Thomas Gleixner
2016-09-23  7:34         ` Peter Zijlstra
2016-09-23  8:00           ` Thomas Gleixner
2016-09-23  9:05             ` Peter Zijlstra
2016-09-23  9:13               ` Thomas Gleixner
2016-09-23  9:26                 ` Ingo Molnar
2016-09-23 12:17             ` Mike Galbraith
2016-09-23 12:26               ` Peter Zijlstra
2016-09-23 12:39                 ` Mike Galbraith
2016-09-23 12:42                 ` Mike Snitzer
2016-09-23 12:46                   ` Peter Zijlstra
2016-09-23 14:32           ` [dm-devel] " Bart Van Assche
2016-09-23 14:32             ` Bart Van Assche
2016-09-19  9:49 ` Mikulas Patocka
2016-09-19 10:47   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160913133959.GA22833@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=ejt@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.