From: Mike Snitzer <snitzer@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mikulas Patocka <mpatocka@redhat.com>,
Alasdair Kergon <agk@redhat.com>, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com,
Joe Thornber <ejt@redhat.com>
Subject: Re: [RFC][PATCH] dm: Remove dm_bufio_cond_resched()
Date: Fri, 23 Sep 2016 08:42:51 -0400 [thread overview]
Message-ID: <20160923124251.GA22428@redhat.com> (raw)
In-Reply-To: <20160923122607.GK5008@twins.programming.kicks-ass.net>
On Fri, Sep 23 2016 at 8:26am -0400,
Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Sep 23, 2016 at 02:17:10PM +0200, Mike Galbraith wrote:
> > On Fri, 2016-09-23 at 10:00 +0200, Thomas Gleixner wrote:
> > > On Fri, 23 Sep 2016, Peter Zijlstra wrote:
> >
> > > > Is anybody still using PREEMPT_NONE? Most workloads also care about
> > > > latency to some extend. Lots of code has explicit cond_resched() and
> > > > doesn't worry.
> > >
> > > Dunno. But I bet there are workloads which love it.
> >
> > SUSE definitely uses it. I had presumed that was enterprise standard.
>
> Hmm, I thought most distros defaulted to PREEMPT_VOLUNTARY.
So what is the concensus on this? Switch dm-bufio's cond_resched calls
(in peter's patch) to might_sleep()? Or continue using cond_resched but
fix cond_resched to do the might_sleep() equivalent if PREEMPT_NONE?
Mike
next prev parent reply other threads:[~2016-09-23 12:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 8:45 [RFC][PATCH] dm: Remove dm_bufio_cond_resched() Peter Zijlstra
2016-09-13 12:49 ` Thomas Gleixner
2016-09-13 13:39 ` Mike Snitzer
2016-09-19 10:53 ` Peter Zijlstra
2016-09-22 20:53 ` Mikulas Patocka
2016-09-22 20:59 ` Thomas Gleixner
2016-09-23 7:34 ` Peter Zijlstra
2016-09-23 8:00 ` Thomas Gleixner
2016-09-23 9:05 ` Peter Zijlstra
2016-09-23 9:13 ` Thomas Gleixner
2016-09-23 9:26 ` Ingo Molnar
2016-09-23 12:17 ` Mike Galbraith
2016-09-23 12:26 ` Peter Zijlstra
2016-09-23 12:39 ` Mike Galbraith
2016-09-23 12:42 ` Mike Snitzer [this message]
2016-09-23 12:46 ` Peter Zijlstra
2016-09-23 14:32 ` [dm-devel] " Bart Van Assche
2016-09-23 14:32 ` Bart Van Assche
2016-09-19 9:49 ` Mikulas Patocka
2016-09-19 10:47 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923124251.GA22428@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpatocka@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.