Re: [Outreachy kernel] [PATCH] staging: octeon: Removing multiple blank lines

[Alison Schofield <amsfield22@gmail.com>]

On Tue, Sep 13, 2016 at 09:32:13PM +0530, Gargi Sharma wrote:
> Fixes the checkpatch issue Please don't use multiple blank lines.

Hi Gargi, 
Just a couple of minor format comments, but you may as well v2 this
to get it looking it's best in the git history.

Typically the commit message is written in the imperative format.  
That would be 'Remove' instead of 'Removing'.  It's really not
necessary to become a grammar expert ;)  just do a git pretty and
verify that your commit message is in the same style as the others
on the file you are changing:

git log --pretty=oneline --abbrev-commit  <filename>

Within the changelog you can just cut/paste the checkpatch message,
as in: CHECK: Please don't use multiple blank lines.  (Also tells 
CHECK or WARNING)

> Fixes the checkpatch issue: 
  CHECK: Please don't use multiple blank lines

Really minor stuff, but it keeps the uniformity which is nice.

alisons

alisons




> 
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
>  drivers/staging/octeon/ethernet.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 0bd5c18..ec8e424 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  	}
>  
> -
>  	cvm_oct_configure_common_hw();
>  
>  	cvmx_helper_initialize_packet_io_global();
> @@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
>  		}
>  	}
>  
> -
>  	cvmx_pko_shutdown();
>  
>  	cvmx_ipd_free_ptr();
> -- 
> 2.9.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160913160213.12708-1-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.