* [PATCH] staging: octeon: Removing multiple blank lines @ 2016-09-13 16:02 Gargi Sharma 2016-09-13 18:46 ` [Outreachy kernel] " Alison Schofield 0 siblings, 1 reply; 4+ messages in thread From: Gargi Sharma @ 2016-09-13 16:02 UTC (permalink / raw) To: outreachy-kernel; +Cc: gregkh, Gargi Sharma Fixes the checkpatch issue Please don't use multiple blank lines. Signed-off-by: Gargi Sharma <gs051095@gmail.com> --- drivers/staging/octeon/ethernet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index 0bd5c18..ec8e424 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev) return -EINVAL; } - cvm_oct_configure_common_hw(); cvmx_helper_initialize_packet_io_global(); @@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev) } } - cvmx_pko_shutdown(); cvmx_ipd_free_ptr(); -- 2.9.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: octeon: Removing multiple blank lines 2016-09-13 16:02 [PATCH] staging: octeon: Removing multiple blank lines Gargi Sharma @ 2016-09-13 18:46 ` Alison Schofield 2016-09-13 20:50 ` Gargi Sharma 0 siblings, 1 reply; 4+ messages in thread From: Alison Schofield @ 2016-09-13 18:46 UTC (permalink / raw) To: Gargi Sharma; +Cc: outreachy-kernel, gregkh On Tue, Sep 13, 2016 at 09:32:13PM +0530, Gargi Sharma wrote: > Fixes the checkpatch issue Please don't use multiple blank lines. Hi Gargi, Just a couple of minor format comments, but you may as well v2 this to get it looking it's best in the git history. Typically the commit message is written in the imperative format. That would be 'Remove' instead of 'Removing'. It's really not necessary to become a grammar expert ;) just do a git pretty and verify that your commit message is in the same style as the others on the file you are changing: git log --pretty=oneline --abbrev-commit <filename> Within the changelog you can just cut/paste the checkpatch message, as in: CHECK: Please don't use multiple blank lines. (Also tells CHECK or WARNING) > Fixes the checkpatch issue: CHECK: Please don't use multiple blank lines Really minor stuff, but it keeps the uniformity which is nice. alisons alisons > > Signed-off-by: Gargi Sharma <gs051095@gmail.com> > --- > drivers/staging/octeon/ethernet.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c > index 0bd5c18..ec8e424 100644 > --- a/drivers/staging/octeon/ethernet.c > +++ b/drivers/staging/octeon/ethernet.c > @@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev) > return -EINVAL; > } > > - > cvm_oct_configure_common_hw(); > > cvmx_helper_initialize_packet_io_global(); > @@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev) > } > } > > - > cvmx_pko_shutdown(); > > cvmx_ipd_free_ptr(); > -- > 2.9.2 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160913160213.12708-1-gs051095%40gmail.com. > For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: octeon: Removing multiple blank lines 2016-09-13 18:46 ` [Outreachy kernel] " Alison Schofield @ 2016-09-13 20:50 ` Gargi Sharma 2016-09-13 22:03 ` Alison Schofield 0 siblings, 1 reply; 4+ messages in thread From: Gargi Sharma @ 2016-09-13 20:50 UTC (permalink / raw) To: Alison Schofield; +Cc: outreachy-kernel, gregkh [-- Attachment #1: Type: text/plain, Size: 3015 bytes --] Hi Alison! On Wed, Sep 14, 2016 at 12:16 AM, Alison Schofield <amsfield22@gmail.com> wrote: > > On Tue, Sep 13, 2016 at 09:32:13PM +0530, Gargi Sharma wrote: > > Fixes the checkpatch issue Please don't use multiple blank lines. > > Hi Gargi, > Just a couple of minor format comments, but you may as well v2 this > to get it looking it's best in the git history. Should the v2 have a message stating that I fixed the commit message or the original commit message? gargi > > Typically the commit message is written in the imperative format. > That would be 'Remove' instead of 'Removing'. It's really not > necessary to become a grammar expert ;) just do a git pretty and > verify that your commit message is in the same style as the others > on the file you are changing: > > git log --pretty=oneline --abbrev-commit <filename> > > Within the changelog you can just cut/paste the checkpatch message, > as in: CHECK: Please don't use multiple blank lines. (Also tells > CHECK or WARNING) > > > Fixes the checkpatch issue: > CHECK: Please don't use multiple blank lines > > Really minor stuff, but it keeps the uniformity which is nice. > > alisons > > alisons > > > > > > > > Signed-off-by: Gargi Sharma <gs051095@gmail.com> > > --- > > drivers/staging/octeon/ethernet.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c > > index 0bd5c18..ec8e424 100644 > > --- a/drivers/staging/octeon/ethernet.c > > +++ b/drivers/staging/octeon/ethernet.c > > @@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev) > > return -EINVAL; > > } > > > > - > > cvm_oct_configure_common_hw(); > > > > cvmx_helper_initialize_packet_io_global(); > > @@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev) > > } > > } > > > > - > > cvmx_pko_shutdown(); > > > > cvmx_ipd_free_ptr(); > > -- > > 2.9.2 > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160913160213.12708-1-gs051095%40gmail.com . > > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160913184643.GA3351%40d830.WORKGROUP . > For more options, visit https://groups.google.com/d/optout. [-- Attachment #2: Type: text/html, Size: 4402 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: octeon: Removing multiple blank lines 2016-09-13 20:50 ` Gargi Sharma @ 2016-09-13 22:03 ` Alison Schofield 0 siblings, 0 replies; 4+ messages in thread From: Alison Schofield @ 2016-09-13 22:03 UTC (permalink / raw) To: Gargi Sharma; +Cc: outreachy-kernel, gregkh On Wed, Sep 14, 2016 at 02:20:01AM +0530, Gargi Sharma wrote: > Hi Alison! > On Wed, Sep 14, 2016 at 12:16 AM, Alison Schofield <amsfield22@gmail.com> > wrote: > > > > On Tue, Sep 13, 2016 at 09:32:13PM +0530, Gargi Sharma wrote: > > > Fixes the checkpatch issue Please don't use multiple blank lines. > > > > Hi Gargi, > > Just a couple of minor format comments, but you may as well v2 this > > to get it looking it's best in the git history. > > Should the v2 have a message stating that I fixed the commit message or the > original commit message? > > gargi There is a section in the first patch tutorial for this. See "Versioning one patch revision" alisons > > > > Typically the commit message is written in the imperative format. > > That would be 'Remove' instead of 'Removing'. It's really not > > necessary to become a grammar expert ;) just do a git pretty and > > verify that your commit message is in the same style as the others > > on the file you are changing: > > > > git log --pretty=oneline --abbrev-commit <filename> > > > > Within the changelog you can just cut/paste the checkpatch message, > > as in: CHECK: Please don't use multiple blank lines. (Also tells > > CHECK or WARNING) > > > > > Fixes the checkpatch issue: > > CHECK: Please don't use multiple blank lines > > > > Really minor stuff, but it keeps the uniformity which is nice. > > > > alisons > > > > alisons > > > > > > > > > > > > > > Signed-off-by: Gargi Sharma <gs051095@gmail.com> > > > --- > > > drivers/staging/octeon/ethernet.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/staging/octeon/ethernet.c > b/drivers/staging/octeon/ethernet.c > > > index 0bd5c18..ec8e424 100644 > > > --- a/drivers/staging/octeon/ethernet.c > > > +++ b/drivers/staging/octeon/ethernet.c > > > @@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device > *pdev) > > > return -EINVAL; > > > } > > > > > > - > > > cvm_oct_configure_common_hw(); > > > > > > cvmx_helper_initialize_packet_io_global(); > > > @@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device > *pdev) > > > } > > > } > > > > > > - > > > cvmx_pko_shutdown(); > > > > > > cvmx_ipd_free_ptr(); > > > -- > > > 2.9.2 > > > > > > -- > > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, send > an email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20160913160213.12708-1-gs051095%40gmail.com > . > > > For more options, visit https://groups.google.com/d/optout. > > > > -- > > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20160913184643.GA3351%40d830.WORKGROUP > . > > For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-13 22:03 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-13 16:02 [PATCH] staging: octeon: Removing multiple blank lines Gargi Sharma 2016-09-13 18:46 ` [Outreachy kernel] " Alison Schofield 2016-09-13 20:50 ` Gargi Sharma 2016-09-13 22:03 ` Alison Schofield
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.