[PATCH] Staging: iio: adc: Add space around '-'

[PATCH] Staging: iio: adc: Add space around '-'

[Sandhya Bankar]

Add space around operator '-' . 
This patch is found by checkpatch.pl script .
CHECK: spaces preferred around that '-' (ctx:VxV) . 

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 1cf6b79..5688b29 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev,
 }
 
 static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
-			     in_voltage-voltage_scale_available,
+			     in_voltage - voltage_scale_available,
 			     S_IRUGO, ad7192_show_scale_available, NULL, 0);
 
 static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
-- 
1.8.2.3

Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Add space around '-'

[Julia Lawall]

Is there no other maintainer that should receive this?

julia

On Wed, 14 Sep 2016, Sandhya Bankar wrote:

> Add space around operator '-' .
> This patch is found by checkpatch.pl script .
> CHECK: spaces preferred around that '-' (ctx:VxV) .
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/iio/adc/ad7192.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 1cf6b79..5688b29 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev,
>  }
>
>  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> -			     in_voltage-voltage_scale_available,
> +			     in_voltage - voltage_scale_available,
>  			     S_IRUGO, ad7192_show_scale_available, NULL, 0);
>
>  static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
> --
> 1.8.2.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914110228.GA3269%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Add space around '-'

[Sandhya Bankar]

[-- Attachment #1.1: Type: text/plain, Size: 1823 bytes --]



On Wednesday, September 14, 2016 at 5:58:33 PM UTC+5:30, Julia Lawall wrote:
>
> Is there no other maintainer that should receive this? 
>
> julia 
>
> On Wed, 14 Sep 2016, Sandhya Bankar wrote: 
>
> > Add space around operator '-' . 
> > This patch is found by checkpatch.pl script . 
> > CHECK: spaces preferred around that '-' (ctx:VxV) . 
> > 
> > Signed-off-by: Sandhya Bankar <bankarsa...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/iio/adc/ad7192.c | 2 +- 
> >  1 file changed, 1 insertion(+), 1 deletion(-) 
> > 
> > diff --git a/drivers/staging/iio/adc/ad7192.c 
> b/drivers/staging/iio/adc/ad7192.c 
> > index 1cf6b79..5688b29 100644 
> > --- a/drivers/staging/iio/adc/ad7192.c 
> > +++ b/drivers/staging/iio/adc/ad7192.c 
> > @@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev, 
> >  } 
> > 
> >  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, 
> > -                             in_voltage-voltage_scale_available, 
> > +                             in_voltage - voltage_scale_available, 
> >                               S_IRUGO, ad7192_show_scale_available, 
> NULL, 0); 
> > 
> >  static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO, 
> > -- 
> > 1.8.2.3 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreachy-kern...@googlegroups.com <javascript:>. 
> > To post to this group, send email to outreach...@googlegroups.com 
> <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20160914110228.GA3269%40sandhya. 
>
> > For more options, visit https://groups.google.com/d/optout. 
>




 Thanks for pointing out. I will do that with v2.

[-- Attachment #1.2: Type: text/html, Size: 3961 bytes --]

Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Add space around '-'

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2830 bytes --]



On Wed, 14 Sep 2016, Sandhya Bankar wrote:

>
>
> On Wednesday, September 14, 2016 at 5:58:33 PM UTC+5:30, Julia Lawall wrote:
>       Is there no other maintainer that should receive this?
>
>       julia
>
>       On Wed, 14 Sep 2016, Sandhya Bankar wrote:
>
>       > Add space around operator '-' .
>       > This patch is found by checkpatch.pl script .
>       > CHECK: spaces preferred around that '-' (ctx:VxV) .
>       >
>       > Signed-off-by: Sandhya Bankar <bankarsa...@gmail.com>
>       > ---
>       >  drivers/staging/iio/adc/ad7192.c | 2 +-
>       >  1 file changed, 1 insertion(+), 1 deletion(-)
>       >
>       > diff --git a/drivers/staging/iio/adc/ad7192.c
>       b/drivers/staging/iio/adc/ad7192.c
>       > index 1cf6b79..5688b29 100644
>       > --- a/drivers/staging/iio/adc/ad7192.c
>       > +++ b/drivers/staging/iio/adc/ad7192.c
>       > @@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device
>       *dev,
>       >  }
>       >
>       >  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
>       > -                            
>       in_voltage-voltage_scale_available,
>       > +                             in_voltage -
>       voltage_scale_available,
>       >                               S_IRUGO,
>       ad7192_show_scale_available, NULL, 0);
>       >
>       >  static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
>       > --
>       > 1.8.2.3
>       >
>       > --
>       > You received this message because you are subscribed to the
>       Google Groups "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from
>       it, send an email to outreachy-kern...@googlegroups.com.
>       > To post to this group, send email to
>       outreach...@googlegroups.com.
>       > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20160914110228.GA3269%40
>       sandhya.
>       > For more options, visit https://groups.google.com/d/optout.
>
>
>
>
>
>  Thanks for pointing out. I will do that with v2.

OK.  While you should not top post, it is also good to respond right under
what the other person has said, instead of the end of the message.

julia

>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/35a8014f-c63b-46eb-87fe-
> e54db1d9d8a3%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [PATCH] Staging: iio: adc: Add space around '-'

[Katie Dunne]

On Fri, Sep 16, 2016 at 08:08:51AM -0700, Katherine Dunne wrote:
> 
> 
> On Wednesday, September 14, 2016 at 4:01:57 AM UTC-7, Sandhya Bankar wrote:
> >
> > Add space around operator '-' . 
> > This patch is found by checkpatch.pl script . 
> > CHECK: spaces preferred around that '-' (ctx:VxV) . 

Hi Sandhya,

This is a false positive from checkpatch. To save you
some time here is the response from Jonathan:

"Just to explain a bit more.  Checkpatch is assuming that it is looking
at two parameters. It's not. That's a string being passed into the
macro.  It ultimately forms a file name in sysfs. 

p.s. We get patches for this from time to time ;(  Unfortunately
it's a somewhat obscure case for checkpatch."

Regards,
Katie

> > Signed-off-by: Sandhya Bankar <bankarsa...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/iio/adc/ad7192.c | 2 +- 
> >  1 file changed, 1 insertion(+), 1 deletion(-) 
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c 
> > b/drivers/staging/iio/adc/ad7192.c 
> > index 1cf6b79..5688b29 100644 
> > --- a/drivers/staging/iio/adc/ad7192.c 
> > +++ b/drivers/staging/iio/adc/ad7192.c 
> > @@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev, 
> >  } 
> >   
> >  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, 
> > -                             in_voltage-voltage_scale_available, 
> > +                             in_voltage - voltage_scale_available, 
> >                               S_IRUGO, ad7192_show_scale_available, NULL, 
> > 0); 
> >   
> >  static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO, 
> > -- 
> > 1.8.2.3 
> >
> >