[PATCH v2] Staging: ethernet: Fixes checkpatch blank lines warnings

[PATCH v2] Staging: ethernet: Fixes checkpatch blank lines warnings

[Ronald Rojas]

This patch fixes several of the checkpatch.pl warnings
in the driver/staging/octeon/ethernet.c file.
All of the errors were "Please don't use multiple blank lines"
and the appropriate lines were deleted at lines 89, 668, and 881.
89.

Signed-off-by: Ronald Rojas <ronladred@gmail.com>
---
 drivers/staging/octeon/ethernet.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index e9cd5f2..79571d6 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
 module_param(rx_napi_weight, int, 0444);
 MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
 
-
 /*
  * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
  *
@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-
 	cvm_oct_configure_common_hw();
 
 	cvmx_helper_initialize_packet_io_global();
@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
 		}
 	}
 
-
 	cvmx_pko_shutdown();
 
 	cvmx_ipd_free_ptr();
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v2] Staging: ethernet: Fixes checkpatch blank lines warnings

[Julia Lawall]

On Wed, 14 Sep 2016, Ronald Rojas wrote:

> This patch fixes several of the checkpatch.pl warnings
> in the driver/staging/octeon/ethernet.c file.
> All of the errors were "Please don't use multiple blank lines"
> and the appropriate lines were deleted at lines 89, 668, and 881.
> 89.

It's better, but it's still too much.  You don't need the file name - that
is clear from the diffstat just below the ---.  And you don't need the
line numbers.  The commit log could be "Remove the second of a pair of
blank lines.  Problem detected by checkpatch."

> Signed-off-by: Ronald Rojas <ronladred@gmail.com>
> ---

Here you should put

v2: changed commit log

julia

>  drivers/staging/octeon/ethernet.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index e9cd5f2..79571d6 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -86,7 +86,6 @@ int rx_napi_weight = 32;
>  module_param(rx_napi_weight, int, 0444);
>  MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
>
> -
>  /*
>   * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
>   *
> @@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  	}
>
> -
>  	cvm_oct_configure_common_hw();
>
>  	cvmx_helper_initialize_packet_io_global();
> @@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
>  		}
>  	}
>
> -
>  	cvmx_pko_shutdown();
>
>  	cvmx_ipd_free_ptr();
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914180614.GA4299%40fedora.
> For more options, visit https://groups.google.com/d/optout.
>