* [PATCH] Staging: wlan-ng: Use x instead of x != NULL.
@ 2016-03-21 15:16 Sandhya Bankar
0 siblings, 0 replies; 3+ messages in thread
From: Sandhya Bankar @ 2016-03-21 15:16 UTC (permalink / raw)
To: outreachy-kernel
Use x instead of x != NULL.This issue is detected by checkpatch.pl script.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/wlan-ng/p80211netdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 88255ce..fdfc821 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -156,7 +156,7 @@ static int p80211knetdev_open(netdevice_t *netdev)
return -ENODEV;
/* Tell the MSD to open */
- if (wlandev->open != NULL) {
+ if (wlandev->open) {
result = wlandev->open(wlandev);
if (result == 0) {
netif_start_queue(wlandev->netdev);
@@ -186,7 +186,7 @@ static int p80211knetdev_stop(netdevice_t *netdev)
int result = 0;
wlandevice_t *wlandev = netdev->ml_priv;
- if (wlandev->close != NULL)
+ if (wlandev->close)
result = wlandev->close(wlandev);
netif_stop_queue(wlandev->netdev);
--
1.8.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Staging: wlan-ng: Use !x instead of x == NULL.
@ 2016-09-15 8:04 Sandhya Bankar
2016-09-15 8:05 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Sandhya Bankar @ 2016-09-15 8:04 UTC (permalink / raw)
To: outreachy-kernel
Cc: gregkh, claudiu.beznea, johannes.berg, gavinoleary3, brcnakalin,
avraham.stern, brutallesale
Use !x instead of x == NULL.
This patch is detected by checkpatch.pl script.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/wlan-ng/cfg80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index a36e40d..884d0d5 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -265,7 +265,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
memset(sinfo, 0, sizeof(*sinfo));
- if ((wlandev == NULL) || (wlandev->msdstate != WLAN_MSD_RUNNING))
+ if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
return -EOPNOTSUPP;
/* build request message */
@@ -274,7 +274,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
quality.dbm.status = P80211ENUM_msgitem_status_data_ok;
/* send message to nsd */
- if (wlandev->mlmerequest == NULL)
+ if (!wlandev->mlmerequest)
return -EOPNOTSUPP;
result = wlandev->mlmerequest(wlandev, (struct p80211msg *)&quality);
--
1.8.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: wlan-ng: Use !x instead of x == NULL.
2016-09-15 8:04 [PATCH] Staging: wlan-ng: Use !x instead of x == NULL Sandhya Bankar
@ 2016-09-15 8:05 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2016-09-15 8:05 UTC (permalink / raw)
To: Sandhya Bankar
Cc: outreachy-kernel, gregkh, claudiu.beznea, johannes.berg,
gavinoleary3, brcnakalin, avraham.stern, brutallesale
On Thu, 15 Sep 2016, Sandhya Bankar wrote:
> Use !x instead of x == NULL.
> This patch is detected by checkpatch.pl script.
The second sentence owuld be better as:
This issue was detected by checkpatch.
I guess you made the patch yourself.
julia
>
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/wlan-ng/cfg80211.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index a36e40d..884d0d5 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -265,7 +265,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
>
> memset(sinfo, 0, sizeof(*sinfo));
>
> - if ((wlandev == NULL) || (wlandev->msdstate != WLAN_MSD_RUNNING))
> + if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
> return -EOPNOTSUPP;
>
> /* build request message */
> @@ -274,7 +274,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
> quality.dbm.status = P80211ENUM_msgitem_status_data_ok;
>
> /* send message to nsd */
> - if (wlandev->mlmerequest == NULL)
> + if (!wlandev->mlmerequest)
> return -EOPNOTSUPP;
>
> result = wlandev->mlmerequest(wlandev, (struct p80211msg *)&quality);
> --
> 1.8.2.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160915080438.GA6782%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-15 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-15 8:04 [PATCH] Staging: wlan-ng: Use !x instead of x == NULL Sandhya Bankar
2016-09-15 8:05 ` [Outreachy kernel] " Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2016-03-21 15:16 [PATCH] Staging: wlan-ng: Use x instead of x != NULL Sandhya Bankar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.