[PATCH v2] Staging: wlan-ng: Use !x instead of x == NULL.

[PATCH v2] Staging: wlan-ng: Use !x instead of x == NULL.

[Sandhya Bankar]

Use !x instead of x == NULL.
This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
Changes in v2:
* Correcting the commit message.
 drivers/staging/wlan-ng/cfg80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index a36e40d..884d0d5 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -265,7 +265,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
 
 	memset(sinfo, 0, sizeof(*sinfo));
 
-	if ((wlandev == NULL) || (wlandev->msdstate != WLAN_MSD_RUNNING))
+	if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
 		return -EOPNOTSUPP;
 
 	/* build request message */
@@ -274,7 +274,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
 	quality.dbm.status = P80211ENUM_msgitem_status_data_ok;
 
 	/* send message to nsd */
-	if (wlandev->mlmerequest == NULL)
+	if (!wlandev->mlmerequest)
 		return -EOPNOTSUPP;
 
 	result = wlandev->mlmerequest(wlandev, (struct p80211msg *)&quality);
-- 
1.8.2.3

Re: [Outreachy kernel] [PATCH v2] Staging: wlan-ng: Use !x instead of x == NULL.

[Julia Lawall]

On Thu, 15 Sep 2016, Sandhya Bankar wrote:

> Use !x instead of x == NULL.
> This issue was found by checkpatch.

Looks better :)

julia

>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> Changes in v2:
> * Correcting the commit message.
>  drivers/staging/wlan-ng/cfg80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index a36e40d..884d0d5 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -265,7 +265,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
>
>  	memset(sinfo, 0, sizeof(*sinfo));
>
> -	if ((wlandev == NULL) || (wlandev->msdstate != WLAN_MSD_RUNNING))
> +	if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
>  		return -EOPNOTSUPP;
>
>  	/* build request message */
> @@ -274,7 +274,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
>  	quality.dbm.status = P80211ENUM_msgitem_status_data_ok;
>
>  	/* send message to nsd */
> -	if (wlandev->mlmerequest == NULL)
> +	if (!wlandev->mlmerequest)
>  		return -EOPNOTSUPP;
>
>  	result = wlandev->mlmerequest(wlandev, (struct p80211msg *)&quality);
> --
> 1.8.2.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160915082251.GA6833%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>