[PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings

[PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings

[Ronald Rojas]

Fixes several of the checkpatch.pl warning
CHECK: Please don't use multiple blank lines

Signed-off-by: Ronald Rojas <ronladred@gmail.com>
---
v5: changes to commit log

 drivers/staging/octeon/ethernet.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index e9cd5f2..79571d6 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
 module_param(rx_napi_weight, int, 0444);
 MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
 
-
 /*
  * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
  *
@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-
 	cvm_oct_configure_common_hw();
 
 	cvmx_helper_initialize_packet_io_global();
@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
 		}
 	}
 
-
 	cvmx_pko_shutdown();
 
 	cvmx_ipd_free_ptr();
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings

[Arnd Bergmann]

On Thursday, September 15, 2016 8:24:26 AM CEST Ronald Rojas wrote:
> Fixes several of the checkpatch.pl warning
> CHECK: Please don't use multiple blank lines
> 
> Signed-off-by: Ronald Rojas <ronladred@gmail.com>

In the subject line, please use "octeon" instead of "ethernet".

Did you build test this driver using a MIPS cross-compiler?
I realize that it's just a whitespace change and it clearly
won't break anything, but in general you should do some
build testing before sending it out, and properly building
this driver is a bit tricky.

	Arnd

Re: [Outreachy kernel] [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings

[Julia Lawall]

On Thu, 15 Sep 2016, Arnd Bergmann wrote:

> On Thursday, September 15, 2016 8:24:26 AM CEST Ronald Rojas wrote:
> > Fixes several of the checkpatch.pl warning
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Ronald Rojas <ronladred@gmail.com>
>
> In the subject line, please use "octeon" instead of "ethernet".

In general, you can't make up your own formula for creating the subject
line.  You have to see what others have done, because different subsystems
use different strategies.  To see what others have done, do:

git log --oneline filename.c

julia

>
> Did you build test this driver using a MIPS cross-compiler?
> I realize that it's just a whitespace change and it clearly
> won't break anything, but in general you should do some
> build testing before sending it out, and properly building
> this driver is a bit tricky.
>
> 	Arnd
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/15778561.A1ImvO0lIj%40wuerfel.
> For more options, visit https://groups.google.com/d/optout.
>

[PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings

[Ronald Rojas]

This patch fixes several of the checkpatch.pl warnings
in the driver/staging/octeon/ethernet.c file:

CHECK: Please don't use multiple blank lines
89: FILE: drivers/staging/octeon/ethernet.c:89:

CHECK: Please don't use multiple blank lines
668: FILE: drivers/staging/octeon/ethernet.c:668:

CHECK: Please don't use multiple blank lines
881: FILE: drivers/staging/octeon/ethernet.c:881:

Signed-off-by: Ronald Rojas <ronladred@gmail.com>
---
 drivers/staging/octeon/ethernet.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index e9cd5f2..79571d6 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
 module_param(rx_napi_weight, int, 0444);
 MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
 
-
 /*
  * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
  *
@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-
 	cvm_oct_configure_common_hw();
 
 	cvmx_helper_initialize_packet_io_global();
@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
 		}
 	}
 
-
 	cvmx_pko_shutdown();
 
 	cvmx_ipd_free_ptr();
-- 
2.7.4